RE: [RFC,BlueZ] mesh: Allow calls to Attach/Leave before replying to JoinComplete

[bluez.test.bot@gmail.com]

[-- Attachment #1: Type: text/plain, Size: 1333 bytes --]


This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
While we are preparing for reviewing the patches, we found the following
issue/warning.

Test Result:
checkpatch Failed

Outputs:
WARNING:LINE_SPACING: Missing a blank line after declarations
#107: FILE: mesh/mesh.c:466:
+	struct call_data *pending_call = l_new(struct call_data, 1);
+	pending_call->node = node;

WARNING:LINE_SPACING: Missing a blank line after declarations
#157: FILE: mesh/mesh.c:704:
+		struct mesh_node *node = node_find_by_token(token);
+		queue_pending_call(node, attach_call, msg, user_data);

ERROR:OPEN_BRACE: that open brace { should be on the previous line
#170: FILE: mesh/mesh.c:726:
+	if (!node_remove(node))
+	{

- total: 1 errors, 2 warnings, 269 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

Your patch has style problems, please review.

NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPLIT_STRING

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.



---
Regards,
Linux Bluetooth