From: Derrick Stolee <derrickstolee@github.com>
To: Jeff King <peff@peff.net>, git@vger.kernel.org
Cc: Han-Wen Nienhuys <hanwen@google.com>
Subject: Re: [PATCH 5/6] reftable: drop unused parameter from reader_seek_linear()
Date: Fri, 19 Aug 2022 15:06:23 -0400 [thread overview]
Message-ID: <5f10be7e-424a-ed3b-bb77-75f1e026b2ae@github.com> (raw)
In-Reply-To: <Yv9P4O3WCrR9f9o2@coredump.intra.peff.net>
On 8/19/2022 4:54 AM, Jeff King wrote:
> The reader code passes around a "struct reftable_reader" context
> variable. But the seek function doesn't need it; the table iterator we
> already get is sufficient.
>
> Signed-off-by: Jeff King <peff@peff.net>
> ---
> One could argue that this is a method of a reftable_reader following the
> usual C object-oriented naming conventions, and thus should retain its
> first parameter, even if it isn't directly used.
> -static int reader_seek_linear(struct reftable_reader *r, struct table_iter *ti,
> +static int reader_seek_linear(struct table_iter *ti,
> struct reftable_record *want)
If we wanted to make it seem more like it was a method of something,
it now looks to operate on the table_iter, so the method name could
change to something like "table_seek_linear()" which might satisfy
both goals.
Thanks,
-Stolee
next prev parent reply other threads:[~2022-08-19 19:06 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-19 8:48 [PATCH 0/6] unused function parameter potpourri Jeff King
2022-08-19 8:49 ` [PATCH 1/6] xdiff: drop unused mmfile parameters from xdl_do_histogram_diff() Jeff King
2022-08-19 13:32 ` Phillip Wood
2022-08-20 6:58 ` Jeff King
2022-08-20 7:36 ` [PATCH 7/6] xdiff: drop unused mmfile parameters from xdl_do_patience_diff() Jeff King
2022-08-26 13:15 ` Phillip Wood
2022-08-19 8:50 ` [PATCH 2/6] log-tree: drop unused commit param in remerge_diff() Jeff King
2022-08-19 23:05 ` Elijah Newren
2022-08-20 7:04 ` Jeff King
2022-08-19 8:50 ` [PATCH 3/6] match_pathname(): drop unused "flags" parameter Jeff King
2022-08-19 8:51 ` [PATCH 4/6] verify_one_sparse(): drop unused repository parameter Jeff King
2022-08-19 19:04 ` Derrick Stolee
2022-08-20 7:01 ` Jeff King
2022-08-20 8:48 ` René Scharfe
2022-08-20 9:02 ` [PATCH v2 " Jeff King
2022-08-19 8:54 ` [PATCH 5/6] reftable: drop unused parameter from reader_seek_linear() Jeff King
2022-08-19 19:06 ` Derrick Stolee [this message]
2022-08-22 7:46 ` Han-Wen Nienhuys
2022-08-19 8:55 ` [PATCH 6/6] reflog: assert PARSE_OPT_NONEG in parse-options callbacks Jeff King
2022-08-19 19:08 ` [PATCH 0/6] unused function parameter potpourri Derrick Stolee
2022-08-19 23:07 ` Elijah Newren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5f10be7e-424a-ed3b-bb77-75f1e026b2ae@github.com \
--to=derrickstolee@github.com \
--cc=git@vger.kernel.org \
--cc=hanwen@google.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.