From: Stephen Boyd <sboyd@kernel.org>
To: Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Michael Turquette <mturquette@baylibre.com>,
Neil Armstrong <neil.armstrong@linaro.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
Rob Herring <robh+dt@kernel.org>,
Taniya Das <quic_tdas@quicinc.com>
Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 10/10] clk: qcom: rpmh: add clocks for SM8650
Date: Wed, 25 Oct 2023 14:47:13 -0700 [thread overview]
Message-ID: <5f157c65b07eee357f7682be0945d638.sboyd@kernel.org> (raw)
In-Reply-To: <be119e71-0456-4806-8c0a-e77732553f70@linaro.org>
Quoting Neil Armstrong (2023-10-25 05:00:54)
> On 25/10/2023 10:47, Konrad Dybcio wrote:
> >
> >
> > On 10/25/23 09:32, Neil Armstrong wrote:
> >> Add RPMH Clocks for the SM8650 platform.
> >>
> >> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
> >> ---
> > [...]
> >
> >> +static struct clk_hw *sm8650_rpmh_clocks[] = {
> >> + [RPMH_CXO_CLK] = &clk_rpmh_bi_tcxo_div2.hw,
> >> + [RPMH_CXO_CLK_A] = &clk_rpmh_bi_tcxo_div2_ao.hw,
> >> + [RPMH_LN_BB_CLK1] = &clk_rpmh_clk6_a2.hw,
> >> + [RPMH_LN_BB_CLK1_A] = &clk_rpmh_clk6_a2_ao.hw,
> >> + [RPMH_LN_BB_CLK2] = &clk_rpmh_clk7_a2.hw,
> >> + [RPMH_LN_BB_CLK2_A] = &clk_rpmh_clk7_a2_ao.hw,
> >> + [RPMH_LN_BB_CLK3] = &clk_rpmh_clk8_a2.hw,
> >> + [RPMH_LN_BB_CLK3_A] = &clk_rpmh_clk8_a2_ao.hw,
> >> + [RPMH_RF_CLK1] = &clk_rpmh_clk1_a1.hw,
> >> + [RPMH_RF_CLK1_A] = &clk_rpmh_clk1_a1_ao.hw,
> >> + [RPMH_RF_CLK2] = &clk_rpmh_clk2_a1.hw,
> >> + [RPMH_RF_CLK2_A] = &clk_rpmh_clk2_a1_ao.hw,
> >> + /* missing RPMh resource address for clka3 */
> > So, the downstream driver suggested it's there but CMD-DB disagrees?
> >
> > Can we get a confirmation whether it should be there?
>
> There's a clka3 on the PMK8550, but it's undeclared in CMD-DB since
> unused/unconnected on the MTP & QRD platforms.
Can you add that comment here so we know why the resource is missing and
not just that it is missing?
next prev parent reply other threads:[~2023-10-25 21:47 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-25 7:32 [PATCH 00/10] clk: qcom: Introduce clocks drivers for SM8650 Neil Armstrong
2023-10-25 7:32 ` [PATCH 01/10] dt-bindings: clock: qcom: document the SM8650 TCSR Clock Controller Neil Armstrong
2023-10-27 7:24 ` Krzysztof Kozlowski
2023-10-25 7:32 ` [PATCH 02/10] dt-bindings: clock: qcom: document the SM8650 General " Neil Armstrong
2023-10-27 7:25 ` Krzysztof Kozlowski
2023-10-25 7:32 ` [PATCH 03/10] dt-bindings: clock: qcom: document the SM8650 Display " Neil Armstrong
2023-10-25 14:47 ` Rob Herring
2023-10-25 19:49 ` Rob Herring
2023-10-25 19:40 ` Rob Herring
2023-10-27 7:28 ` Krzysztof Kozlowski
2023-10-25 7:32 ` [PATCH 04/10] dt-bindings: clock: qcom: document the SM8650 GPU " Neil Armstrong
2023-10-25 19:40 ` Rob Herring
2023-10-25 7:32 ` [PATCH 05/10] dt-bindings: clock: qcom-rpmhcc: document the SM8650 RPMH " Neil Armstrong
2023-10-25 19:49 ` Rob Herring
2023-10-25 7:32 ` [PATCH 06/10] clk: qcom: add the SM8650 Global Clock Controller driver Neil Armstrong
2023-10-25 8:41 ` Konrad Dybcio
2023-10-26 11:51 ` Neil Armstrong
2023-10-25 7:32 ` [PATCH 07/10] clk: qcom: add the SM8650 TCSR " Neil Armstrong
2023-10-25 8:38 ` Dmitry Baryshkov
2023-10-25 8:43 ` Konrad Dybcio
2023-10-25 11:56 ` Neil Armstrong
2023-10-25 7:32 ` [PATCH 08/10] clk: qcom: add the SM8650 Display " Neil Armstrong
2023-10-25 8:45 ` Konrad Dybcio
2023-10-26 12:02 ` Neil Armstrong
2023-10-25 21:45 ` Stephen Boyd
2023-10-26 12:27 ` Neil Armstrong
2023-10-25 7:32 ` [PATCH 09/10] clk: qcom: add the SM8650 GPU " Neil Armstrong
2023-10-25 8:46 ` Konrad Dybcio
2023-10-25 7:32 ` [PATCH 10/10] clk: qcom: rpmh: add clocks for SM8650 Neil Armstrong
2023-10-25 8:45 ` Dmitry Baryshkov
2023-10-25 8:47 ` Konrad Dybcio
2023-10-25 12:00 ` Neil Armstrong
2023-10-25 21:47 ` Stephen Boyd [this message]
2023-10-26 12:17 ` Neil Armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5f157c65b07eee357f7682be0945d638.sboyd@kernel.org \
--to=sboyd@kernel.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=neil.armstrong@linaro.org \
--cc=p.zabel@pengutronix.de \
--cc=quic_tdas@quicinc.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.