All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: michaelestner@web.de, bitbake-devel@lists.openembedded.org
Subject: Re: [bitbake-devel][PATCH 1/1] utils: pylint: clean up imports
Date: Tue, 18 Feb 2025 23:10:06 +0000	[thread overview]
Message-ID: <5f208b50fbc0976804716a11c0f230fa8ca312ae.camel@linuxfoundation.org> (raw)
In-Reply-To: <20250217152953.70557-1-michaelestner@web.de>

On Mon, 2025-02-17 at 16:29 +0100, Michael Estner via
lists.openembedded.org wrote:
> As mentioned in the TODO file I run pylint
> and start clean code including:
> Remove double imports
> Order the imports as mentioned by pylint.
> First small patch to see if what I do
> fits the expectations.
> 
> Signed-off-by: Michael Estner <michaelestner@web.de>
> ---
>  lib/bb/utils.py | 10 +++-------
>  1 file changed, 3 insertions(+), 7 deletions(-)

Thanks for this. The patch itself was fine and I've merged it. I did
need to tweak the commit message itself a little bit to be more focused
on the patch and have correct line wrapping.

I was initially a bit worried as the TODO file hasn't been touched in a
long time but you did pick a sensible improvement so well done for
filtering it to something useful.

I would warn that we wouldn't necessarily act on everything suggested
by the linter, we'd prefer to focus on "real" issues. Unneeded imports
definitely fit into that category.

I'll try and find some time to clean up that TODO file a bit.

Cheers,

Richard


      reply	other threads:[~2025-02-18 23:10 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-17 15:29 [bitbake-devel][PATCH 1/1] utils: pylint: clean up imports Michael Estner
2025-02-18 23:10 ` Richard Purdie [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5f208b50fbc0976804716a11c0f230fa8ca312ae.camel@linuxfoundation.org \
    --to=richard.purdie@linuxfoundation.org \
    --cc=bitbake-devel@lists.openembedded.org \
    --cc=michaelestner@web.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.