All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Boyd <sboyd@kernel.org>
To: Bjorn Andersson <andersson@kernel.org>,
	Gabor Juhos <j4g8y7@gmail.com>,
	Michael Turquette <mturquette@baylibre.com>
Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
	linux-kernel@vger.kernel.org, stable@vger.kernel.org,
	Gabor Juhos <j4g8y7@gmail.com>
Subject: Re: [PATCH] clk: qcom: clk-alpha-pll: fix alpha mode configuration
Date: Mon, 21 Oct 2024 11:14:44 -0700	[thread overview]
Message-ID: <5f39a93197f02fa7ec0de897a7ce646d.sboyd@kernel.org> (raw)
In-Reply-To: <20241021-fix-alpha-mode-config-v1-1-f32c254e02bc@gmail.com>

Quoting Gabor Juhos (2024-10-21 10:32:48)
> Commit c45ae598fc16 ("clk: qcom: support for alpha mode configuration")
> added support for configuring alpha mode, but it seems that the feature
> was never working in practice.
> 
[...]
> 
> Applying the 'alpha_en_mask' fixes the initial rate of the PLLs showed
> in the table above. Since the 'alpha_mode_mask' is not used by any driver
> currently, that part of the change causes no functional changes.
> 
> Cc: stable@vger.kernel.org
> Fixes: c45ae598fc16 ("clk: qcom: support for alpha mode configuration")
> Signed-off-by: Gabor Juhos <j4g8y7@gmail.com>
> ---
> diff --git a/drivers/clk/qcom/clk-alpha-pll.c b/drivers/clk/qcom/clk-alpha-pll.c
> index f9105443d7dbb104e3cb091e59f43df25999f8b3..03cc7aa092480bfdd9eaa986d44f0545944b3b89 100644
> --- a/drivers/clk/qcom/clk-alpha-pll.c
> +++ b/drivers/clk/qcom/clk-alpha-pll.c
> @@ -421,6 +421,8 @@ void clk_alpha_pll_configure(struct clk_alpha_pll *pll, struct regmap *regmap,
>         mask |= config->pre_div_mask;
>         mask |= config->post_div_mask;
>         mask |= config->vco_mask;
> +       mask |= config->alpha_en_mask;
> +       mask |= config->alpha_mode_mask;
>  

This is https://lore.kernel.org/all/20241019-qcs615-mm-clockcontroller-v1-1-4cfb96d779ae@quicinc.com/

  reply	other threads:[~2024-10-21 18:14 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-21 17:32 [PATCH] clk: qcom: clk-alpha-pll: fix alpha mode configuration Gabor Juhos
2024-10-21 18:14 ` Stephen Boyd [this message]
2024-10-21 19:03   ` Gabor Juhos
2024-12-27  4:15 ` Bjorn Andersson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5f39a93197f02fa7ec0de897a7ce646d.sboyd@kernel.org \
    --to=sboyd@kernel.org \
    --cc=andersson@kernel.org \
    --cc=j4g8y7@gmail.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.