From: Roman Kisel <romank@linux.microsoft.com>
To: Naman Jain <namjain@linux.microsoft.com>
Cc: linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@kernel.org, namjain@microsoft.com,
"K . Y . Srinivasan" <kys@microsoft.com>,
Haiyang Zhang <haiyangz@microsoft.com>,
Wei Liu <wei.liu@kernel.org>, Dexuan Cui <decui@microsoft.com>,
Michael Kelley <mhklinux@outlook.com>
Subject: Re: [PATCH] Drivers: hv: Fix the check for HYPERVISOR_CALLBACK_VECTOR
Date: Mon, 7 Jul 2025 10:58:03 -0700 [thread overview]
Message-ID: <5f3ca2ac-cf06-4c81-89bd-e8685b222aa9@linux.microsoft.com> (raw)
In-Reply-To: <20250707084322.1763-1-namjain@linux.microsoft.com>
On 7/7/2025 1:43 AM, Naman Jain wrote:
> __is_defined(HYPERVISOR_CALLBACK_VECTOR) would return 1, only if
> HYPERVISOR_CALLBACK_VECTOR macro is defined as 1. However its value is
> 0xf3 and this leads to __is_defined() returning 0. The expectation
> was to just check whether this MACRO is defined or not and get 1 if
> it's defined. Replace __is_defined with #ifdef blocks instead to
> fix it.
>
> Fixes: 1dc5df133b98 ("Drivers: hv: vmbus: Get the IRQ number from DeviceTree")
> Cc: stable@kernel.org
> Signed-off-by: Naman Jain <namjain@linux.microsoft.com>
> ---
[...]
Appreciate fixing that! From what I learned from you, x86 was broken.
Very likely I did a smoke test there only while focusing on arm64. Sorry
about that, thanks again!!
LGTM.
Reviewed-by: Roman Kisel <romank@linux.microsoft.com
>
>
> base-commit: 26ffb3d6f02cd0935fb9fa3db897767beee1cb2a
--
Thank you,
Roman
next prev parent reply other threads:[~2025-07-07 17:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-07 8:43 [PATCH] Drivers: hv: Fix the check for HYPERVISOR_CALLBACK_VECTOR Naman Jain
2025-07-07 17:58 ` Roman Kisel [this message]
2025-07-09 23:24 ` Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5f3ca2ac-cf06-4c81-89bd-e8685b222aa9@linux.microsoft.com \
--to=romank@linux.microsoft.com \
--cc=decui@microsoft.com \
--cc=haiyangz@microsoft.com \
--cc=kys@microsoft.com \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mhklinux@outlook.com \
--cc=namjain@linux.microsoft.com \
--cc=namjain@microsoft.com \
--cc=stable@kernel.org \
--cc=wei.liu@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.