All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Laight <David.Laight@ACULAB.COM>
To: 'Eric Sandeen' <sandeen@sandeen.net>,
	Zheng Yongjun <zhengyongjun3@huawei.com>,
	"linux-xfs@vger.kernel.org" <linux-xfs@vger.kernel.org>,
	"darrick.wong@oracle.com" <darrick.wong@oracle.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH -next] fs/xfs: convert comma to semicolon
Date: Fri, 11 Dec 2020 16:17:47 +0000	[thread overview]
Message-ID: <5f4ee9cf48a445cea25ba01bc9ffdf13@AcuMS.aculab.com> (raw)
In-Reply-To: <fd372b27-983d-00ff-5218-4082fe2f08df@sandeen.net>

From: Eric Sandeen
> Sent: 11 December 2020 15:51
> 
> On 12/11/20 2:41 AM, Zheng Yongjun wrote:
> > Replace a comma between expression statements by a semicolon.
> >
> > Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com>
> 
> hah, that's an old one.  Harmless though, AFAICT.
> 
> this fixes 91cca5df9bc8 ("[XFS] implement generic xfs_btree_delete/delrec")
> if we dare add that tag ;)

It doesn't 'fix' anything, it is just stylistic.
Completely harmless in every sense.

	David

> 
> Reviewed-by: Eric Sandeen <sandeen@redhat.com>
> 
> > ---
> >  fs/xfs/libxfs/xfs_btree.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/fs/xfs/libxfs/xfs_btree.c b/fs/xfs/libxfs/xfs_btree.c
> > index 2d25bab68764..51dbff9b0908 100644
> > --- a/fs/xfs/libxfs/xfs_btree.c
> > +++ b/fs/xfs/libxfs/xfs_btree.c
> > @@ -4070,7 +4070,7 @@ xfs_btree_delrec(
> >  	 * surviving block, and log it.
> >  	 */
> >  	xfs_btree_set_numrecs(left, lrecs + rrecs);
> > -	xfs_btree_get_sibling(cur, right, &cptr, XFS_BB_RIGHTSIB),
> > +	xfs_btree_get_sibling(cur, right, &cptr, XFS_BB_RIGHTSIB);
> >  	xfs_btree_set_sibling(cur, left, &cptr, XFS_BB_RIGHTSIB);
> >  	xfs_btree_log_block(cur, lbp, XFS_BB_NUMRECS | XFS_BB_RIGHTSIB);
> >
> >

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)

  reply	other threads:[~2020-12-11 17:24 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-11  8:41 [PATCH -next] fs/xfs: convert comma to semicolon Zheng Yongjun
2020-12-11 15:48 ` Brian Foster
2020-12-11 15:51 ` Eric Sandeen
2020-12-11 16:17   ` David Laight [this message]
2020-12-11 16:55     ` Joe Perches
2021-01-20 19:42 ` Darrick J. Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5f4ee9cf48a445cea25ba01bc9ffdf13@AcuMS.aculab.com \
    --to=david.laight@aculab.com \
    --cc=darrick.wong@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    --cc=sandeen@sandeen.net \
    --cc=zhengyongjun3@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.