From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail26.static.mailgun.info ([104.130.122.26]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1imDy8-00025o-BK for ath10k@lists.infradead.org; Tue, 31 Dec 2019 09:37:42 +0000 MIME-Version: 1.0 Date: Tue, 31 Dec 2019 17:37:37 +0800 From: wgong@codeaurora.org Subject: Re: [PATCH v2 1/2] ath10k: add refcount for ath10k_core_restart In-Reply-To: References: <20191225120002.11163-1-wgong@codeaurora.org> <20191225120002.11163-2-wgong@codeaurora.org> Message-ID: <5f6eb95de0f877b86b90d0c32d458d43@codeaurora.org> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: Justin Capella Cc: linux-wireless@vger.kernel.org, ath10k On 2019-12-25 23:14, Justin Capella wrote: > This does not only effect SDIO. > > Why a semaphore / count? Could the conf_mutex be held earlier, or > perhaps change the state to ATH10K_STATE_RESTARTING first? > ath10k_reconfig_complete is also called in mac.c when channel is > changed so patch v2: https://patchwork.kernel.org/patch/11313853/ https://patchwork.kernel.org/patch/11313859/ _______________________________________________ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3F66C2D0C2 for ; Tue, 31 Dec 2019 09:37:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 77CE8206DA for ; Tue, 31 Dec 2019 09:37:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="j+ySj4xQ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726046AbfLaJho (ORCPT ); Tue, 31 Dec 2019 04:37:44 -0500 Received: from mail25.static.mailgun.info ([104.130.122.25]:16592 "EHLO mail25.static.mailgun.info" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725770AbfLaJho (ORCPT ); Tue, 31 Dec 2019 04:37:44 -0500 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1577785064; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=y5y18m8BZe1GRBDlNusUsV0+XWeFRukqPLy2F+ycHek=; b=j+ySj4xQRifMFCHJvNWdqbxfkDxEcP3pmg55etbE+r/wxEmhfTFri5Tj4tOZRrsHW0NTNwDp +0+oGSe5nAUypxM0zz2ExjmYBif9u0W69RUrO//e+bTGnzZvT9ApKVEm9LlJcmfaMeloBsW0 dcm7HxINLh6+/vAzdsaWwDP9sbU= X-Mailgun-Sending-Ip: 104.130.122.25 X-Mailgun-Sid: WyI3YTAwOSIsICJsaW51eC13aXJlbGVzc0B2Z2VyLmtlcm5lbC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by mxa.mailgun.org with ESMTP id 5e0b16e1.7f42fc4d8ed8-smtp-out-n03; Tue, 31 Dec 2019 09:37:37 -0000 (UTC) Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 8DC87C447A0; Tue, 31 Dec 2019 09:37:37 +0000 (UTC) Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: wgong) by smtp.codeaurora.org (Postfix) with ESMTPSA id 48411C43383; Tue, 31 Dec 2019 09:37:37 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Tue, 31 Dec 2019 17:37:37 +0800 From: wgong@codeaurora.org To: Justin Capella Cc: ath10k , linux-wireless@vger.kernel.org Subject: Re: [PATCH v2 1/2] ath10k: add refcount for ath10k_core_restart In-Reply-To: References: <20191225120002.11163-1-wgong@codeaurora.org> <20191225120002.11163-2-wgong@codeaurora.org> Message-ID: <5f6eb95de0f877b86b90d0c32d458d43@codeaurora.org> X-Sender: wgong@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On 2019-12-25 23:14, Justin Capella wrote: > This does not only effect SDIO. > > Why a semaphore / count? Could the conf_mutex be held earlier, or > perhaps change the state to ATH10K_STATE_RESTARTING first? > ath10k_reconfig_complete is also called in mac.c when channel is > changed so patch v2: https://patchwork.kernel.org/patch/11313853/ https://patchwork.kernel.org/patch/11313859/