From: bluez.test.bot@gmail.com
To: linux-bluetooth@vger.kernel.org, howardchung@google.com
Subject: RE: [v7,1/5] Bluetooth: Interleave with allowlist scan
Date: Mon, 09 Nov 2020 00:53:01 -0800 (PST) [thread overview]
Message-ID: <5fa9036d.1c69fb81.256bf.8415@mx.google.com> (raw)
In-Reply-To: <20201109155659.v7.1.Ib75f58e90c477f9b82c5598f00c59f0e95a1a352@changeid>
[-- Attachment #1: Type: text/plain, Size: 2374 bytes --]
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=380067
---Test result---
##############################
Test: CheckPatch - FAIL
Output:
mgmt: Add supports of variable length parameter in mgmt_config
CHECK: Macro argument '_param_name_' may be better as '(_param_name_)' to avoid precedence issues
#35: FILE: net/bluetooth/mgmt_config.c:20:
+#define TLV_SET_U16(_param_code_, _param_name_) \
+ { \
+ { cpu_to_le16(_param_code_), sizeof(__u16) }, \
+ cpu_to_le16(hdev->_param_name_) \
+ }
CHECK: Macro argument '_param_name_' may be better as '(_param_name_)' to avoid precedence issues
#41: FILE: net/bluetooth/mgmt_config.c:26:
+#define TLV_SET_U16_JIFFIES_TO_MSECS(_param_code_, _param_name_) \
+ { \
+ { cpu_to_le16(_param_code_), sizeof(__u16) }, \
+ cpu_to_le16(jiffies_to_msecs(hdev->_param_name_)) \
+ }
total: 0 errors, 0 warnings, 2 checks, 156 lines checked
NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.
"[PATCH] mgmt: Add supports of variable length parameter in" has style problems, please review.
NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
Bluetooth: Add toggle to switch off interleave scan
CHECK: Macro argument '_param_name_' may be better as '(_param_name_)' to avoid precedence issues
#70: FILE: net/bluetooth/mgmt_config.c:32:
+#define TLV_SET_U8(_param_code_, _param_name_) \
+ { \
+ { cpu_to_le16(_param_code_), sizeof(__u8) }, \
+ hdev->_param_name_ \
+ }
total: 0 errors, 0 warnings, 1 checks, 118 lines checked
NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.
"[PATCH] Bluetooth: Add toggle to switch off interleave scan" has style problems, please review.
NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
##############################
Test: CheckGitLint - PASS
##############################
Test: CheckBuildK - PASS
---
Regards,
Linux Bluetooth
next prev parent reply other threads:[~2020-11-09 8:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-09 7:57 [PATCH v7 1/5] Bluetooth: Interleave with allowlist scan Howard Chung
2020-11-09 7:57 ` [PATCH v7 2/5] Bluetooth: Handle system suspend resume case Howard Chung
2020-11-09 12:25 ` Marcel Holtmann
2020-11-09 7:57 ` [PATCH v7 3/5] Bluetooth: Handle active scan case Howard Chung
2020-11-09 7:57 ` [PATCH v7 4/5] mgmt: Add supports of variable length parameter in mgmt_config Howard Chung
2020-11-09 12:29 ` Marcel Holtmann
2020-11-09 7:57 ` [PATCH v7 5/5] Bluetooth: Add toggle to switch off interleave scan Howard Chung
2020-11-09 8:53 ` bluez.test.bot [this message]
2020-11-09 12:23 ` [PATCH v7 1/5] Bluetooth: Interleave with allowlist scan Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5fa9036d.1c69fb81.256bf.8415@mx.google.com \
--to=bluez.test.bot@gmail.com \
--cc=howardchung@google.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.