From: Nilay Shroff <nilay@linux.ibm.com>
To: Guixin Liu <kanie@linux.alibaba.com>,
Keith Busch <kbusch@kernel.org>, Jens Axboe <axboe@kernel.dk>,
Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
Daniel Wagner <dwagner@suse.de>, Hannes Reinecke <hare@suse.de>
Cc: linux-nvme@lists.infradead.org
Subject: Re: [PATCH 6/6] nvmet: use GFP_KERNEL for PR allocations
Date: Fri, 6 Nov 2026 19:05:09 +0530 [thread overview]
Message-ID: <5fb62ca0-ab59-4d9f-bb4e-802ec1511c7e@linux.ibm.com> (raw)
In-Reply-To: <20261106015842.3534898-7-kanie@linux.alibaba.com>
On 11/6/26 7:28 AM, Guixin Liu wrote:
> nvmet_pr_update_reg_attr() and nvmet_pr_alloc_and_insert_pc_ref()
> allocate with GFP_ATOMIC, but both run in sleepable context: the PR
> command handlers execute from the transport workqueues and take the
> pr_sem semaphore, and the pc_ref allocation is reached from the
> connect and configfs paths. The latter function even passes
> GFP_KERNEL to the percpu_ref_init() in the same scope, so the
> GFP_ATOMIC only raises the failure rate for no reason.
>
> Switch both allocations to GFP_KERNEL.
>
> Fixes: 5a47c2080a73 ("nvmet: support reservation feature")
> Cc:stable@vger.kernel.org
> Signed-off-by: Guixin Liu<kanie@linux.alibaba.com>
Looks good to me:
Reviewed-by: Nilay Shroff <nilay@linux.ibm.com>
prev parent reply other threads:[~2026-11-06 13:35 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-06 1:58 [PATCH 0/6] nvme: fabrics and target fixes Guixin Liu
2026-11-06 1:58 ` [PATCH 1/6] nvme: reject a reconnect_delay of 0 through sysfs Guixin Liu
2026-11-06 2:09 ` sashiko-bot
2026-11-06 7:39 ` Hannes Reinecke
2026-11-06 10:33 ` Christoph Hellwig
2026-11-06 13:32 ` Nilay Shroff
2026-11-06 1:58 ` [PATCH 2/6] nvme-fc: fix iterator over rport->ctrl_list in nvme_fc_match_disconn_ls() Guixin Liu
2026-11-06 2:06 ` sashiko-bot
2026-11-06 7:38 ` Hannes Reinecke
2026-11-06 10:49 ` Guixin Liu
2026-11-06 1:58 ` [PATCH 3/6] nvme-auth: fix data race on ctrl->transaction Guixin Liu
2026-11-06 7:27 ` Hannes Reinecke
2026-11-06 9:28 ` Guixin Liu
2026-11-06 1:58 ` [PATCH 4/6] nvmet: take subsys->lock in nvmet_subsys_attr_tbkas_store() Guixin Liu
2026-11-06 7:27 ` Hannes Reinecke
2026-11-06 10:34 ` Christoph Hellwig
2026-11-06 13:32 ` Nilay Shroff
2026-11-06 1:58 ` [PATCH 5/6] nvmet: fix controller reference leak in nvmet_install_queue() error paths Guixin Liu
2026-11-06 7:31 ` Hannes Reinecke
2026-11-06 9:29 ` Guixin Liu
2026-11-06 1:58 ` [PATCH 6/6] nvmet: use GFP_KERNEL for PR allocations Guixin Liu
2026-11-06 7:31 ` Hannes Reinecke
2026-11-06 10:35 ` Christoph Hellwig
2026-11-06 13:35 ` Nilay Shroff [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5fb62ca0-ab59-4d9f-bb4e-802ec1511c7e@linux.ibm.com \
--to=nilay@linux.ibm.com \
--cc=axboe@kernel.dk \
--cc=dwagner@suse.de \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=kanie@linux.alibaba.com \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.