From: Adrian Hunter <adrian.hunter@intel.com>
To: Sam Agazaryan <samagazaryan@google.com>, Frank Li <Frank.li@oss.nxp.com>
Cc: <linux-i3c@lists.infradead.org>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Frank Li <Frank.Li@nxp.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
Arnd Bergmann <arnd@arndb.de>,
Vitor Soares <vitor.soares@toradex.com>,
Oleksandr Shulzhenko <oleksandr.shulzhenko.viktorovych@intel.com>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v4 3/3] i3c: add i3cdev module to expose i3c dev in /dev
Date: Fri, 11 Sep 2026 22:03:17 +0300 [thread overview]
Message-ID: <5fb77c2c-40b8-4dfe-95d3-e0c73b8559bc@intel.com> (raw)
In-Reply-To: <DLC6ERLST1B6.6K3HLH38DQLK@google.com>
On 11/09/2026 06:44, Sam Agazaryan wrote:
> On Wed Sep 9, 2026 at 9:51 PM UTC, Frank Li wrote:
>> On Sun, Sep 06, 2026 at 08:27:47PM +0000, Sam Agazaryan wrote:
>>> From: Vitor Soares <vitor.soares@toradex.com>
>>> + for (i = 0; i < nxfers; i++) {
>>> + if (xfers[i].rnw) {
>>> + if (copy_to_user(u64_to_user_ptr(xfers[i].data),
>>> + data_ptrs[i], xfers[i].len))
>>
>> Use actual_len,
>
> Updated in v5.
actual_len is a problem. Only 2 controller drivers support it.
No I3C device drivers support it. mctp-i3c reads len not actual_len.
regmap-i3c ignores len and actual_len. And its definition comment
is not exactly correct since it is only valid for reads.
Despite that, the additional issue here, is what to do about a short
read. Seems like it should be in the uapi, but actual_len needs to
be fixed first.
--
linux-i3c mailing list
linux-i3c@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-i3c
next prev parent reply other threads:[~2026-09-11 19:03 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-06 20:27 [PATCH v4 0/3] i3c: Introduce i3c device userspace interface Sam Agazaryan
2026-09-06 20:27 ` [PATCH v4 1/3] i3c: master: export i3c_masterdev_type Sam Agazaryan
2026-09-06 20:27 ` [PATCH v4 2/3] i3c: master: add i3c_for_each_dev helper Sam Agazaryan
2026-09-06 20:40 ` sashiko-bot
2026-09-06 20:27 ` [PATCH v4 3/3] i3c: add i3cdev module to expose i3c dev in /dev Sam Agazaryan
2026-09-06 20:41 ` sashiko-bot
2026-09-07 14:40 ` Greg Kroah-Hartman
2026-09-09 6:13 ` Sam Agazaryan
2026-09-09 21:51 ` Frank Li
2026-09-11 3:44 ` Sam Agazaryan
2026-09-11 15:10 ` Frank Li
2026-09-11 23:57 ` Sam Agazaryan
2026-09-11 19:03 ` Adrian Hunter [this message]
2026-09-11 22:05 ` Meagan Lloyd
2026-09-12 0:12 ` Sam Agazaryan
2026-09-08 11:48 ` [PATCH v4 0/3] i3c: Introduce i3c device userspace interface Wolfram Sang
2026-09-12 11:12 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5fb77c2c-40b8-4dfe-95d3-e0c73b8559bc@intel.com \
--to=adrian.hunter@intel.com \
--cc=Frank.Li@nxp.com \
--cc=Frank.li@oss.nxp.com \
--cc=alexandre.belloni@bootlin.com \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-i3c@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oleksandr.shulzhenko.viktorovych@intel.com \
--cc=samagazaryan@google.com \
--cc=vitor.soares@toradex.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.