Re: [PATCH v2 2/2] hwmon: ltc4282: add support for the LTC4282 chip

["Nuno Sá" <noname.nuno@gmail.com>]

On Wed, 2023-11-29 at 15:10 +0100, Linus Walleij wrote:
> On Wed, Nov 29, 2023 at 9:45 AM Krzysztof Kozlowski <krzk@kernel.org> wrote:
> > On 29/11/2023 09:35, Nuno Sá wrote:
> 
> > > world. If we are now going to ask to run smatch, cocci, sparse and so on, we
> > > will
> > > scare even more developers from the community... I mean, the bots are also in
> > > place
> > 
> > This is not related to Linux at all.
> 
> Smatch, main author Dan Carpenter
> Coccinelle, main author Julia Lawall
> Sparse, main author Linus Torvalds
> 
> To be fair I think these tools has quite a lot to do with Linux, being developed
> for the kernel as the primary use case, by Linux kernel contributors.
> 
> > When you develop any C or C++ code,
> > you run these tools. Upstream or downstream, does not matter. Why would
> > you not use automated, free and easy tools to detect errors in your
> > code? It's just a matter of professional approach to your code.
> 
> This I agree with. We just happen to have some especially
> talented C developers who write some novel tooling.
> 
> (I think developers should be able to rely on robots to run them though,
> we all seem to agree on that.)
> 
> Yours,
> Linus Walleij

Hi Linus,

Since I have your attention, please give a look at the gpio stuff when you have the
time for it. On the v1 cover [1], I have there my concerns. I'm really not sure if
I'm providing the right interfaces for the device capabilities.

[1]: https://lore.kernel.org/linux-hwmon/20231110151905.1659873-1-nuno.sa@analog.com/

Thanks!
- Nuno Sá