All of lore.kernel.org
 help / color / mirror / Atom feed
From: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
To: Uma Shankar <uma.shankar@intel.com>,
	intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Cc: ville.syrjala@intel.com, maarten.lankhorst@intel.com
Subject: Re: [RFC 3/3] drm/i915: Set colorspace by enabling Infoframe
Date: Wed, 26 Sep 2018 11:10:45 +0200	[thread overview]
Message-ID: <5fc29ae5-ab00-ea7d-5c1e-a550313f55eb@linux.intel.com> (raw)
In-Reply-To: <1532447152-23736-4-git-send-email-uma.shankar@intel.com>

Op 24-07-18 om 17:45 schreef Uma Shankar:
> Based on colorspace property value create an infoframe
> with appropriate colorspace. This can be used to send an
> infoframe packet with proper colorspace value set which
> will help to enable wider color gamut like BT2020 on sink.
>
> Signed-off-by: Uma Shankar <uma.shankar@intel.com>
> ---
>  drivers/gpu/drm/i915/intel_hdmi.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/intel_hdmi.c b/drivers/gpu/drm/i915/intel_hdmi.c
> index 7fb96e2..319da1b 100644
> --- a/drivers/gpu/drm/i915/intel_hdmi.c
> +++ b/drivers/gpu/drm/i915/intel_hdmi.c
> @@ -491,6 +491,8 @@ static void intel_hdmi_set_avi_infoframe(struct drm_encoder *encoder,
>  	else
>  		frame.avi.colorspace = HDMI_COLORSPACE_RGB;
>  
> +	frame.avi.extended_colorimetry = conn_state->colorspace;
> +
>  	drm_hdmi_avi_infoframe_quant_range(&frame.avi, adjusted_mode,
>  					   crtc_state->limited_color_range ?
>  					   HDMI_QUANTIZATION_RANGE_LIMITED :

I would merge this with the previous patch, to be honest.

If it was non-trivial I would suggest splitting it up. :)

~Maarten

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2018-09-26  9:10 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-24 15:45 [RFC 0/3] Add Colorspace connector property interface Uma Shankar
2018-07-24 15:45 ` [RFC 1/3] drm: Add colorspace property Uma Shankar
2018-07-31 19:54   ` Adam Jackson
2018-08-01 14:01     ` Shankar, Uma
2018-09-26  9:08       ` Maarten Lankhorst
2018-09-26  9:41         ` Ville Syrjälä
2018-09-27  4:29           ` Shankar, Uma
2018-09-27 13:24             ` Ville Syrjälä
2018-07-24 15:45 ` [RFC 2/3] drm/i915: Attach colorspace property and enable modeset Uma Shankar
2018-07-24 15:45 ` [RFC 3/3] drm/i915: Set colorspace by enabling Infoframe Uma Shankar
2018-09-26  9:10   ` Maarten Lankhorst [this message]
2018-09-27  4:31     ` [Intel-gfx] " Shankar, Uma
2018-07-24 16:09 ` ✗ Fi.CI.CHECKPATCH: warning for Add Colorspace connector property interface Patchwork
2018-07-24 16:11 ` ✗ Fi.CI.SPARSE: " Patchwork
2018-07-24 16:30 ` ✓ Fi.CI.BAT: success " Patchwork
2018-07-24 20:29 ` ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5fc29ae5-ab00-ea7d-5c1e-a550313f55eb@linux.intel.com \
    --to=maarten.lankhorst@linux.intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=maarten.lankhorst@intel.com \
    --cc=uma.shankar@intel.com \
    --cc=ville.syrjala@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.