All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Jeffery <andrew@codeconstruct.com.au>
To: Rob Herring <robh@kernel.org>, Eddie James <eajames@linux.ibm.com>
Cc: krzk+dt@kernel.org, devicetree@vger.kernel.org,
	 linux-aspeed@lists.ozlabs.org, conor+dt@kernel.org
Subject: Re: [PATCH v2 0/3] ARM: dts: aspeed: Add Balcones system
Date: Tue, 18 Mar 2025 11:31:29 +1030	[thread overview]
Message-ID: <5fd732f2cffefd65bfcba983ecf5e11fedb5bc2d.camel@codeconstruct.com.au> (raw)
In-Reply-To: <CAL_Jsq+QF6m1YD_MKi0mxJWtn0n+f+iL2x-jYv3NWytv0X4Jjg@mail.gmail.com>

On Fri, 2025-02-28 at 11:23 -0600, Rob Herring wrote:
> On Fri, Feb 28, 2025 at 10:46 AM Eddie James <eajames@linux.ibm.com>
> wrote:
> > 
> > 
> > On 2/24/25 22:34, Andrew Jeffery wrote:
> > > On Fri, 2025-02-21 at 12:11 -0600, Rob Herring (Arm) wrote:
> > > > On Thu, 20 Feb 2025 14:59:45 -0600, Eddie James wrote:
> > > > > The Balcones system is similar to Bonnell but with a POWER11
> > > > > processor.
> > > > > 
> > > > > Changes since v1:
> > > > >   - Add all the ucd9000 driver supported compatible strings
> > > > >   - Fix node ordering in Balcones device tree
> > > > >   - Improve commit message to explain addition of ibm-
> > > > > power11-dual.dtsi
> > > > > 
> > > > > Eddie James (3):
> > > > >    dt-bindings: arm: aspeed: add IBM Balcones board
> > > > >    dt-bindings: hwmon: ucd90320: Add additional compatible
> > > > > strings
> > > > >    ARM: dts: aspeed: Add Balcones system
> > > > > 
> > > > >   .../bindings/arm/aspeed/aspeed.yaml           |   1 +
> > > > >   .../bindings/hwmon/pmbus/ti,ucd90320.yaml     |   6 +
> > > > >   arch/arm/boot/dts/aspeed/Makefile             |   1 +
> > > > >   .../dts/aspeed/aspeed-bmc-ibm-balcones.dts    | 594
> > > > > +++++++++++++
> > > > >   .../arm/boot/dts/aspeed/ibm-power11-dual.dtsi | 779
> > > > > ++++++++++++++++++
> > > > >   .../arm/boot/dts/aspeed/ibm-power11-quad.dtsi | 769 +------
> > > > > ----------
> > > > >   6 files changed, 1383 insertions(+), 767 deletions(-)
> > > > >   create mode 100644 arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-
> > > > > balcones.dts
> > > > >   create mode 100644 arch/arm/boot/dts/aspeed/ibm-power11-
> > > > > dual.dtsi
> > > > > 
> > > > > --
> > > > > 2.43.5
> > > > > 
> > > > > 
> > > > > 
> > > > 
> > > > My bot found new DTB warnings on the .dts files added or
> > > > changed in this
> > > > series.
> > > > 
> > > ...
> > > 
> > > > arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-balcones.dtb:
> > > > gpio@1e780000: 'usb-power-hog' does not match any of the
> > > > regexes: 'pinctrl-[0-9]+'
> > > >          from schema $id:
> > > > http://devicetree.org/schemas/gpio/aspeed,ast2400-gpio.yaml#
> > > Ah, can you address this one?
> > > 
> > > > arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-balcones.dtb:
> > > > /ahb/apb/bus@1e78a000/i2c@400/pwm@53: failed to match any
> > > > schema with compatible: ['maxim,max31785a']
> > > > arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-balcones.dtb:
> > > > pressure-sensor@76: '#io-channel-cells' does not match any of
> > > > the regexes: 'pinctrl-[0-9]+'
> > > >          from schema $id:
> > > > http://devicetree.org/schemas/trivial-devices.yaml#
> > > And these also?
> > > 
> > > The rest looked like the usual noise.
> > 
> > 
> > Well, all of these errors are also present in Blueridge. I would
> > need to
> > write a new binding for dps310, move max31785 to yaml format, and
> > I'm
> > not sure how to fix the gpio hog one. I don't see that error when I
> > run
> > CHECK_DTBS myself... any suggestions?
> 
> I think the hog one got fixed recently. The tests run on top of
> whatever b4 picks for the base or linux-next if it can't figure out
> the base. So that might be the difference.

Eddie: Yeah, disregard the hog one. An alternative to
writing/converting the bindings is dropping the relevant nodes for now,
and adding them back once the bindings have been dealt with. Up to you.

Andrew


      reply	other threads:[~2025-03-18  1:01 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-20 20:59 [PATCH v2 0/3] ARM: dts: aspeed: Add Balcones system Eddie James
2025-02-20 20:59 ` [PATCH v2 1/3] dt-bindings: arm: aspeed: add IBM Balcones board Eddie James
2025-02-20 20:59 ` [PATCH v2 2/3] dt-bindings: hwmon: ucd90320: Add additional compatible strings Eddie James
2025-02-21  8:53   ` Krzysztof Kozlowski
2025-02-20 20:59 ` [PATCH v2 3/3] ARM: dts: aspeed: Add Balcones system Eddie James
2025-02-21 18:11 ` [PATCH v2 0/3] " Rob Herring (Arm)
2025-02-25  4:34   ` Andrew Jeffery
2025-02-28 16:46     ` Eddie James
2025-02-28 17:23       ` Rob Herring
2025-03-18  1:01         ` Andrew Jeffery [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5fd732f2cffefd65bfcba983ecf5e11fedb5bc2d.camel@codeconstruct.com.au \
    --to=andrew@codeconstruct.com.au \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=eajames@linux.ibm.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-aspeed@lists.ozlabs.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.