All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@kernel.dk>
To: Elena Reshetova <elena.reshetova@intel.com>,
	linux-kernel@vger.kernel.org
Cc: linux-block@vger.kernel.org, linux-scsi@vger.kernel.org,
	linux-btrfs@vger.kernel.org, peterz@infradead.org,
	gregkh@linuxfoundation.org, fujita.tomonori@lab.ntt.co.jp,
	mingo@redhat.com, clm@fb.com, jbacik@fb.com, dsterba@suse.com
Subject: Re: [PATCH 0/5] block subsystem refcounter conversions
Date: Mon, 20 Feb 2017 08:15:21 -0700	[thread overview]
Message-ID: <5fd906c2-61ba-319c-1bc2-cb48b2b378b4@kernel.dk> (raw)
In-Reply-To: <1487589368-17666-1-git-send-email-elena.reshetova@intel.com>

On 02/20/2017 04:16 AM, Elena Reshetova wrote:
> Now when new refcount_t type and API are finally merged
> (see include/linux/refcount.h), the following
> patches convert various refcounters in the block susystem from atomic_t
> to refcount_t. By doing this we prevent intentional or accidental
> underflows or overflows that can led to use-after-free vulnerabilities.
> 
> The below patches are fully independent and can be cherry-picked separately.
> Since we convert all kernel subsystems in the same fashion, resulting
> in about 300 patches, we have to group them for sending at least in some
> fashion to be manageable. Please excuse the long cc list.
> 
> Elena Reshetova (5):
>   block: convert bio.__bi_cnt from atomic_t to refcount_t
>   block: convert blk_queue_tag.refcnt from atomic_t to refcount_t
>   block: convert blkcg_gq.refcnt from atomic_t to refcount_t
>   block: convert io_context.active_ref from atomic_t to refcount_t
>   block: convert bsg_device.ref_count from atomic_t to refcount_t

I went to look at the implementation, and the size of a refcount_t.
But the code is not there?! You say it's finally merged, where is
it merged? Don't send code like this without the necessary
infrastructure being in mainline.

-- 
Jens Axboe

  parent reply	other threads:[~2017-02-20 15:15 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-20 11:16 [PATCH 0/5] block subsystem refcounter conversions Elena Reshetova
2017-02-20 11:16 ` [PATCH 1/5] block: convert bio.__bi_cnt from atomic_t to refcount_t Elena Reshetova
2017-02-20 11:16 ` [PATCH 2/5] block: convert blk_queue_tag.refcnt " Elena Reshetova
2017-02-20 11:16 ` [PATCH 3/5] block: convert blkcg_gq.refcnt " Elena Reshetova
2017-02-20 11:16 ` [PATCH 4/5] block: convert io_context.active_ref " Elena Reshetova
2017-02-20 11:16 ` [PATCH 5/5] block: convert bsg_device.ref_count " Elena Reshetova
2017-02-20 15:15 ` Jens Axboe [this message]
2017-02-20 15:41   ` [PATCH 0/5] block subsystem refcounter conversions James Bottomley
2017-02-20 15:44     ` Jens Axboe
2017-02-20 16:56     ` Peter Zijlstra
2017-02-20 17:24       ` James Bottomley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5fd906c2-61ba-319c-1bc2-cb48b2b378b4@kernel.dk \
    --to=axboe@kernel.dk \
    --cc=clm@fb.com \
    --cc=dsterba@suse.com \
    --cc=elena.reshetova@intel.com \
    --cc=fujita.tomonori@lab.ntt.co.jp \
    --cc=gregkh@linuxfoundation.org \
    --cc=jbacik@fb.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.