All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Bernstein, Amit" <amitbern@amazon.com>
To: Richard Cochran <richardcochran@gmail.com>
Cc: "tglx@linutronix.de" <tglx@linutronix.de>,
	"kuba@kernel.org" <kuba@kernel.org>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"Dagan, Noam" <ndagan@amazon.com>,
	"Arinzon, David" <darinzon@amazon.com>,
	"Agroskin, Shay" <shayagr@amazon.com>
Subject: RE: Add PHC support with error bound value for ENA driver
Date: Thu, 1 Feb 2024 18:56:04 +0000	[thread overview]
Message-ID: <5ff61605e6424624b252cbbc2f9cbe4f@amazon.com> (raw)
In-Reply-To: <ZbuviFaciTADMkMk@hoboy.vegasvil.org>

> On Thu, Feb 01, 2024 at 07:24:51AM +0000, Bernstein, Amit wrote:
> 
> > In one of the upcoming releases, we're planning to add PHC support to
> > the ENA driver (/drivers/net/ethernet/amazon/ena/) To provide the best
> > experience for service customers, the ENA driver will expose an
> > error_bound parameter (expressed in nanoseconds), which will represent
> > the maximal clock error on each given PHC timestamp.
> 
> > As our device sends each PHC timestamp with an error_bound value
> > together, gettimex64 is the reasonable option for us and our
> > recommended solution.  We would like to ask for your recommendation.
> 
> Sounds like gettimex64 won't help you.
> 
> You will need to extend the socket time stamping API.  That is how time
> stamps are delivered to user space.
> 
> HTH,
> Richard

Richard, thank you for your response.
However, I forgot to mention that the ENA driver currently doesn't support any socket timestamping.
It only supports the PTP hardware clock infrastructure, which is exported using the clock driver.
User space programs can control the clock driver via the PTP_SYS_OFFSET ioctl.
Therefore, we can only use the basic clock operations of ptp_clock_info, such as gettime/gettime64/gettimex64.

Thanks,
Amit

      reply	other threads:[~2024-02-01 18:56 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-01  7:24 Add PHC support with error bound value for ENA driver Bernstein, Amit
2024-02-01 14:49 ` Richard Cochran
2024-02-01 18:56   ` Bernstein, Amit [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5ff61605e6424624b252cbbc2f9cbe4f@amazon.com \
    --to=amitbern@amazon.com \
    --cc=darinzon@amazon.com \
    --cc=kuba@kernel.org \
    --cc=ndagan@amazon.com \
    --cc=netdev@vger.kernel.org \
    --cc=richardcochran@gmail.com \
    --cc=shayagr@amazon.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.