All of lore.kernel.org
 help / color / mirror / Atom feed
From: Matthieu Baerts <matttbe@kernel.org>
To: Eric Dumazet <edumazet@google.com>
Cc: mptcp@lists.linux.dev
Subject: Re: [PATCH v2 net] mptcp: fix race in mptcp_pm_nl_flush_addrs_doit()
Date: Fri, 23 Jan 2026 14:33:52 +0100	[thread overview]
Message-ID: <5ffec702-b8e5-4864-95ae-d4c94357dc04@kernel.org> (raw)
In-Reply-To: <CANn89iJ+c=_DdT5CPj4Zxfhx__gKOeNjBhQuOaBqOgkR7ugkdQ@mail.gmail.com>

Hi Eric,

Thank you for having looked at this and sharing this fix.

23 Jan 2026 12:36:37 Eric Dumazet <edumazet@google.com>:

> On Fri, Jan 23, 2026 at 12:03 PM MPTCP CI
> <wpasupplicant.patchew@gmail.com> wrote:

>> Our CI did some validations and here is its report:
>>
>> - KVM Validation: normal (except selftest_mptcp_join): Unstable: 1 failed test(s): selftest_simult_flows 🔴
>
> This seem a flake ?

Yes it is, and due to a commit ("mptcp: better mptcp-level RTT
estimator") which is only in our tree (used by our CI), see:

https://github.com/multipath-tcp/mptcp_net-next/issues/607

Sorry, I didn't have the opportunity to find a solution for that.

Regarding your patch, it looks like it is corrupted. Both NIPA and
Patchew are complaining about it:

  Applying: mptcp: fix race in mptcp_pm_nl_flush_addrs_doit()
  error: corrupt patch at line 15
  error: could not build fake ancestor

"git am" complains, but it is OK to manually apply it with "patch". Any
idea why? If you are not available, do you want me to resend it later
on?

Cheers,
Matt

  reply	other threads:[~2026-01-23 13:33 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-23  3:03 [PATCH v2 net] mptcp: fix race in mptcp_pm_nl_flush_addrs_doit() Eric Dumazet
2026-01-23 11:03 ` MPTCP CI
2026-01-23 11:36   ` Eric Dumazet
2026-01-23 13:33     ` Matthieu Baerts [this message]
2026-01-23 21:43 ` Mat Martineau
2026-01-24 11:17   ` Matthieu Baerts

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5ffec702-b8e5-4864-95ae-d4c94357dc04@kernel.org \
    --to=matttbe@kernel.org \
    --cc=edumazet@google.com \
    --cc=mptcp@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.