From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7C7BEC4360F for ; Thu, 21 Mar 2019 15:16:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4888021874 for ; Thu, 21 Mar 2019 15:16:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728307AbfCUPQf (ORCPT ); Thu, 21 Mar 2019 11:16:35 -0400 Received: from mx1.redhat.com ([209.132.183.28]:45240 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728032AbfCUPQe (ORCPT ); Thu, 21 Mar 2019 11:16:34 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 4B86A307D90F; Thu, 21 Mar 2019 15:16:34 +0000 (UTC) Received: from warthog.procyon.org.uk (ovpn-121-98.rdu2.redhat.com [10.10.121.98]) by smtp.corp.redhat.com (Postfix) with ESMTP id ED03C1001DE4; Thu, 21 Mar 2019 15:16:31 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <3463221.D14WHduXq3@blindfold> References: <3463221.D14WHduXq3@blindfold> <155316902426.29884.2476392753144421312.stgit@warthog.procyon.org.uk> To: Richard Weinberger Cc: dhowells@redhat.com, viro@zeniv.linux.org.uk, linux-block@vger.kernel.org, squashfs-devel@lists.sourceforge.net, Marek Vasut , Brian Norris , Nicolas Pitre , Boris Brezillon , linux-mtd@lists.infradead.org, David Woodhouse , Phillip Lougher , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH 0/6] Convert mount_single-using filesystems to fs_context MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <6006.1553181386.1@warthog.procyon.org.uk> Date: Thu, 21 Mar 2019 15:16:26 +0000 Message-ID: <6007.1553181386@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.48]); Thu, 21 Mar 2019 15:16:34 +0000 (UTC) Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org Bah. The problem is that vfs_get_super() doesn't set fc->root before calling reconfigure_super(). David From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04F72C43381 for ; Thu, 21 Mar 2019 15:16:39 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CE4E121874 for ; Thu, 21 Mar 2019 15:16:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="LN1Ak6sb" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CE4E121874 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Message-ID:Date:Content-ID:MIME-Version :Subject:To:References:In-Reply-To:From:Reply-To:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ETDGNxIkcr+AArQ/9uY8zJlHKWR/+HZII00P1vVquRQ=; b=LN1Ak6sbfXiupu U/C9Zy+culibHPVa3Rq+Il5lJPzHBO81hFayJcLMI7Rg/uKGrs66rvZKhbnGmg0wZw8FCv4YTB6v0 rKPcPZt0n19CJYvqRDU9j3D2zn6pBEcfFFVbJGTpKeQ7y7JJ0QVnX8dQL7SS7XL8skwcLPm6L+n3A WGVKMvt1P4K8WYHShmq/63SDDzu50OkL054GsbSfeJA3m0kp46fFO1ndZMCrfImdkC0cJBn52Tlh0 ugbfZXHU/LBpc8zzsRToP6r/J+sbSRaliGsKbTNxea8wF+E/zuAKO1Gy4r10+1vpTajplYUnm5Zmj fvBQH+6v3VdwoArfH+yw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h6zQq-0003Ri-TG; Thu, 21 Mar 2019 15:16:36 +0000 Received: from mx1.redhat.com ([209.132.183.28]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h6zQo-0003RF-RE for linux-mtd@lists.infradead.org; Thu, 21 Mar 2019 15:16:36 +0000 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 4B86A307D90F; Thu, 21 Mar 2019 15:16:34 +0000 (UTC) Received: from warthog.procyon.org.uk (ovpn-121-98.rdu2.redhat.com [10.10.121.98]) by smtp.corp.redhat.com (Postfix) with ESMTP id ED03C1001DE4; Thu, 21 Mar 2019 15:16:31 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <3463221.D14WHduXq3@blindfold> References: <3463221.D14WHduXq3@blindfold> <155316902426.29884.2476392753144421312.stgit@warthog.procyon.org.uk> To: Richard Weinberger Subject: Re: [RFC PATCH 0/6] Convert mount_single-using filesystems to fs_context MIME-Version: 1.0 Content-ID: <6006.1553181386.1@warthog.procyon.org.uk> Date: Thu, 21 Mar 2019 15:16:26 +0000 Message-ID: <6007.1553181386@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.48]); Thu, 21 Mar 2019 15:16:34 +0000 (UTC) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190321_081634_901947_97D29F55 X-CRM114-Status: GOOD ( 10.72 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-block@vger.kernel.org, squashfs-devel@lists.sourceforge.net, Nicolas Pitre , linux-kernel@vger.kernel.org, dhowells@redhat.com, Marek Vasut , linux-mtd@lists.infradead.org, viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org, Phillip Lougher , Brian Norris , David Woodhouse , Boris Brezillon Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org Bah. The problem is that vfs_get_super() doesn't set fc->root before calling reconfigure_super(). David ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/