All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christian Schoenebeck <qemu_oss@crudebyte.com>
To: Igor Mammedov <imammedo@redhat.com>
Cc: qemu-devel@nongnu.org, Greg Kurz <groug@kaod.org>,
	Jia Jia <physicalmtea@gmail.com>
Subject: Re: [PATCH 2/3] hw/9pfs/virtio: disable hotpluggable property of virtio-9p device
Date: Fri, 10 Jul 2026 10:06:29 +0200	[thread overview]
Message-ID: <6008134.DvuYhMxLoT@weasel> (raw)
In-Reply-To: <20260710093737.4948ded4@imammedo>

On Friday, 10 July 2026 09:37:37 CEST Igor Mammedov wrote:
> On Thu, 9 Jul 2026 15:50:36 +0200
> 
> Christian Schoenebeck <qemu_oss@crudebyte.com> wrote:
> > Harden security by disabling hotpluggable property, to prevent
> > issues like fixed in the previous commit.
> > 
> > Virtio-9p is a pass-through file-sharing device that provides a
> > guest mount of a host filesystem tree. Unlike block or network
> > devices, guest-triggered hotplug of the 9p device has no practical
> > use case: the guest cannot recover from the device removal, and there
> > is no protocol-level device-loss scenario as with block or ethernet
> > devices.
> 
> hmh, I'm no maintainer of 9pfs, but to me it looks like any other
> storage device.
> One should be able to unmount/stop using it and unplug
> (it doesn't really matter if unplug is triggered by guest or host side).

Guest could still unmount and stop using the 9pfs device. But why should guest 
be able to unrealize the 9pfs device at any time? What should be the purpose 
for this particular device?

/Christian




  reply	other threads:[~2026-07-10  8:06 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <cover.1783604079.git.qemu_oss@crudebyte.com>
2026-07-09 13:50 ` [PATCH 3/3] hw/9pfs/xen: drain in-flight PDUs before xen-9p disconnect Christian Schoenebeck
2026-07-09 13:50 ` [PATCH 2/3] hw/9pfs/virtio: disable hotpluggable property of virtio-9p device Christian Schoenebeck
2026-07-10  7:37   ` Igor Mammedov
2026-07-10  8:06     ` Christian Schoenebeck [this message]
2026-07-10 10:23       ` Igor Mammedov
2026-07-10 10:49         ` Christian Schoenebeck
2026-07-10 12:51           ` Igor Mammedov
2026-07-10 14:31             ` Christian Schoenebeck
2026-07-10 14:40               ` Daniel P. Berrangé
2026-07-13  7:49                 ` Igor Mammedov
2026-07-09 13:50 ` [PATCH 1/3] hw/9pfs/virtio: drain in-flight PDUs before virtio-9p unrealize Christian Schoenebeck
2026-07-09 14:20   ` Christian Schoenebeck
2026-07-10  1:39     ` m'te'a physical

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6008134.DvuYhMxLoT@weasel \
    --to=qemu_oss@crudebyte.com \
    --cc=groug@kaod.org \
    --cc=imammedo@redhat.com \
    --cc=physicalmtea@gmail.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.