All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vladimir Kondratiev <qca_vkondrat@qca.qualcomm.com>
To: Johannes Berg <johannes@sipsolutions.net>,
	"Luis R . Rodriguez" <rodrigue@qca.qualcomm.com>
Cc: <linux-wireless@vger.kernel.org>
Subject: [RFC] Expand byte counters in struct station_info
Date: Thu, 31 Jan 2013 11:46:44 +0200	[thread overview]
Message-ID: <6017229.5ECEUbBVAL@lx-vladimir> (raw)

Hi,

Now wifi drivers reports per-station info using struct station_info;
and currently for the data counters it has:
	u32 rx_bytes;
	u32 tx_bytes;

while for device-wide statistics one can use ndo_get_stats64() to fill
64-bit counters in the struct rtnl_link_stats64, per-station statistics
are 32-bit.

This becomes problematic with gigabit speeds now observed for .11ac and .11ad -
counters overflown every few seconds.

I'd like to extend rx and tx byte counters to 64-bit.

What is better - expand existing fields in struct station_info as:
	u64 rx_bytes;
	u64 tx_bytes;
or add ne ones like:
	u64 rx_bytes64;
	u64 tx_bytes64;


Then, I'll add
	NL80211_STA_INFO_RX_BYTES64,
	NL80211_STA_INFO_TX_BYTES64,
to the enum nl80211_sta_info

Before doing patch, I'd like to hear comments.
Any consideration why is this not to be done or done differently?

Thanks, Vladimir

             reply	other threads:[~2013-01-31  9:46 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-31  9:46 Vladimir Kondratiev [this message]
2013-01-31 10:42 ` [RFC] Expand byte counters in struct station_info Johannes Berg
2013-01-31 17:16   ` Ben Greear
2013-02-01 14:10   ` Vladimir Kondratiev
2013-02-04 11:13   ` [PATCH 0/2] wireless: expand per-station byte counters to 64bit Vladimir Kondratiev
2013-02-04 11:18     ` Johannes Berg
2013-02-04 11:54       ` Vladimir Kondratiev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6017229.5ECEUbBVAL@lx-vladimir \
    --to=qca_vkondrat@qca.qualcomm.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=rodrigue@qca.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.