From: Yang Xu <xuyang2018.jy@cn.fujitsu.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v2 1/5] tst_mallinfo.c: Add a common print helper for mallinfo
Date: Fri, 5 Feb 2021 15:44:45 +0800 [thread overview]
Message-ID: <601CF76D.8020705@cn.fujitsu.com> (raw)
In-Reply-To: <CAEemH2f_mvjt4couA++RcOf9bAMO8fnqapkgG59Qvs9Ud-2SHw@mail.gmail.com>
Hi Li
> Hi Xu,
>
> Thanks for your work.
>
> --- /dev/null
> +++ b/include/tst_mallinfo.h
>
>
> Do we really need to export this function into the LTP library?
> (I assumed no other tests will using this lib function anymore)
Maybe we can add tst_print_mallinfo2 in the future and mallinfo2() case
can use this header.
>
> So I prefer to create a common header file as:
> ../syscalls/mallinfo/mallinfo_common.h,
> and just use it locally.
>
> If you're hoping mallopt01.c also benefits from it, only need to
> build something like mallinfo_commo.o via Makefile and include
> it in mallopt01.c by "../mallinfo/mallinfo_common.h".
Just want to avoid random makefile. I am not sure which way is better.
Let's listen advise from other maintainers.
>
> --
> Regards,
> Li Wang
next prev parent reply other threads:[~2021-02-05 7:44 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-26 9:55 [LTP] [PATCH v1 1/3] syscalls/mallinfo01: Add a basic test for mallinfo Yang Xu
2021-01-26 9:55 ` [LTP] [PATCH v1 2/3] syscalls/mallinfo02: Add a basic test to check use mmap or sbrk Yang Xu
2021-01-28 15:37 ` Cyril Hrubis
2021-02-03 9:47 ` Yang Xu
2021-02-03 10:46 ` Yang Xu
2021-02-04 6:08 ` Li Wang
2021-02-04 9:53 ` Yang Xu
2021-01-26 9:55 ` [LTP] [PATCH v1 3/3] syscalls/mallinfo03: Add an overflow test when setting 2G size Yang Xu
2021-01-28 15:42 ` Cyril Hrubis
2021-02-03 9:49 ` Yang Xu
2021-02-04 8:54 ` Li Wang
2021-02-04 10:01 ` Yang Xu
2021-02-04 13:56 ` Li Wang
2021-02-04 12:12 ` [LTP] [PATCH v2 1/5] tst_mallinfo.c: Add a common print helper for mallinfo Yang Xu
2021-02-04 12:12 ` [LTP] [PATCH v2 2/5] syscalls/mallopt01: Use tst_print_mallinfo api Yang Xu
2021-02-04 12:12 ` [LTP] [PATCH v2 3/5] syscalls/mallinfo01: Add a basic test for mallinfo Yang Xu
2021-02-04 12:12 ` [LTP] [PATCH v2 4/5] syscalls/mallinfo02: Add a basic test to check use mmap or sbrk Yang Xu
2021-02-04 13:51 ` Li Wang
2021-02-05 7:51 ` Yang Xu
2021-02-05 8:15 ` Yang Xu
2021-02-05 9:00 ` Yang Xu
2021-02-05 9:20 ` Li Wang
2021-02-04 12:12 ` [LTP] [PATCH v2 5/5] syscalls/mallinfo03: Add an overflow test when setting 2G size Yang Xu
2021-02-04 13:29 ` [LTP] [PATCH v2 1/5] tst_mallinfo.c: Add a common print helper for mallinfo Li Wang
2021-02-05 7:44 ` Yang Xu [this message]
2021-02-05 8:00 ` Li Wang
2021-02-05 11:21 ` Petr Vorel
2021-02-08 15:30 ` Cyril Hrubis
2021-02-18 5:52 ` [LTP] [PATCH v3 1/4] syscalls/mallinfo01: Add a basic test " Yang Xu
2021-02-18 5:52 ` [LTP] [PATCH v3 2/4] syscalls/mallopt01: Use unified print_mallinfo api Yang Xu
2021-02-18 5:52 ` [LTP] [PATCH v3 3/4] syscalls/mallinfo02: Add a basic test to check use mmap or sbrk Yang Xu
2021-02-22 6:32 ` Li Wang
2021-02-22 6:40 ` Yang Xu
2021-02-23 1:45 ` Yang Xu
2021-02-18 5:52 ` [LTP] [PATCH v3 4/4] syscalls/mallinfo03: Add an overflow test when setting 2G size Yang Xu
2021-01-28 15:50 ` [LTP] [PATCH v1 1/3] syscalls/mallinfo01: Add a basic test for mallinfo Cyril Hrubis
2021-02-03 6:03 ` Yang Xu
2021-02-04 6:42 ` Li Wang
2021-02-04 9:54 ` Yang Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=601CF76D.8020705@cn.fujitsu.com \
--to=xuyang2018.jy@cn.fujitsu.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.