From: "Stojaczyk, Dariusz" <dariusz.stojaczyk@intel.com>
To: "Richardson, Bruce" <bruce.richardson@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] build: don't parse build configs of explicitly disabled drivers
Date: Thu, 7 May 2020 10:16:53 +0000 [thread overview]
Message-ID: <601ee8a91beb4fe7a9b9b0a686db034a@intel.com> (raw)
In-Reply-To: <20200330135238.GB132@bricha3-MOBL.ger.corp.intel.com>
> -----Original Message-----
> From: Bruce Richardson <bruce.richardson@intel.com>
> Sent: Monday, March 30, 2020 3:53 PM
> To: Stojaczyk, Dariusz <dariusz.stojaczyk@intel.com>
> Cc: dev@dpdk.org
> Subject: Re: [PATCH] build: don't parse build configs of explicitly disabled
> drivers
>
> [SNIP]
>
> Looking at this code and the meson docs again, I think this block and
> previous can be simplified by using the array "contains()" method to avoid
> the loop.
>
> if disabled_drivers.contains(drv_path)
> build = false
> reson = '....'
> else
> # pull in driver ...
> subdir(drv_path)
> endif
>
> Regards,
> /Bruce
Oops, I haven't seen that mail. Sorry! I just pushed v2.
D.
next prev parent reply other threads:[~2020-05-07 10:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-26 9:22 [dpdk-dev] [PATCH] build: don't parse build configs of explicitly disabled drivers Darek Stojaczyk
2020-03-26 11:03 ` Bruce Richardson
2020-03-30 13:52 ` Bruce Richardson
2020-05-07 10:16 ` Stojaczyk, Dariusz [this message]
2020-05-07 10:13 ` [dpdk-dev] [PATCH v2] " Darek Stojaczyk
2020-05-19 14:50 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=601ee8a91beb4fe7a9b9b0a686db034a@intel.com \
--to=dariusz.stojaczyk@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.