From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from perceval.ideasonboard.com ([213.167.242.64]:57978 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726618AbeINNhm (ORCPT ); Fri, 14 Sep 2018 09:37:42 -0400 From: Laurent Pinchart To: jacopo mondi Cc: Laurent Pinchart , dri-devel@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH 03/16] dt-bindings: display: renesas: lvds: Add EXTAL and DU_DOTCLKIN clocks Date: Fri, 14 Sep 2018 11:24:32 +0300 Message-ID: <6030546.koD4IuRgeG@avalon> In-Reply-To: <20180914080046.GK11509@w540> References: <20180904121027.24031-1-laurent.pinchart+renesas@ideasonboard.com> <20180904121027.24031-4-laurent.pinchart+renesas@ideasonboard.com> <20180914080046.GK11509@w540> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-renesas-soc-owner@vger.kernel.org List-ID: Hi Jacopo, On Friday, 14 September 2018 11:00:46 EEST jacopo mondi wrote: > On Tue, Sep 04, 2018 at 03:10:14PM +0300, Laurent Pinchart wrote: > > On the D3 and E3 SoCs, the LVDS encoder can derive its internal pixel > > clock from an externally supplied clock, either through the EXTAL pin or > > through one of the DU_DOTCLKINx pins. Add corresponding clocks to the DT > > bindings. > > > > To retain backward compatibility with DT that don't specify the > > clock-names property, the functional clock must always be specified > > first, and the clock-names property is optional when only the functional > > clock is specified. > > > > Signed-off-by: Laurent Pinchart > > > > --- > > > > .../devicetree/bindings/display/bridge/renesas,lvds.txt | 12 ++++++- > > 1 file changed, 11 insertions(+), 1 deletion(-) > > > > diff --git > > a/Documentation/devicetree/bindings/display/bridge/renesas,lvds.txt > > b/Documentation/devicetree/bindings/display/bridge/renesas,lvds.txt index > > 13af7e2ac7e8..9e3913f6a643 100644 > > --- a/Documentation/devicetree/bindings/display/bridge/renesas,lvds.txt > > +++ b/Documentation/devicetree/bindings/display/bridge/renesas,lvds.txt > > @@ -19,7 +19,17 @@ Required properties: > > - "renesas,r8a77995-lvds" for R8A77995 (R-Car D3) compatible LVDS > > encoders > > > > - reg: Base address and length for the memory-mapped registers > > > > -- clocks: A phandle + clock-specifier pair for the functional clock > > +- clocks: A list of phandles + clock-specifier pairs, one for each entry > > in > > + the clock-names property. > > +- clock-names: Name of the clocks. This property is model-dependent. > > + - The functional clock is mandatory for all models, shall be listed > > first, > > I would write > > The functional clock, which is mandatory for all models, shall be listed > first and shall be named "fck". I'll change that. > > + and shall be named "fck". > > + - On R8A77990 and R8A77995, the LVDS encoder can use the EXTAL or > > + DU_DOTCLKINx clocks. Those clocks are optional. When supplied they > > must be > > + named "extal" and "dclkin.x" respectively, with "x" being the > > DU_DOTCLKIN > > + numerical index. > > Is it valid to list other clocks here for the other SoCs? No, those clocks only exist for D3 and E3, as stated (R8A77990 and R8A77995). Do you think the text isn't clear enough ? > > + - When the clocks property only contains the functional clock, the > > + clock-names property may be omitted. > > > > - resets: A phandle + reset specifier for the module reset > > Thanks > j > > > Required nodes: -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH 03/16] dt-bindings: display: renesas: lvds: Add EXTAL and DU_DOTCLKIN clocks Date: Fri, 14 Sep 2018 11:24:32 +0300 Message-ID: <6030546.koD4IuRgeG@avalon> References: <20180904121027.24031-1-laurent.pinchart+renesas@ideasonboard.com> <20180904121027.24031-4-laurent.pinchart+renesas@ideasonboard.com> <20180914080046.GK11509@w540> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20180914080046.GK11509@w540> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: jacopo mondi Cc: linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org, Laurent Pinchart , dri-devel@lists.freedesktop.org List-Id: devicetree@vger.kernel.org SGkgSmFjb3BvLAoKT24gRnJpZGF5LCAxNCBTZXB0ZW1iZXIgMjAxOCAxMTowMDo0NiBFRVNUIGph Y29wbyBtb25kaSB3cm90ZToKPiBPbiBUdWUsIFNlcCAwNCwgMjAxOCBhdCAwMzoxMDoxNFBNICsw MzAwLCBMYXVyZW50IFBpbmNoYXJ0IHdyb3RlOgo+ID4gT24gdGhlIEQzIGFuZCBFMyBTb0NzLCB0 aGUgTFZEUyBlbmNvZGVyIGNhbiBkZXJpdmUgaXRzIGludGVybmFsIHBpeGVsCj4gPiBjbG9jayBm cm9tIGFuIGV4dGVybmFsbHkgc3VwcGxpZWQgY2xvY2ssIGVpdGhlciB0aHJvdWdoIHRoZSBFWFRB TCBwaW4gb3IKPiA+IHRocm91Z2ggb25lIG9mIHRoZSBEVV9ET1RDTEtJTnggcGlucy4gQWRkIGNv cnJlc3BvbmRpbmcgY2xvY2tzIHRvIHRoZSBEVAo+ID4gYmluZGluZ3MuCj4gPiAKPiA+IFRvIHJl dGFpbiBiYWNrd2FyZCBjb21wYXRpYmlsaXR5IHdpdGggRFQgdGhhdCBkb24ndCBzcGVjaWZ5IHRo ZQo+ID4gY2xvY2stbmFtZXMgcHJvcGVydHksIHRoZSBmdW5jdGlvbmFsIGNsb2NrIG11c3QgYWx3 YXlzIGJlIHNwZWNpZmllZAo+ID4gZmlyc3QsIGFuZCB0aGUgY2xvY2stbmFtZXMgcHJvcGVydHkg aXMgb3B0aW9uYWwgd2hlbiBvbmx5IHRoZSBmdW5jdGlvbmFsCj4gPiBjbG9jayBpcyBzcGVjaWZp ZWQuCj4gPiAKPiA+IFNpZ25lZC1vZmYtYnk6IExhdXJlbnQgUGluY2hhcnQKPiA+IDxsYXVyZW50 LnBpbmNoYXJ0K3JlbmVzYXNAaWRlYXNvbmJvYXJkLmNvbT4KPiA+IC0tLQo+ID4gCj4gPiAgLi4u L2RldmljZXRyZWUvYmluZGluZ3MvZGlzcGxheS9icmlkZ2UvcmVuZXNhcyxsdmRzLnR4dCAgICAg IHwgMTIgKysrKysrLQo+ID4gIDEgZmlsZSBjaGFuZ2VkLCAxMSBpbnNlcnRpb25zKCspLCAxIGRl bGV0aW9uKC0pCj4gPiAKPiA+IGRpZmYgLS1naXQKPiA+IGEvRG9jdW1lbnRhdGlvbi9kZXZpY2V0 cmVlL2JpbmRpbmdzL2Rpc3BsYXkvYnJpZGdlL3JlbmVzYXMsbHZkcy50eHQKPiA+IGIvRG9jdW1l bnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL2Rpc3BsYXkvYnJpZGdlL3JlbmVzYXMsbHZkcy50 eHQgaW5kZXgKPiA+IDEzYWY3ZTJhYzdlOC4uOWUzOTEzZjZhNjQzIDEwMDY0NAo+ID4gLS0tIGEv RG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL2Rpc3BsYXkvYnJpZGdlL3JlbmVzYXMs bHZkcy50eHQKPiA+ICsrKyBiL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9kaXNw bGF5L2JyaWRnZS9yZW5lc2FzLGx2ZHMudHh0Cj4gPiBAQCAtMTksNyArMTksMTcgQEAgUmVxdWly ZWQgcHJvcGVydGllczoKPiA+ICAgIC0gInJlbmVzYXMscjhhNzc5OTUtbHZkcyIgZm9yIFI4QTc3 OTk1IChSLUNhciBEMykgY29tcGF0aWJsZSBMVkRTCj4gPiAgICBlbmNvZGVycwo+ID4gIAo+ID4g IC0gcmVnOiBCYXNlIGFkZHJlc3MgYW5kIGxlbmd0aCBmb3IgdGhlIG1lbW9yeS1tYXBwZWQgcmVn aXN0ZXJzCj4gPiAKPiA+IC0tIGNsb2NrczogQSBwaGFuZGxlICsgY2xvY2stc3BlY2lmaWVyIHBh aXIgZm9yIHRoZSBmdW5jdGlvbmFsIGNsb2NrCj4gPiArLSBjbG9ja3M6IEEgbGlzdCBvZiBwaGFu ZGxlcyArIGNsb2NrLXNwZWNpZmllciBwYWlycywgb25lIGZvciBlYWNoIGVudHJ5Cj4gPiBpbgo+ ID4gKyAgdGhlIGNsb2NrLW5hbWVzIHByb3BlcnR5Lgo+ID4gKy0gY2xvY2stbmFtZXM6IE5hbWUg b2YgdGhlIGNsb2Nrcy4gVGhpcyBwcm9wZXJ0eSBpcyBtb2RlbC1kZXBlbmRlbnQuCj4gPiArICAt IFRoZSBmdW5jdGlvbmFsIGNsb2NrIGlzIG1hbmRhdG9yeSBmb3IgYWxsIG1vZGVscywgc2hhbGwg YmUgbGlzdGVkCj4gPiBmaXJzdCwKPiAKPiBJIHdvdWxkIHdyaXRlCj4gCj4gVGhlIGZ1bmN0aW9u YWwgY2xvY2ssIHdoaWNoIGlzIG1hbmRhdG9yeSBmb3IgYWxsIG1vZGVscywgc2hhbGwgYmUgbGlz dGVkCj4gZmlyc3QgYW5kIHNoYWxsIGJlIG5hbWVkICJmY2siLgoKSSdsbCBjaGFuZ2UgdGhhdC4K Cj4gPiArICAgIGFuZCBzaGFsbCBiZSBuYW1lZCAiZmNrIi4KPiA+ICsgIC0gT24gUjhBNzc5OTAg YW5kIFI4QTc3OTk1LCB0aGUgTFZEUyBlbmNvZGVyIGNhbiB1c2UgdGhlIEVYVEFMIG9yCj4gPiAr ICAgIERVX0RPVENMS0lOeCBjbG9ja3MuIFRob3NlIGNsb2NrcyBhcmUgb3B0aW9uYWwuIFdoZW4g c3VwcGxpZWQgdGhleQo+ID4gbXVzdCBiZQo+ID4gKyAgICBuYW1lZCAiZXh0YWwiIGFuZCAiZGNs a2luLngiIHJlc3BlY3RpdmVseSwgd2l0aCAieCIgYmVpbmcgdGhlCj4gPiBEVV9ET1RDTEtJTgo+ ID4gKyAgICBudW1lcmljYWwgaW5kZXguCj4gCj4gSXMgaXQgdmFsaWQgdG8gbGlzdCBvdGhlciBj bG9ja3MgaGVyZSBmb3IgdGhlIG90aGVyIFNvQ3M/CgpObywgdGhvc2UgY2xvY2tzIG9ubHkgZXhp c3QgZm9yIEQzIGFuZCBFMywgYXMgc3RhdGVkIChSOEE3Nzk5MCBhbmQgUjhBNzc5OTUpLiAKRG8g eW91IHRoaW5rIHRoZSB0ZXh0IGlzbid0IGNsZWFyIGVub3VnaCA/Cgo+ID4gKyAgLSBXaGVuIHRo ZSBjbG9ja3MgcHJvcGVydHkgb25seSBjb250YWlucyB0aGUgZnVuY3Rpb25hbCBjbG9jaywgdGhl Cj4gPiArICAgIGNsb2NrLW5hbWVzIHByb3BlcnR5IG1heSBiZSBvbWl0dGVkLgo+ID4gCj4gPiAg LSByZXNldHM6IEEgcGhhbmRsZSArIHJlc2V0IHNwZWNpZmllciBmb3IgdGhlIG1vZHVsZSByZXNl dAo+IAo+IFRoYW5rcwo+ICAgIGoKPiAKPiA+ICBSZXF1aXJlZCBub2RlczoKCi0tIApSZWdhcmRz LAoKTGF1cmVudCBQaW5jaGFydAoKCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVl ZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5m by9kcmktZGV2ZWwK