All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Laszlo Ersek <lersek@redhat.com>,
	Igor Mammedov <imammedo@redhat.com>,
	"Michael S . Tsirkin" <mst@redhat.com>,
	Corey Minyard <minyard@acm.org>
Cc: qemu-devel@nongnu.org, Eduardo Habkost <ehabkost@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 2/4] hw/smbios: Restrict access to "smbios_ipmi.h"
Date: Mon, 10 Dec 2018 16:53:20 +0100	[thread overview]
Message-ID: <603b0a83-e4d3-8dad-232d-cd95f7bb281e@redhat.com> (raw)
In-Reply-To: <0f7d8556-168d-491d-433b-801837afb0dc@redhat.com>

On 12/10/18 4:00 PM, Laszlo Ersek wrote:
> On 12/07/18 17:51, Philippe Mathieu-Daudé wrote:
>> All the consumers of "smbios_ipmi.h" are located in hw/smbios/.
> 
> I tried to verify this statement by grepping the tree for
> "smbios_ipmi.h". There were zero hits. Please use the more precise
> pathname "hw/smbios/ipmi.h". (I can't suggest just "ipmi.h", because
> that isn't unique.)

I did not notice I used the post-patch pathname, thanks.

> 
> With this update:
> 
> Reviewed-by: Laszlo Ersek <lersek@redhat.com>
> 
> Thanks,
> Laszlo

  reply	other threads:[~2018-12-10 16:04 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-07 16:50 [Qemu-devel] [PATCH 0/4] Introduce the hw/firmware/ namespace Philippe Mathieu-Daudé
2018-12-07 16:51 ` [Qemu-devel] [PATCH 1/4] tests: Remove unused include Philippe Mathieu-Daudé
2018-12-10 14:55   ` Laszlo Ersek
2018-12-10 15:51     ` Philippe Mathieu-Daudé
2018-12-07 16:51 ` [Qemu-devel] [PATCH 2/4] hw/smbios: Restrict access to "smbios_ipmi.h" Philippe Mathieu-Daudé
2018-12-10 15:00   ` Laszlo Ersek
2018-12-10 15:53     ` Philippe Mathieu-Daudé [this message]
2018-12-07 16:51 ` [Qemu-devel] [PATCH 3/4] hw/smbios: Remove "smbios_ipmi.h" Philippe Mathieu-Daudé
2018-12-07 17:13   ` Corey Minyard
2018-12-10 15:04   ` Laszlo Ersek
2018-12-07 16:51 ` [Qemu-arm] [PATCH 4/4] hw/smbios: Move to the hw/firmware/ namespace Philippe Mathieu-Daudé
2018-12-07 16:51   ` [Qemu-devel] " Philippe Mathieu-Daudé
2018-12-10 15:10   ` [Qemu-arm] " Laszlo Ersek
2018-12-10 15:10     ` [Qemu-devel] " Laszlo Ersek
2018-12-10 15:57     ` Philippe Mathieu-Daudé
2018-12-10 15:57       ` Philippe Mathieu-Daudé
2018-12-07 17:36 ` [Qemu-devel] [PATCH 0/4] Introduce " Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=603b0a83-e4d3-8dad-232d-cd95f7bb281e@redhat.com \
    --to=philmd@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=imammedo@redhat.com \
    --cc=lersek@redhat.com \
    --cc=minyard@acm.org \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.