From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 75D01404F9 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org F087F433AD Message-ID: <60497d6d-dfe3-4edc-9553-311fdd9c63d0@arm.com> Date: Fri, 20 Oct 2023 18:05:36 +0200 MIME-Version: 1.0 References: <20231018162540.667646-1-vincent.guittot@linaro.org> <20231018162540.667646-6-vincent.guittot@linaro.org> Content-Language: en-US From: Pierre Gondois In-Reply-To: Content-Type: text/plain; charset="utf-8"; format="flowed" Content-Transfer-Encoding: 8bit Subject: Re: [Acpica-devel] [PATCH v3 5/6] cpufreq/cppc: set the frequency used for computing the capacity List-Id: "This is the central place for ACPICA developer discussions and issues." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Vincent Guittot Cc: juri.lelli@redhat.com, peterz@infradead.org, catalin.marinas@arm.com, robert.moore@intel.com, bsegall@google.com, conor.dooley@microchip.com, linux-riscv@lists.infradead.org, will@kernel.org, acpica-devel@lists.linuxfoundation.org, vschneid@redhat.com, ajones@ventanamicro.com, linux@armlinux.org.uk, linux-acpi@vger.kernel.org, mingo@redhat.com, bristot@redhat.com, lftan@kernel.org, viresh.kumar@linaro.org, mgorman@suse.de, aou@eecs.berkeley.edu, linux-pm@vger.kernel.org, rostedt@goodmis.org, paul.walmsley@sifive.com, dietmar.eggemann@arm.com, linux-arm-kernel@lists.infradead.org, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, palmer@dabbelt.com, sudeep.holla@arm.com, suagrfillet@gmail.com, lenb@kernel.org, ionela.voinescu@arm.com, lukasz.luba@arm.com Hello Vincent, On 10/18/23 19:26, Rafael J. Wysocki wrote: > On Wed, Oct 18, 2023 at 6:25 PM Vincent Guittot > wrote: >> >> Save the frequency associated to the performance that has been used when >> initializing the capacity of CPUs. >> Also, cppc cpufreq driver can register an artificial energy model. In such >> case, it needs the frequency for this compute capacity. >> We moved and renamed cppc_perf_to_khz and cppc_perf_to_khz to use them >> outside cppc_cpufreq in topology_init_cpu_capacity_cppc(). >> >> Signed-off-by: Vincent Guittot > > For the changes in drivers/acpi/cppc_acpi.c : > > Acked-by: Rafael J. Wysocki > >> --- >> drivers/acpi/cppc_acpi.c | 93 ++++++++++++++++++++++ >> drivers/base/arch_topology.c | 15 +++- >> drivers/cpufreq/cppc_cpufreq.c | 141 ++++++--------------------------- >> include/acpi/cppc_acpi.h | 2 + >> 4 files changed, 133 insertions(+), 118 deletions(-) >> [snip] >> diff --git a/drivers/base/arch_topology.c b/drivers/base/arch_topology.c >> index 9a073c2d2086..2372ce791bb4 100644 >> --- a/drivers/base/arch_topology.c >> +++ b/drivers/base/arch_topology.c >> @@ -350,6 +350,7 @@ bool __init topology_parse_cpu_capacity(struct device_node *cpu_node, int cpu) >> void topology_init_cpu_capacity_cppc(void) >> { >> struct cppc_perf_caps perf_caps; >> + u64 capacity, capacity_scale; I think capacity_scale should be initialized to 0 here, since it is used to find the max value of raw_capacity[cpu]. >> int cpu; >> >> if (likely(!acpi_cpc_valid())) >> @@ -365,6 +366,10 @@ void topology_init_cpu_capacity_cppc(void) >> (perf_caps.highest_perf >= perf_caps.nominal_perf) && >> (perf_caps.highest_perf >= perf_caps.lowest_perf)) { >> raw_capacity[cpu] = perf_caps.highest_perf; >> + capacity_scale = max_t(u64, capacity_scale, raw_capacity[cpu]); >> + >> + per_cpu(capacity_ref_freq, cpu) = cppc_perf_to_khz(&perf_caps, raw_capacity[cpu]); I think capacity_ref_freq in in Hz, so the freq should be multiplied by 1000 . With these two modifications, the patches worked well on a cppc-based platform. Sorry I forgot to detail what it was. It's a modified Juno with CPPC enabled. AMUs are not enabled, so the CPPC performance counters are not handled correctly and FIE cannot be enabled, but it is possible to change frequencies. The _CPC objects are setup as: little CPUs: - lowest_freq = 450 (MHz) - nominal_freq = 800 (MHz) - highest_perf = 383 * 1000 - nominal_perf = 322 * 1000 - lowest_perf = 181 * 1000 - lowest_nonlinear_perf = 181 * 1000 big CPUs: - lowest_freq = 600 (MHz) - nominal_freq = 1200 (MHz) - highest_perf = 1024 * 1000 - nominal_perf = 833 * 1000 - lowest_perf = 512 * 1000 - lowest_nonlinear_perf = 512 * 1000 As a remainder, available frequencies are: - little CPUs: 450, 800, 950 MHz - big CPUs: 600, 1000, 1200 Mhz So the platform is setup to have the last frequency as a boost frequency (for testing). ---- Just to make a note of 2 potential side-issues for later (independent from these patches): - When testing with boosted/non-bossted frequencies, it didn't seem that cpu_overutilized() was taking the maximum frequency into consideration. This might mean that when lowering the maximum frequency of a policy, the maximum capacity of the CPUs of this policy is used to detect over-utilization. I would have thought that the over-utilization threshold would be lowered at the same time. - Similarly for EAS, the energy computation doesn't take into account the maximum frequency of the policy. This should mean that EAS is taking into consideration frequencies that are not actually available. Regards, Pierre From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EBFFE1DA32 for ; Fri, 20 Oct 2023 16:05:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=none Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id CA8521BCA; Fri, 20 Oct 2023 09:05:48 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 11851143D; Fri, 20 Oct 2023 09:06:29 -0700 (PDT) Received: from [192.168.1.13] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 5C2C63F5A1; Fri, 20 Oct 2023 09:05:41 -0700 (PDT) Message-ID: <60497d6d-dfe3-4edc-9553-311fdd9c63d0@arm.com> Date: Fri, 20 Oct 2023 18:05:36 +0200 Precedence: bulk X-Mailing-List: linux-acpi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 5/6] cpufreq/cppc: set the frequency used for computing the capacity To: Vincent Guittot Cc: linux@armlinux.org.uk, catalin.marinas@arm.com, will@kernel.org, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, sudeep.holla@arm.com, gregkh@linuxfoundation.org, mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, bristot@redhat.com, vschneid@redhat.com, viresh.kumar@linaro.org, lenb@kernel.org, robert.moore@intel.com, lukasz.luba@arm.com, ionela.voinescu@arm.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, linux-pm@vger.kernel.org, linux-acpi@vger.kernel.org, acpica-devel@lists.linuxfoundation.org, conor.dooley@microchip.com, suagrfillet@gmail.com, ajones@ventanamicro.com, lftan@kernel.org, "Rafael J. Wysocki" References: <20231018162540.667646-1-vincent.guittot@linaro.org> <20231018162540.667646-6-vincent.guittot@linaro.org> Content-Language: en-US From: Pierre Gondois In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hello Vincent, On 10/18/23 19:26, Rafael J. Wysocki wrote: > On Wed, Oct 18, 2023 at 6:25 PM Vincent Guittot > wrote: >> >> Save the frequency associated to the performance that has been used when >> initializing the capacity of CPUs. >> Also, cppc cpufreq driver can register an artificial energy model. In such >> case, it needs the frequency for this compute capacity. >> We moved and renamed cppc_perf_to_khz and cppc_perf_to_khz to use them >> outside cppc_cpufreq in topology_init_cpu_capacity_cppc(). >> >> Signed-off-by: Vincent Guittot > > For the changes in drivers/acpi/cppc_acpi.c : > > Acked-by: Rafael J. Wysocki > >> --- >> drivers/acpi/cppc_acpi.c | 93 ++++++++++++++++++++++ >> drivers/base/arch_topology.c | 15 +++- >> drivers/cpufreq/cppc_cpufreq.c | 141 ++++++--------------------------- >> include/acpi/cppc_acpi.h | 2 + >> 4 files changed, 133 insertions(+), 118 deletions(-) >> [snip] >> diff --git a/drivers/base/arch_topology.c b/drivers/base/arch_topology.c >> index 9a073c2d2086..2372ce791bb4 100644 >> --- a/drivers/base/arch_topology.c >> +++ b/drivers/base/arch_topology.c >> @@ -350,6 +350,7 @@ bool __init topology_parse_cpu_capacity(struct device_node *cpu_node, int cpu) >> void topology_init_cpu_capacity_cppc(void) >> { >> struct cppc_perf_caps perf_caps; >> + u64 capacity, capacity_scale; I think capacity_scale should be initialized to 0 here, since it is used to find the max value of raw_capacity[cpu]. >> int cpu; >> >> if (likely(!acpi_cpc_valid())) >> @@ -365,6 +366,10 @@ void topology_init_cpu_capacity_cppc(void) >> (perf_caps.highest_perf >= perf_caps.nominal_perf) && >> (perf_caps.highest_perf >= perf_caps.lowest_perf)) { >> raw_capacity[cpu] = perf_caps.highest_perf; >> + capacity_scale = max_t(u64, capacity_scale, raw_capacity[cpu]); >> + >> + per_cpu(capacity_ref_freq, cpu) = cppc_perf_to_khz(&perf_caps, raw_capacity[cpu]); I think capacity_ref_freq in in Hz, so the freq should be multiplied by 1000 . With these two modifications, the patches worked well on a cppc-based platform. Sorry I forgot to detail what it was. It's a modified Juno with CPPC enabled. AMUs are not enabled, so the CPPC performance counters are not handled correctly and FIE cannot be enabled, but it is possible to change frequencies. The _CPC objects are setup as: little CPUs: - lowest_freq = 450 (MHz) - nominal_freq = 800 (MHz) - highest_perf = 383 * 1000 - nominal_perf = 322 * 1000 - lowest_perf = 181 * 1000 - lowest_nonlinear_perf = 181 * 1000 big CPUs: - lowest_freq = 600 (MHz) - nominal_freq = 1200 (MHz) - highest_perf = 1024 * 1000 - nominal_perf = 833 * 1000 - lowest_perf = 512 * 1000 - lowest_nonlinear_perf = 512 * 1000 As a remainder, available frequencies are: - little CPUs: 450, 800, 950 MHz - big CPUs: 600, 1000, 1200 Mhz So the platform is setup to have the last frequency as a boost frequency (for testing). ---- Just to make a note of 2 potential side-issues for later (independent from these patches): - When testing with boosted/non-bossted frequencies, it didn't seem that cpu_overutilized() was taking the maximum frequency into consideration. This might mean that when lowering the maximum frequency of a policy, the maximum capacity of the CPUs of this policy is used to detect over-utilization. I would have thought that the over-utilization threshold would be lowered at the same time. - Similarly for EAS, the energy computation doesn't take into account the maximum frequency of the policy. This should mean that EAS is taking into consideration frequencies that are not actually available. Regards, Pierre From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CEBBDC0032E for ; Fri, 20 Oct 2023 16:06:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=W2dAxaYOdgN4cgGyQv0M+IRWK3Hd39wZuPJj1jANufk=; b=QeIz+UjuyCRDqN S7w6Ipkt5cdD8Lxp301iWpMfyNo3pp7mpFO4E/XeZ2XLZsg3BWeSHXdMXtiEHhQfh6Ie/NDzCswUW 3CmiGthd+b7ayjrOS7/oWW1WAA92QBlMwb2ifyAkEc2X7nB89c3MzvyvJBzbPM9a1fINFIh0lxYbp TtPYnR98eZ39vIU4gdTWs/KIF046YWLlkQtkzCTROW5neM8zE1pbDCRRi7+kM3JSR6KCW20k7qat/ /9VWTJX3SCyhRYhTGQluwWuAdipRxeCMC82Kn0N9rhX++G2RtHGJFKNld8O2GJ9YdpAjEExfvXelu 6dYLXGmGVAGvSP+2fyMw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qts0a-002fbr-2z; Fri, 20 Oct 2023 16:05:56 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qts0W-002fao-2S; Fri, 20 Oct 2023 16:05:54 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 11851143D; Fri, 20 Oct 2023 09:06:29 -0700 (PDT) Received: from [192.168.1.13] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 5C2C63F5A1; Fri, 20 Oct 2023 09:05:41 -0700 (PDT) Message-ID: <60497d6d-dfe3-4edc-9553-311fdd9c63d0@arm.com> Date: Fri, 20 Oct 2023 18:05:36 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 5/6] cpufreq/cppc: set the frequency used for computing the capacity To: Vincent Guittot Cc: linux@armlinux.org.uk, catalin.marinas@arm.com, will@kernel.org, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, sudeep.holla@arm.com, gregkh@linuxfoundation.org, mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, bristot@redhat.com, vschneid@redhat.com, viresh.kumar@linaro.org, lenb@kernel.org, robert.moore@intel.com, lukasz.luba@arm.com, ionela.voinescu@arm.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, linux-pm@vger.kernel.org, linux-acpi@vger.kernel.org, acpica-devel@lists.linuxfoundation.org, conor.dooley@microchip.com, suagrfillet@gmail.com, ajones@ventanamicro.com, lftan@kernel.org, "Rafael J. Wysocki" References: <20231018162540.667646-1-vincent.guittot@linaro.org> <20231018162540.667646-6-vincent.guittot@linaro.org> Content-Language: en-US From: Pierre Gondois In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231020_090552_912145_21AFE96E X-CRM114-Status: GOOD ( 21.32 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org SGVsbG8gVmluY2VudCwKCk9uIDEwLzE4LzIzIDE5OjI2LCBSYWZhZWwgSi4gV3lzb2NraSB3cm90 ZToKPiBPbiBXZWQsIE9jdCAxOCwgMjAyMyBhdCA2OjI14oCvUE0gVmluY2VudCBHdWl0dG90Cj4g PHZpbmNlbnQuZ3VpdHRvdEBsaW5hcm8ub3JnPiB3cm90ZToKPj4KPj4gU2F2ZSB0aGUgZnJlcXVl bmN5IGFzc29jaWF0ZWQgdG8gdGhlIHBlcmZvcm1hbmNlIHRoYXQgaGFzIGJlZW4gdXNlZCB3aGVu Cj4+IGluaXRpYWxpemluZyB0aGUgY2FwYWNpdHkgb2YgQ1BVcy4KPj4gQWxzbywgY3BwYyBjcHVm cmVxIGRyaXZlciBjYW4gcmVnaXN0ZXIgYW4gYXJ0aWZpY2lhbCBlbmVyZ3kgbW9kZWwuIEluIHN1 Y2gKPj4gY2FzZSwgaXQgbmVlZHMgdGhlIGZyZXF1ZW5jeSBmb3IgdGhpcyBjb21wdXRlIGNhcGFj aXR5Lgo+PiBXZSBtb3ZlZCBhbmQgcmVuYW1lZCBjcHBjX3BlcmZfdG9fa2h6IGFuZCBjcHBjX3Bl cmZfdG9fa2h6IHRvIHVzZSB0aGVtCj4+IG91dHNpZGUgY3BwY19jcHVmcmVxIGluIHRvcG9sb2d5 X2luaXRfY3B1X2NhcGFjaXR5X2NwcGMoKS4KPj4KPj4gU2lnbmVkLW9mZi1ieTogVmluY2VudCBH dWl0dG90IDx2aW5jZW50Lmd1aXR0b3RAbGluYXJvLm9yZz4KPiAKPiBGb3IgdGhlIGNoYW5nZXMg aW4gZHJpdmVycy9hY3BpL2NwcGNfYWNwaS5jIDoKPiAKPiBBY2tlZC1ieTogUmFmYWVsIEouIFd5 c29ja2kgPHJhZmFlbEBrZXJuZWwub3JnPgo+IAo+PiAtLS0KPj4gICBkcml2ZXJzL2FjcGkvY3Bw Y19hY3BpLmMgICAgICAgfCAgOTMgKysrKysrKysrKysrKysrKysrKysrKwo+PiAgIGRyaXZlcnMv YmFzZS9hcmNoX3RvcG9sb2d5LmMgICB8ICAxNSArKystCj4+ICAgZHJpdmVycy9jcHVmcmVxL2Nw cGNfY3B1ZnJlcS5jIHwgMTQxICsrKysrKy0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQo+PiAg IGluY2x1ZGUvYWNwaS9jcHBjX2FjcGkuaCAgICAgICB8ICAgMiArCj4+ICAgNCBmaWxlcyBjaGFu Z2VkLCAxMzMgaW5zZXJ0aW9ucygrKSwgMTE4IGRlbGV0aW9ucygtKQo+PgoKW3NuaXBdCgo+PiBk aWZmIC0tZ2l0IGEvZHJpdmVycy9iYXNlL2FyY2hfdG9wb2xvZ3kuYyBiL2RyaXZlcnMvYmFzZS9h cmNoX3RvcG9sb2d5LmMKPj4gaW5kZXggOWEwNzNjMmQyMDg2Li4yMzcyY2U3OTFiYjQgMTAwNjQ0 Cj4+IC0tLSBhL2RyaXZlcnMvYmFzZS9hcmNoX3RvcG9sb2d5LmMKPj4gKysrIGIvZHJpdmVycy9i YXNlL2FyY2hfdG9wb2xvZ3kuYwo+PiBAQCAtMzUwLDYgKzM1MCw3IEBAIGJvb2wgX19pbml0IHRv cG9sb2d5X3BhcnNlX2NwdV9jYXBhY2l0eShzdHJ1Y3QgZGV2aWNlX25vZGUgKmNwdV9ub2RlLCBp bnQgY3B1KQo+PiAgIHZvaWQgdG9wb2xvZ3lfaW5pdF9jcHVfY2FwYWNpdHlfY3BwYyh2b2lkKQo+ PiAgIHsKPj4gICAgICAgICAgc3RydWN0IGNwcGNfcGVyZl9jYXBzIHBlcmZfY2FwczsKPj4gKyAg ICAgICB1NjQgY2FwYWNpdHksIGNhcGFjaXR5X3NjYWxlOwoKSSB0aGluayBjYXBhY2l0eV9zY2Fs ZSBzaG91bGQgYmUgaW5pdGlhbGl6ZWQgdG8gMCBoZXJlLApzaW5jZSBpdCBpcyB1c2VkIHRvIGZp bmQgdGhlIG1heCB2YWx1ZSBvZiByYXdfY2FwYWNpdHlbY3B1XS4KCj4+ICAgICAgICAgIGludCBj cHU7Cj4+Cj4+ICAgICAgICAgIGlmIChsaWtlbHkoIWFjcGlfY3BjX3ZhbGlkKCkpKQo+PiBAQCAt MzY1LDYgKzM2NiwxMCBAQCB2b2lkIHRvcG9sb2d5X2luaXRfY3B1X2NhcGFjaXR5X2NwcGModm9p ZCkKPj4gICAgICAgICAgICAgICAgICAgICAgKHBlcmZfY2Fwcy5oaWdoZXN0X3BlcmYgPj0gcGVy Zl9jYXBzLm5vbWluYWxfcGVyZikgJiYKPj4gICAgICAgICAgICAgICAgICAgICAgKHBlcmZfY2Fw cy5oaWdoZXN0X3BlcmYgPj0gcGVyZl9jYXBzLmxvd2VzdF9wZXJmKSkgewo+PiAgICAgICAgICAg ICAgICAgICAgICAgICAgcmF3X2NhcGFjaXR5W2NwdV0gPSBwZXJmX2NhcHMuaGlnaGVzdF9wZXJm Owo+PiArICAgICAgICAgICAgICAgICAgICAgICBjYXBhY2l0eV9zY2FsZSA9IG1heF90KHU2NCwg Y2FwYWNpdHlfc2NhbGUsIHJhd19jYXBhY2l0eVtjcHVdKTsKPj4gKwo+PiArICAgICAgICAgICAg ICAgICAgICAgICBwZXJfY3B1KGNhcGFjaXR5X3JlZl9mcmVxLCBjcHUpID0gY3BwY19wZXJmX3Rv X2toeigmcGVyZl9jYXBzLCByYXdfY2FwYWNpdHlbY3B1XSk7CgpJIHRoaW5rIGNhcGFjaXR5X3Jl Zl9mcmVxIGluIGluIEh6LCBzbyB0aGUgZnJlcSBzaG91bGQgYmUgbXVsdGlwbGllZCBieSAxMDAw IC4KCldpdGggdGhlc2UgdHdvIG1vZGlmaWNhdGlvbnMsIHRoZSBwYXRjaGVzIHdvcmtlZCB3ZWxs IG9uIGEgY3BwYy1iYXNlZCBwbGF0Zm9ybS4KClNvcnJ5IEkgZm9yZ290IHRvIGRldGFpbCB3aGF0 IGl0IHdhcy4gSXQncyBhIG1vZGlmaWVkIEp1bm8gd2l0aCBDUFBDIGVuYWJsZWQuIEFNVXMgYXJl IG5vdAplbmFibGVkLCBzbyB0aGUgQ1BQQyBwZXJmb3JtYW5jZSBjb3VudGVycyBhcmUgbm90IGhh bmRsZWQgY29ycmVjdGx5IGFuZCBGSUUgY2Fubm90IGJlIGVuYWJsZWQsCmJ1dCBpdCBpcyBwb3Nz aWJsZSB0byBjaGFuZ2UgZnJlcXVlbmNpZXMuCgpUaGUgX0NQQyBvYmplY3RzIGFyZSBzZXR1cCBh czoKbGl0dGxlIENQVXM6Ci0gbG93ZXN0X2ZyZXEgPSA0NTAgKE1IeikKLSBub21pbmFsX2ZyZXEg PSA4MDAgKE1IeikKLSBoaWdoZXN0X3BlcmYgPSAzODMgKiAxMDAwCi0gbm9taW5hbF9wZXJmID0g MzIyICogMTAwMAotIGxvd2VzdF9wZXJmID0gMTgxICogMTAwMAotIGxvd2VzdF9ub25saW5lYXJf cGVyZiA9IDE4MSAqIDEwMDAKCmJpZyBDUFVzOgotIGxvd2VzdF9mcmVxID0gNjAwIChNSHopCi0g bm9taW5hbF9mcmVxID0gMTIwMCAoTUh6KQotIGhpZ2hlc3RfcGVyZiA9IDEwMjQgKiAxMDAwCi0g bm9taW5hbF9wZXJmID0gODMzICogMTAwMAotIGxvd2VzdF9wZXJmID0gNTEyICogMTAwMAotIGxv d2VzdF9ub25saW5lYXJfcGVyZiA9IDUxMiAqIDEwMDAKCkFzIGEgcmVtYWluZGVyLCBhdmFpbGFi bGUgZnJlcXVlbmNpZXMgYXJlOgotIGxpdHRsZSBDUFVzOiA0NTAsIDgwMCwgOTUwIE1IegotIGJp ZyBDUFVzOiA2MDAsIDEwMDAsIDEyMDAgTWh6ClNvIHRoZSBwbGF0Zm9ybSBpcyBzZXR1cCB0byBo YXZlIHRoZSBsYXN0IGZyZXF1ZW5jeSBhcyBhIGJvb3N0IGZyZXF1ZW5jeSAoZm9yIHRlc3Rpbmcp LgoKLS0tLQoKSnVzdCB0byBtYWtlIGEgbm90ZSBvZiAyIHBvdGVudGlhbCBzaWRlLWlzc3VlcyBm b3IgbGF0ZXIgKGluZGVwZW5kZW50IGZyb20gdGhlc2UgcGF0Y2hlcyk6CgotIFdoZW4gdGVzdGlu ZyB3aXRoIGJvb3N0ZWQvbm9uLWJvc3N0ZWQgZnJlcXVlbmNpZXMsIGl0IGRpZG4ndCBzZWVtIHRo YXQgY3B1X292ZXJ1dGlsaXplZCgpCiAgIHdhcyB0YWtpbmcgdGhlIG1heGltdW0gZnJlcXVlbmN5 IGludG8gY29uc2lkZXJhdGlvbi4gVGhpcyBtaWdodCBtZWFuIHRoYXQgd2hlbiBsb3dlcmluZyB0 aGUKICAgbWF4aW11bSBmcmVxdWVuY3kgb2YgYSBwb2xpY3ksIHRoZSBtYXhpbXVtIGNhcGFjaXR5 IG9mIHRoZSBDUFVzIG9mIHRoaXMgcG9saWN5IGlzIHVzZWQKICAgdG8gZGV0ZWN0IG92ZXItdXRp bGl6YXRpb24uCiAgIEkgd291bGQgaGF2ZSB0aG91Z2h0IHRoYXQgdGhlIG92ZXItdXRpbGl6YXRp b24gdGhyZXNob2xkIHdvdWxkIGJlIGxvd2VyZWQgYXQgdGhlIHNhbWUgdGltZS4KCi0gU2ltaWxh cmx5IGZvciBFQVMsIHRoZSBlbmVyZ3kgY29tcHV0YXRpb24gZG9lc24ndCB0YWtlIGludG8gYWNj b3VudCB0aGUgbWF4aW11bSBmcmVxdWVuY3kKICAgb2YgdGhlIHBvbGljeS4gVGhpcyBzaG91bGQg bWVhbiB0aGF0IEVBUyBpcyB0YWtpbmcgaW50byBjb25zaWRlcmF0aW9uIGZyZXF1ZW5jaWVzIHRo YXQKICAgYXJlIG5vdCBhY3R1YWxseSBhdmFpbGFibGUuCgoKUmVnYXJkcywKUGllcnJlCgpfX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1yaXNjdiBt YWlsaW5nIGxpc3QKbGludXgtcmlzY3ZAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMu aW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LXJpc2N2Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4502CC001DF for ; Fri, 20 Oct 2023 16:06:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=YFcqsD3D59XQBn37tIx/Hv8wnDEVeki2SLuyE8FsrPU=; b=LaFbermqMCKRZo c2/MkYrPS44iKv8V4qKf3DlZ00ax7QoSNV+SBDPupejB75kLp71ZexDlRLaIOf9tChOkye0vodCa/ TmyX3X/QcdNTNq4P/IiWv/pcCbv9U3RrQ1JwS01es2F274sjDf8fdqO4DE/0AKqjLd6uOY+JouSUt rAyviP0JMLn5j5LdgQsN6vaWEvjGSwIRr6L+qF6MqpY0F3v1eGtoDT+4+sRRy1794BrKTObtkYSOo WNdGlGNg5H12j2CWSL+/OhAd83dxhREiUGxR+/85HhJ1ziFYDxwbKsiy0W8jVdH1QxklmZYaQikn5 VJiE/iPG6vBufRKgCK1g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qts0a-002fbb-12; Fri, 20 Oct 2023 16:05:56 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qts0W-002fao-2S; Fri, 20 Oct 2023 16:05:54 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 11851143D; Fri, 20 Oct 2023 09:06:29 -0700 (PDT) Received: from [192.168.1.13] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 5C2C63F5A1; Fri, 20 Oct 2023 09:05:41 -0700 (PDT) Message-ID: <60497d6d-dfe3-4edc-9553-311fdd9c63d0@arm.com> Date: Fri, 20 Oct 2023 18:05:36 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 5/6] cpufreq/cppc: set the frequency used for computing the capacity To: Vincent Guittot Cc: linux@armlinux.org.uk, catalin.marinas@arm.com, will@kernel.org, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, sudeep.holla@arm.com, gregkh@linuxfoundation.org, mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, bristot@redhat.com, vschneid@redhat.com, viresh.kumar@linaro.org, lenb@kernel.org, robert.moore@intel.com, lukasz.luba@arm.com, ionela.voinescu@arm.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, linux-pm@vger.kernel.org, linux-acpi@vger.kernel.org, acpica-devel@lists.linuxfoundation.org, conor.dooley@microchip.com, suagrfillet@gmail.com, ajones@ventanamicro.com, lftan@kernel.org, "Rafael J. Wysocki" References: <20231018162540.667646-1-vincent.guittot@linaro.org> <20231018162540.667646-6-vincent.guittot@linaro.org> Content-Language: en-US From: Pierre Gondois In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231020_090552_912145_21AFE96E X-CRM114-Status: GOOD ( 21.32 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGVsbG8gVmluY2VudCwKCk9uIDEwLzE4LzIzIDE5OjI2LCBSYWZhZWwgSi4gV3lzb2NraSB3cm90 ZToKPiBPbiBXZWQsIE9jdCAxOCwgMjAyMyBhdCA2OjI14oCvUE0gVmluY2VudCBHdWl0dG90Cj4g PHZpbmNlbnQuZ3VpdHRvdEBsaW5hcm8ub3JnPiB3cm90ZToKPj4KPj4gU2F2ZSB0aGUgZnJlcXVl bmN5IGFzc29jaWF0ZWQgdG8gdGhlIHBlcmZvcm1hbmNlIHRoYXQgaGFzIGJlZW4gdXNlZCB3aGVu Cj4+IGluaXRpYWxpemluZyB0aGUgY2FwYWNpdHkgb2YgQ1BVcy4KPj4gQWxzbywgY3BwYyBjcHVm cmVxIGRyaXZlciBjYW4gcmVnaXN0ZXIgYW4gYXJ0aWZpY2lhbCBlbmVyZ3kgbW9kZWwuIEluIHN1 Y2gKPj4gY2FzZSwgaXQgbmVlZHMgdGhlIGZyZXF1ZW5jeSBmb3IgdGhpcyBjb21wdXRlIGNhcGFj aXR5Lgo+PiBXZSBtb3ZlZCBhbmQgcmVuYW1lZCBjcHBjX3BlcmZfdG9fa2h6IGFuZCBjcHBjX3Bl cmZfdG9fa2h6IHRvIHVzZSB0aGVtCj4+IG91dHNpZGUgY3BwY19jcHVmcmVxIGluIHRvcG9sb2d5 X2luaXRfY3B1X2NhcGFjaXR5X2NwcGMoKS4KPj4KPj4gU2lnbmVkLW9mZi1ieTogVmluY2VudCBH dWl0dG90IDx2aW5jZW50Lmd1aXR0b3RAbGluYXJvLm9yZz4KPiAKPiBGb3IgdGhlIGNoYW5nZXMg aW4gZHJpdmVycy9hY3BpL2NwcGNfYWNwaS5jIDoKPiAKPiBBY2tlZC1ieTogUmFmYWVsIEouIFd5 c29ja2kgPHJhZmFlbEBrZXJuZWwub3JnPgo+IAo+PiAtLS0KPj4gICBkcml2ZXJzL2FjcGkvY3Bw Y19hY3BpLmMgICAgICAgfCAgOTMgKysrKysrKysrKysrKysrKysrKysrKwo+PiAgIGRyaXZlcnMv YmFzZS9hcmNoX3RvcG9sb2d5LmMgICB8ICAxNSArKystCj4+ICAgZHJpdmVycy9jcHVmcmVxL2Nw cGNfY3B1ZnJlcS5jIHwgMTQxICsrKysrKy0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQo+PiAg IGluY2x1ZGUvYWNwaS9jcHBjX2FjcGkuaCAgICAgICB8ICAgMiArCj4+ICAgNCBmaWxlcyBjaGFu Z2VkLCAxMzMgaW5zZXJ0aW9ucygrKSwgMTE4IGRlbGV0aW9ucygtKQo+PgoKW3NuaXBdCgo+PiBk aWZmIC0tZ2l0IGEvZHJpdmVycy9iYXNlL2FyY2hfdG9wb2xvZ3kuYyBiL2RyaXZlcnMvYmFzZS9h cmNoX3RvcG9sb2d5LmMKPj4gaW5kZXggOWEwNzNjMmQyMDg2Li4yMzcyY2U3OTFiYjQgMTAwNjQ0 Cj4+IC0tLSBhL2RyaXZlcnMvYmFzZS9hcmNoX3RvcG9sb2d5LmMKPj4gKysrIGIvZHJpdmVycy9i YXNlL2FyY2hfdG9wb2xvZ3kuYwo+PiBAQCAtMzUwLDYgKzM1MCw3IEBAIGJvb2wgX19pbml0IHRv cG9sb2d5X3BhcnNlX2NwdV9jYXBhY2l0eShzdHJ1Y3QgZGV2aWNlX25vZGUgKmNwdV9ub2RlLCBp bnQgY3B1KQo+PiAgIHZvaWQgdG9wb2xvZ3lfaW5pdF9jcHVfY2FwYWNpdHlfY3BwYyh2b2lkKQo+ PiAgIHsKPj4gICAgICAgICAgc3RydWN0IGNwcGNfcGVyZl9jYXBzIHBlcmZfY2FwczsKPj4gKyAg ICAgICB1NjQgY2FwYWNpdHksIGNhcGFjaXR5X3NjYWxlOwoKSSB0aGluayBjYXBhY2l0eV9zY2Fs ZSBzaG91bGQgYmUgaW5pdGlhbGl6ZWQgdG8gMCBoZXJlLApzaW5jZSBpdCBpcyB1c2VkIHRvIGZp bmQgdGhlIG1heCB2YWx1ZSBvZiByYXdfY2FwYWNpdHlbY3B1XS4KCj4+ICAgICAgICAgIGludCBj cHU7Cj4+Cj4+ICAgICAgICAgIGlmIChsaWtlbHkoIWFjcGlfY3BjX3ZhbGlkKCkpKQo+PiBAQCAt MzY1LDYgKzM2NiwxMCBAQCB2b2lkIHRvcG9sb2d5X2luaXRfY3B1X2NhcGFjaXR5X2NwcGModm9p ZCkKPj4gICAgICAgICAgICAgICAgICAgICAgKHBlcmZfY2Fwcy5oaWdoZXN0X3BlcmYgPj0gcGVy Zl9jYXBzLm5vbWluYWxfcGVyZikgJiYKPj4gICAgICAgICAgICAgICAgICAgICAgKHBlcmZfY2Fw cy5oaWdoZXN0X3BlcmYgPj0gcGVyZl9jYXBzLmxvd2VzdF9wZXJmKSkgewo+PiAgICAgICAgICAg ICAgICAgICAgICAgICAgcmF3X2NhcGFjaXR5W2NwdV0gPSBwZXJmX2NhcHMuaGlnaGVzdF9wZXJm Owo+PiArICAgICAgICAgICAgICAgICAgICAgICBjYXBhY2l0eV9zY2FsZSA9IG1heF90KHU2NCwg Y2FwYWNpdHlfc2NhbGUsIHJhd19jYXBhY2l0eVtjcHVdKTsKPj4gKwo+PiArICAgICAgICAgICAg ICAgICAgICAgICBwZXJfY3B1KGNhcGFjaXR5X3JlZl9mcmVxLCBjcHUpID0gY3BwY19wZXJmX3Rv X2toeigmcGVyZl9jYXBzLCByYXdfY2FwYWNpdHlbY3B1XSk7CgpJIHRoaW5rIGNhcGFjaXR5X3Jl Zl9mcmVxIGluIGluIEh6LCBzbyB0aGUgZnJlcSBzaG91bGQgYmUgbXVsdGlwbGllZCBieSAxMDAw IC4KCldpdGggdGhlc2UgdHdvIG1vZGlmaWNhdGlvbnMsIHRoZSBwYXRjaGVzIHdvcmtlZCB3ZWxs IG9uIGEgY3BwYy1iYXNlZCBwbGF0Zm9ybS4KClNvcnJ5IEkgZm9yZ290IHRvIGRldGFpbCB3aGF0 IGl0IHdhcy4gSXQncyBhIG1vZGlmaWVkIEp1bm8gd2l0aCBDUFBDIGVuYWJsZWQuIEFNVXMgYXJl IG5vdAplbmFibGVkLCBzbyB0aGUgQ1BQQyBwZXJmb3JtYW5jZSBjb3VudGVycyBhcmUgbm90IGhh bmRsZWQgY29ycmVjdGx5IGFuZCBGSUUgY2Fubm90IGJlIGVuYWJsZWQsCmJ1dCBpdCBpcyBwb3Nz aWJsZSB0byBjaGFuZ2UgZnJlcXVlbmNpZXMuCgpUaGUgX0NQQyBvYmplY3RzIGFyZSBzZXR1cCBh czoKbGl0dGxlIENQVXM6Ci0gbG93ZXN0X2ZyZXEgPSA0NTAgKE1IeikKLSBub21pbmFsX2ZyZXEg PSA4MDAgKE1IeikKLSBoaWdoZXN0X3BlcmYgPSAzODMgKiAxMDAwCi0gbm9taW5hbF9wZXJmID0g MzIyICogMTAwMAotIGxvd2VzdF9wZXJmID0gMTgxICogMTAwMAotIGxvd2VzdF9ub25saW5lYXJf cGVyZiA9IDE4MSAqIDEwMDAKCmJpZyBDUFVzOgotIGxvd2VzdF9mcmVxID0gNjAwIChNSHopCi0g bm9taW5hbF9mcmVxID0gMTIwMCAoTUh6KQotIGhpZ2hlc3RfcGVyZiA9IDEwMjQgKiAxMDAwCi0g bm9taW5hbF9wZXJmID0gODMzICogMTAwMAotIGxvd2VzdF9wZXJmID0gNTEyICogMTAwMAotIGxv d2VzdF9ub25saW5lYXJfcGVyZiA9IDUxMiAqIDEwMDAKCkFzIGEgcmVtYWluZGVyLCBhdmFpbGFi bGUgZnJlcXVlbmNpZXMgYXJlOgotIGxpdHRsZSBDUFVzOiA0NTAsIDgwMCwgOTUwIE1IegotIGJp ZyBDUFVzOiA2MDAsIDEwMDAsIDEyMDAgTWh6ClNvIHRoZSBwbGF0Zm9ybSBpcyBzZXR1cCB0byBo YXZlIHRoZSBsYXN0IGZyZXF1ZW5jeSBhcyBhIGJvb3N0IGZyZXF1ZW5jeSAoZm9yIHRlc3Rpbmcp LgoKLS0tLQoKSnVzdCB0byBtYWtlIGEgbm90ZSBvZiAyIHBvdGVudGlhbCBzaWRlLWlzc3VlcyBm b3IgbGF0ZXIgKGluZGVwZW5kZW50IGZyb20gdGhlc2UgcGF0Y2hlcyk6CgotIFdoZW4gdGVzdGlu ZyB3aXRoIGJvb3N0ZWQvbm9uLWJvc3N0ZWQgZnJlcXVlbmNpZXMsIGl0IGRpZG4ndCBzZWVtIHRo YXQgY3B1X292ZXJ1dGlsaXplZCgpCiAgIHdhcyB0YWtpbmcgdGhlIG1heGltdW0gZnJlcXVlbmN5 IGludG8gY29uc2lkZXJhdGlvbi4gVGhpcyBtaWdodCBtZWFuIHRoYXQgd2hlbiBsb3dlcmluZyB0 aGUKICAgbWF4aW11bSBmcmVxdWVuY3kgb2YgYSBwb2xpY3ksIHRoZSBtYXhpbXVtIGNhcGFjaXR5 IG9mIHRoZSBDUFVzIG9mIHRoaXMgcG9saWN5IGlzIHVzZWQKICAgdG8gZGV0ZWN0IG92ZXItdXRp bGl6YXRpb24uCiAgIEkgd291bGQgaGF2ZSB0aG91Z2h0IHRoYXQgdGhlIG92ZXItdXRpbGl6YXRp b24gdGhyZXNob2xkIHdvdWxkIGJlIGxvd2VyZWQgYXQgdGhlIHNhbWUgdGltZS4KCi0gU2ltaWxh cmx5IGZvciBFQVMsIHRoZSBlbmVyZ3kgY29tcHV0YXRpb24gZG9lc24ndCB0YWtlIGludG8gYWNj b3VudCB0aGUgbWF4aW11bSBmcmVxdWVuY3kKICAgb2YgdGhlIHBvbGljeS4gVGhpcyBzaG91bGQg bWVhbiB0aGF0IEVBUyBpcyB0YWtpbmcgaW50byBjb25zaWRlcmF0aW9uIGZyZXF1ZW5jaWVzIHRo YXQKICAgYXJlIG5vdCBhY3R1YWxseSBhdmFpbGFibGUuCgoKUmVnYXJkcywKUGllcnJlCgpfX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2Vy bmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0 cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVs Cg==