Re: [PATCH v1 4/4] platform/surface: Migrate to serdev specific shutdown function

["Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>]

[-- Attachment #1: Type: text/plain, Size: 1809 bytes --]

On Fri, 12 Dec 2025, Uwe Kleine-König wrote:

> The motivation is stop using the callback .shutdown in
> qca_serdev_driver.driver to make it possible to drop that.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>

In case somebody wants to take the entire series,

Acked-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>

-- 
 i.


> ---
>  drivers/platform/surface/aggregator/core.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/platform/surface/aggregator/core.c b/drivers/platform/surface/aggregator/core.c
> index c58e1fdd1a5f..860702c4266f 100644
> --- a/drivers/platform/surface/aggregator/core.c
> +++ b/drivers/platform/surface/aggregator/core.c
> @@ -380,9 +380,9 @@ static int ssam_serdev_setup(struct acpi_device *ssh, struct serdev_device *serd
>  
>  /* -- Power management. ----------------------------------------------------- */
>  
> -static void ssam_serial_hub_shutdown(struct device *dev)
> +static void ssam_serial_hub_shutdown(struct serdev_device *serdev)
>  {
> -	struct ssam_controller *c = dev_get_drvdata(dev);
> +	struct ssam_controller *c = dev_get_drvdata(&serdev->dev);
>  	int status;
>  
>  	/*
> @@ -834,12 +834,12 @@ MODULE_DEVICE_TABLE(of, ssam_serial_hub_of_match);
>  static struct serdev_device_driver ssam_serial_hub = {
>  	.probe = ssam_serial_hub_probe,
>  	.remove = ssam_serial_hub_remove,
> +	.shutdown = ssam_serial_hub_shutdown,
>  	.driver = {
>  		.name = "surface_serial_hub",
>  		.acpi_match_table = ACPI_PTR(ssam_serial_hub_acpi_match),
>  		.of_match_table = of_match_ptr(ssam_serial_hub_of_match),
>  		.pm = &ssam_serial_hub_pm_ops,
> -		.shutdown = ssam_serial_hub_shutdown,
>  		.probe_type = PROBE_PREFER_ASYNCHRONOUS,
>  	},
>  };
>