From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 10.28.91.67 with SMTP id p64csp3867954wmb; Tue, 20 Mar 2018 06:59:38 -0700 (PDT) X-Google-Smtp-Source: AG47ELuJiBH78PblyArjr2sOY86qNO9ILePoPj3ZWCv/gn3SqkraiQlr/PtaqrwnuAiVpK+bf9Iv X-Received: by 10.200.26.58 with SMTP id v55mr24017243qtj.268.1521554377937; Tue, 20 Mar 2018 06:59:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1521554377; cv=none; d=google.com; s=arc-20160816; b=GYw09cVxoG5xuxzSEoBRMdMVjtHzL6zUMRdLcDuJaKWSHzsw5yuhtyRPaCUCOK+/xi dg3ZIrHWqTXOan0mEaa2BJ922+hGU3h5sS58TV0+3GeuFGPewc0p6kkCu30/ENaCQfFC 57+oZe0jKmXWJA0VRFFHphkxgOE4H8rAtjnJQ5ptHVsVVUuueRok9HqV8pLA4srNajK7 v93O6qLGpB5CG9jsxgBt0g6QZwq4EP30vYTRvR379rKMw5dngnbNo/BtIY6eD6SajGYp f+NVqHqeP4rmuxMwD9i4UsC7P61Wp8fAalXjNscebdx0KCzyCM4Bq6n7h/JmabGJ0Sah VWrg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject :content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:to :arc-authentication-results; bh=zC3E5B5kTYujM4pePZZ2lDYnNLSoi1lO5q7ABohWzKs=; b=nX1OjIRD3wysbzLX38zxo1Jo/FQ+VvzwtrpR6wbbTuNhtKpeO+VECI3xY7KUyVJfog +TKXzwOfbu9dg+LLORVDqTbifLaroxe6/v/U5+q9aaSEq3cxYgMVCwWzy9mDCJFnGa2n frR11bzdRXkfGTsNMURFlWD6645QYKxk4U4M22VFDLaidggglGjAVHUs2B/BLX5TiwfL u3XuDsqasnkO4E/2yqmqWATcidOB0hc1vpXep97lxfQsBAgYony+CanGayJCBuLMeJGY KGrAq2TwN3ehoTsxm8AVvFA8rB/Ov/T2JAQCraZmKpgprBVYh4CGqUvWJlLkVngJM41m hZGQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id e64si2029469qtb.401.2018.03.20.06.59.37 for (version=TLS1 cipher=AES128-SHA bits=128/128); Tue, 20 Mar 2018 06:59:37 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Authentication-Results: mx.google.com; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1]:48941 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eyHnd-0006gL-EM for alex.bennee@linaro.org; Tue, 20 Mar 2018 09:59:37 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34772) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eyHbf-0007xL-QA for qemu-arm@nongnu.org; Tue, 20 Mar 2018 09:47:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eyHbb-00084N-Qm for qemu-arm@nongnu.org; Tue, 20 Mar 2018 09:47:15 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:55748 helo=mx1.redhat.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eyHbb-00083A-Ib; Tue, 20 Mar 2018 09:47:11 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 33348A1BD3; Tue, 20 Mar 2018 13:47:06 +0000 (UTC) Received: from [10.36.116.22] (ovpn-116-22.ams2.redhat.com [10.36.116.22]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 304F9215CDB7; Tue, 20 Mar 2018 13:46:47 +0000 (UTC) To: Gerd Hoffmann , =?UTF-8?Q?Daniel_P._Berrang=c3=a9?= References: <1521510562-529051-1-git-send-email-mst@redhat.com> <8f06e1e3-4823-d8e8-43bd-c092c523849e@vivier.eu> <20180320094406.GD4530@redhat.com> <20180320141107-mutt-send-email-mst@kernel.org> <20180320121841.GN4530@redhat.com> <20180320142756-mutt-send-email-mst@kernel.org> <20180320123900.GO4530@redhat.com> <20180320133216.u4hdijttdnyjbfpu@sirius.home.kraxel.org> From: Thomas Huth Message-ID: <6061af99-0c27-e02b-e185-fe1dfca1a96a@redhat.com> Date: Tue, 20 Mar 2018 14:46:46 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <20180320133216.u4hdijttdnyjbfpu@sirius.home.kraxel.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.2]); Tue, 20 Mar 2018 13:47:06 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.2]); Tue, 20 Mar 2018 13:47:06 +0000 (UTC) for IP:'10.11.54.6' DOMAIN:'int-mx06.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'thuth@redhat.com' RCPT:'' X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 66.187.233.73 X-Mailman-Approved-At: Tue, 20 Mar 2018 09:59:16 -0400 Subject: Re: [Qemu-arm] [PATCH] qemu: include generated files with <> and not "" X-BeenThere: qemu-arm@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Dmitry Fleytman , sheepdog@lists.wpkg.org, Ronnie Sahlberg , Li Zhijian , "Michael S. Tsirkin" , Jeff Cody , Zhang Chen , Mark Cave-Ayland , qemu-devel@nongnu.org, "Richard W.M. Jones" , Keith Busch , Max Filippov , Jiri Pirko , Subbaraya Sundeep , Eric Blake , Michael Roth , Marcelo Tosatti , Josh Durgin , Stefano Stabellini , Alberto Garcia , zhanghailiang , Ben Warren , Marcel Apfelbaum , Yongbok Kim , David Hildenbrand , Markus Armbruster , Stefan Berger , Christian Borntraeger , kvm@vger.kernel.org, =?UTF-8?Q?Herv=c3=a9_Poussineau?= , Shannon Zhao , Anthony Perard , Liu Yuan , David Gibson , Andrzej Zaborowski , Jason Wang , Artyom Tarasenko , Riku Voipio , Fam Zheng , Eduardo Habkost , Corey Minyard , Amit Shah , Pavel Dovgalyuk , Stefan Weil , Xie Changlong , Alistair Francis , Peter Lieven , "Dr. David Alan Gilbert" , Fabien Chouteau , Greg Kurz , =?UTF-8?Q?Marc-Andr=c3=a9_Lureau?= , Alex Williamson , qemu-arm@nongnu.org, Peter Chubb , Yuval Shaia , Stefan Hajnoczi , Paolo Bonzini , xen-devel@lists.xenproject.org, BALATON Zoltan , John Snow , Richard Henderson , Kevin Wolf , Alexander Graf , qemu-block@nongnu.org, Hitoshi Mitake , Wen Congyang , qemu-s390x@nongnu.org, Cornelia Huck , Laurent Vivier , Juan Quintela , Max Reitz , Michael Walle , qemu-ppc@nongnu.org, =?UTF-8?Q?Andreas_F=c3=a4rber?= , Igor Mammedov , Hannes Reinecke , Aurelien Jarno , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Errors-To: qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org Sender: "Qemu-arm" X-TUID: 8p7yCysyAONy On 20.03.2018 14:32, Gerd Hoffmann wrote: > Hi, > >>> So for these, we should use "". None of these are generated files though. >> >> That leads to crazy inconsistent message for developers where 50% of QEMU >> header files must use <> and the other 50% of header files must use "". > > The rules are pretty simple though: > > (1) Headers which are generated use <>. > (2) Headers which are in include/ use <>. > (3) Headers sitting in the same directory as the source files use "". Ugh, no. Please don't. The normal way of including header files in QEMU is to use "" - also for headers that are not in the same directory. For example just do a grep -r '^#include.*hw/' hw/ from the top directory and you'll see what I mean. Changing that rule is crazy. So please, let's just fix the configure script to detect some more stale files in the source tree, and we're done. Thomas From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Huth Subject: Re: [PATCH] qemu: include generated files with <> and not "" Date: Tue, 20 Mar 2018 14:46:46 +0100 Message-ID: <6061af99-0c27-e02b-e185-fe1dfca1a96a@redhat.com> References: <1521510562-529051-1-git-send-email-mst@redhat.com> <8f06e1e3-4823-d8e8-43bd-c092c523849e@vivier.eu> <20180320094406.GD4530@redhat.com> <20180320141107-mutt-send-email-mst@kernel.org> <20180320121841.GN4530@redhat.com> <20180320142756-mutt-send-email-mst@kernel.org> <20180320123900.GO4530@redhat.com> <20180320133216.u4hdijttdnyjbfpu@sirius.home.kraxel.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1eyHbX-0001sb-MR for xen-devel@lists.xenproject.org; Tue, 20 Mar 2018 13:47:07 +0000 In-Reply-To: <20180320133216.u4hdijttdnyjbfpu@sirius.home.kraxel.org> Content-Language: en-US List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: Gerd Hoffmann , "=?UTF-8?Q?Daniel_P._Berrang=c3=a9?=" Cc: Peter Maydell , Dmitry Fleytman , sheepdog@lists.wpkg.org, Ronnie Sahlberg , Li Zhijian , "Michael S. Tsirkin" , Jeff Cody , Zhang Chen , Mark Cave-Ayland , qemu-devel@nongnu.org, "Richard W.M. Jones" , Keith Busch , Max Filippov , "Edgar E. Iglesias" , Jiri Pirko , Subbaraya Sundeep , Eric Blake , Michael Roth , Marcelo Tosatti , Josh Durgin , Stefano Stabellini , Alberto Garcia , zhanghailiang List-Id: xen-devel@lists.xenproject.org T24gMjAuMDMuMjAxOCAxNDozMiwgR2VyZCBIb2ZmbWFubiB3cm90ZToKPiAgIEhpLAo+IAo+Pj4g U28gZm9yIHRoZXNlLCB3ZSBzaG91bGQgdXNlICIiLiAgTm9uZSBvZiB0aGVzZSBhcmUgZ2VuZXJh dGVkIGZpbGVzIHRob3VnaC4KPj4KPj4gVGhhdCBsZWFkcyB0byBjcmF6eSBpbmNvbnNpc3RlbnQg bWVzc2FnZSBmb3IgZGV2ZWxvcGVycyB3aGVyZSA1MCUgb2YgUUVNVQo+PiBoZWFkZXIgZmlsZXMg bXVzdCB1c2UgPD4gYW5kIHRoZSBvdGhlciA1MCUgb2YgaGVhZGVyIGZpbGVzIG11c3QgdXNlICIi Lgo+IAo+IFRoZSBydWxlcyBhcmUgcHJldHR5IHNpbXBsZSB0aG91Z2g6Cj4gCj4gICAgKDEpIEhl YWRlcnMgd2hpY2ggYXJlIGdlbmVyYXRlZCB1c2UgPD4uCj4gICAgKDIpIEhlYWRlcnMgd2hpY2gg YXJlIGluIGluY2x1ZGUvIHVzZSA8Pi4KPiAgICAoMykgSGVhZGVycyBzaXR0aW5nIGluIHRoZSBz YW1lIGRpcmVjdG9yeSBhcyB0aGUgc291cmNlIGZpbGVzIHVzZSAiIi4KClVnaCwgbm8uIFBsZWFz ZSBkb24ndC4gVGhlIG5vcm1hbCB3YXkgb2YgaW5jbHVkaW5nIGhlYWRlciBmaWxlcyBpbiBRRU1V CmlzIHRvIHVzZSAiIiAtIGFsc28gZm9yIGhlYWRlcnMgdGhhdCBhcmUgbm90IGluIHRoZSBzYW1l IGRpcmVjdG9yeS4gRm9yCmV4YW1wbGUganVzdCBkbyBhCgogZ3JlcCAtciAnXiNpbmNsdWRlLipo dy8nIGh3LwoKZnJvbSB0aGUgdG9wIGRpcmVjdG9yeSBhbmQgeW91J2xsIHNlZSB3aGF0IEkgbWVh bi4gQ2hhbmdpbmcgdGhhdCBydWxlIGlzCmNyYXp5LiBTbyBwbGVhc2UsIGxldCdzIGp1c3QgZml4 IHRoZSBjb25maWd1cmUgc2NyaXB0IHRvIGRldGVjdCBzb21lCm1vcmUgc3RhbGUgZmlsZXMgaW4g dGhlIHNvdXJjZSB0cmVlLCBhbmQgd2UncmUgZG9uZS4KCiBUaG9tYXMKCl9fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fClhlbi1kZXZlbCBtYWlsaW5nIGxpc3QK WGVuLWRldmVsQGxpc3RzLnhlbnByb2plY3Qub3JnCmh0dHBzOi8vbGlzdHMueGVucHJvamVjdC5v cmcvbWFpbG1hbi9saXN0aW5mby94ZW4tZGV2ZWw= From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Huth Subject: Re: [PATCH] qemu: include generated files with <> and not "" Date: Tue, 20 Mar 2018 14:46:46 +0100 Message-ID: <6061af99-0c27-e02b-e185-fe1dfca1a96a@redhat.com> References: <1521510562-529051-1-git-send-email-mst@redhat.com> <8f06e1e3-4823-d8e8-43bd-c092c523849e@vivier.eu> <20180320094406.GD4530@redhat.com> <20180320141107-mutt-send-email-mst@kernel.org> <20180320121841.GN4530@redhat.com> <20180320142756-mutt-send-email-mst@kernel.org> <20180320123900.GO4530@redhat.com> <20180320133216.u4hdijttdnyjbfpu@sirius.home.kraxel.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Cc: Peter Maydell , Dmitry Fleytman , sheepdog@lists.wpkg.org, Ronnie Sahlberg , Li Zhijian , "Michael S. Tsirkin" , Jeff Cody , Zhang Chen , Mark Cave-Ayland , qemu-devel@nongnu.org, "Richard W.M. Jones" , Keith Busch , Max Filippov , "Edgar E. Iglesias" , Jiri Pirko , Subbaraya Sundeep , Eric Blake , Michael Roth , Marcelo Tosatti , Josh Durgin , Stefano Stabellini , Alberto Garcia , zhanghailiang , To: Gerd Hoffmann , =?UTF-8?Q?Daniel_P._Berrang=c3=a9?= Return-path: In-Reply-To: <20180320133216.u4hdijttdnyjbfpu@sirius.home.kraxel.org> Content-Language: en-US List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" List-Id: kvm.vger.kernel.org T24gMjAuMDMuMjAxOCAxNDozMiwgR2VyZCBIb2ZmbWFubiB3cm90ZToKPiAgIEhpLAo+IAo+Pj4g U28gZm9yIHRoZXNlLCB3ZSBzaG91bGQgdXNlICIiLiAgTm9uZSBvZiB0aGVzZSBhcmUgZ2VuZXJh dGVkIGZpbGVzIHRob3VnaC4KPj4KPj4gVGhhdCBsZWFkcyB0byBjcmF6eSBpbmNvbnNpc3RlbnQg bWVzc2FnZSBmb3IgZGV2ZWxvcGVycyB3aGVyZSA1MCUgb2YgUUVNVQo+PiBoZWFkZXIgZmlsZXMg bXVzdCB1c2UgPD4gYW5kIHRoZSBvdGhlciA1MCUgb2YgaGVhZGVyIGZpbGVzIG11c3QgdXNlICIi Lgo+IAo+IFRoZSBydWxlcyBhcmUgcHJldHR5IHNpbXBsZSB0aG91Z2g6Cj4gCj4gICAgKDEpIEhl YWRlcnMgd2hpY2ggYXJlIGdlbmVyYXRlZCB1c2UgPD4uCj4gICAgKDIpIEhlYWRlcnMgd2hpY2gg YXJlIGluIGluY2x1ZGUvIHVzZSA8Pi4KPiAgICAoMykgSGVhZGVycyBzaXR0aW5nIGluIHRoZSBz YW1lIGRpcmVjdG9yeSBhcyB0aGUgc291cmNlIGZpbGVzIHVzZSAiIi4KClVnaCwgbm8uIFBsZWFz ZSBkb24ndC4gVGhlIG5vcm1hbCB3YXkgb2YgaW5jbHVkaW5nIGhlYWRlciBmaWxlcyBpbiBRRU1V CmlzIHRvIHVzZSAiIiAtIGFsc28gZm9yIGhlYWRlcnMgdGhhdCBhcmUgbm90IGluIHRoZSBzYW1l IGRpcmVjdG9yeS4gRm9yCmV4YW1wbGUganVzdCBkbyBhCgogZ3JlcCAtciAnXiNpbmNsdWRlLipo dy8nIGh3LwoKZnJvbSB0aGUgdG9wIGRpcmVjdG9yeSBhbmQgeW91J2xsIHNlZSB3aGF0IEkgbWVh bi4gQ2hhbmdpbmcgdGhhdCBydWxlIGlzCmNyYXp5LiBTbyBwbGVhc2UsIGxldCdzIGp1c3QgZml4 IHRoZSBjb25maWd1cmUgc2NyaXB0IHRvIGRldGVjdCBzb21lCm1vcmUgc3RhbGUgZmlsZXMgaW4g dGhlIHNvdXJjZSB0cmVlLCBhbmQgd2UncmUgZG9uZS4KCiBUaG9tYXMKCl9fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fClhlbi1kZXZlbCBtYWlsaW5nIGxpc3QK WGVuLWRldmVsQGxpc3RzLnhlbnByb2plY3Qub3JnCmh0dHBzOi8vbGlzdHMueGVucHJvamVjdC5v cmcvbWFpbG1hbi9saXN0aW5mby94ZW4tZGV2ZWw=