From: Thomas Monjalon <thomas@monjalon.net>
To: Gaetan Rivet <grive@u256.net>
Cc: dev@dpdk.org, Neil Horman <nhorman@tuxdriver.com>,
"Mcnamara, John" <john.mcnamara@intel.com>,
Marko Kovacevic <marko.kovacevic@intel.com>,
Ray Kinsella <mdr@ashroe.eu>
Subject: Re: [dpdk-dev] [PATCH v1] doc: fix typos and errors in abi policy doc
Date: Tue, 19 May 2020 11:46:06 +0200 [thread overview]
Message-ID: <6069387.c0te8JeNC1@thomas> (raw)
In-Reply-To: <ddae2efe-ffcd-c393-cb94-218205bddd10@ashroe.eu>
14/05/2020 08:40, Ray Kinsella:
> On 13/05/2020 11:43, Gaetan Rivet wrote:
> > Some errors in the document:
> >
> > * API instead of ABI once.
> >
> > Some typos:
> >
> > * __rte_depreciated instead of __rte_deprecated.
> > * missing ```` around value.
> > * inconsistent reference to major ABI version, most
> > of the time described without the minor appended, except once.
> >
> > Verbosity and grammar:
> >
> > * Long sentences that would be better cut short.
> > * Comma abuse.
> > * 'May' used where 'can' seems more fitting.
> >
> > I'm not a native speaker though, so grain of salt applies.
> >
> > Fixes: fdf7471cccb8 ("doc: introduce major ABI versions")
> > Cc: Ray Kinsella <mdr@ashroe.eu>
> > cc: Neil Horman <nhorman@tuxdriver.com>
> > Signed-off-by: Gaetan Rivet <grive@u256.net>
>
> Acked-by: Ray Kinsella <mdr@ashroe.eu>
Applied, thanks
prev parent reply other threads:[~2020-05-19 9:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-13 10:43 [dpdk-dev] [PATCH v1] doc: fix typos and errors in abi policy doc Gaetan Rivet
2020-05-14 6:40 ` Ray Kinsella
2020-05-19 9:46 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6069387.c0te8JeNC1@thomas \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=grive@u256.net \
--cc=john.mcnamara@intel.com \
--cc=marko.kovacevic@intel.com \
--cc=mdr@ashroe.eu \
--cc=nhorman@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.