From: Paolo Abeni <pabeni@redhat.com>
To: Alice Mikityanska <alice@isovalent.com>,
Matthieu Baerts <matttbe@kernel.org>
Cc: Alice Mikityanska <alice.kernel@fastmail.im>,
Jakub Kicinski <kuba@kernel.org>,
Eric Dumazet <edumazet@google.com>,
"David S. Miller" <davem@davemloft.net>,
Simon Horman <horms@kernel.org>, Shuah Khan <shuah@kernel.org>,
netdev@vger.kernel.org, linux-kselftest@vger.kernel.org
Subject: Re: [PATCH net-next] selftests: net: Add a missing config option
Date: Thu, 30 Jul 2026 09:46:01 +0200 [thread overview]
Message-ID: <606acc01-e22d-4e69-ad26-a8afff262b98@redhat.com> (raw)
In-Reply-To: <CAD0BsJVqmQRz1yNKMMWH1MT+kgVEh=wY=LOTy_ObeTDCsrhHFg@mail.gmail.com>
On 7/29/26 10:44 PM, Alice Mikityanska wrote:
> On Mon, 27 Jul 2026 at 12:09, Matthieu Baerts <matttbe@kernel.org> wrote:
>> On 23/07/2026 16:02, Alice Mikityanska wrote:
>>> From: Alice Mikityanska <alice@isovalent.com>
>>>
>>> Commit 5cb53743e1ff ("selftests: net: Add a test for BIG TCP in UDP
>>> tunnels") used iptables match comment, which was missed from the CI
>>> kernel config. Add the missing config option.
>>
>> It helps, the CI can now run this test!
>>
>> Reviewed-by: Matthieu Baerts <matttbe@kernel.org>
>>
>>
>> But I think another follow-up patch is required, because this test is
>> flaky when using a debug kernel config:
>>
>>
>> https://netdev.bots.linux.dev/flakes.html?min-flip=0&tn-needle=big-tcp-tunnels-sh
>>
>> Maybe because wait_local_port_listen() is required after having called
>> netserver?
>
> The issue is hard to reproduce on my machine, but I could reproduce it
> in ~12 hours of non-stop testing in a loop. It reproduces even with
> wait_local_port_listen, so it must be something else. The log above
> (and my repro attempts) shows that it fails in a non-first test, but
> netserver starts only once, before the first test. If the failure was
> due to netserver not being ready, it would fail in the first test.
> I'll keep investigating.
I *think* this kind of flakes are sort of expected for 'performance'
related tests when running on debug kernel: the environment can be
painful slow, and few failed iterations I saw has csum offload disabled
- even lower expected tput.
AFAICS the target packet number is independent from KSFT_MACHINE_SLOW
and the actual offload setting. Possibly you can tune the target value a
bit WRT the mentioned variables or skip entirely pkts number validation
in the slowest permutation (note that the self-test will still have some
value due to code coverage with sanitizers enabled).
/p
next prev parent reply other threads:[~2026-07-30 7:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-23 14:02 [PATCH net-next] selftests: net: Add a missing config option Alice Mikityanska
2026-07-27 9:09 ` Matthieu Baerts
2026-07-29 20:44 ` Alice Mikityanska
2026-07-30 7:46 ` Paolo Abeni [this message]
2026-07-28 1:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=606acc01-e22d-4e69-ad26-a8afff262b98@redhat.com \
--to=pabeni@redhat.com \
--cc=alice.kernel@fastmail.im \
--cc=alice@isovalent.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=matttbe@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.