From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?Christian_K=c3=b6nig?= Subject: Re: [PATCH v2] drm/amdgpu: Add sysfs entries for xgmi hive. Date: Wed, 6 Mar 2019 09:05:39 +0100 Message-ID: <606dac4c-abef-97ec-e489-e952d6ce50b0@gmail.com> References: <1551814232-12565-1-git-send-email-andrey.grodzovsky@amd.com> Reply-To: christian.koenig-5C7GfCeVMHo@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1551814232-12565-1-git-send-email-andrey.grodzovsky-5C7GfCeVMHo@public.gmane.org> Content-Language: en-US List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: Andrey Grodzovsky , amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Cc: Alexander.Deucher-5C7GfCeVMHo@public.gmane.org, Tom.StDenis-5C7GfCeVMHo@public.gmane.org, zhoucm1-5C7GfCeVMHo@public.gmane.org, Christian.Koenig-5C7GfCeVMHo@public.gmane.org QW0gMDUuMDMuMTkgdW0gMjA6MzAgc2NocmllYiBBbmRyZXkgR3JvZHpvdnNreToKPiBGb3IgZWFj aCBkZXZpY2UgYSBmaWxlIHhnbWlfZGV2aWNlX2lkIGlzIGNyZWF0ZWQuCj4gT24gdGhlIGZpcnN0 IGRldmljZSBhIHN1YmRpcmVjdG9yeSBuYW1lZCB4Z21pX2hpdmVfaW5mbyBpcyBjcmVhdGVkLAo+ IEl0IGNvbnRhaW5zICBhIGZpbGUgbmFtZWQgaGl2ZV9pZCBhbmQgc3ltbGlua3MgbmFtZWQgbm9k ZSAxLTQgbGlua2luZwo+IHRvIGVhY2ggZGV2aWNlIGluIHRoZSBoaXZlLgo+Cj4gdjI6IFJldHVy biBlcnJvciBjb2RlcyBpbnN0ZWFkIG9mICctMScgYW5kIGZldyBtaXNzcGVsbGluZ3MuCj4KPiBT aWduZWQtb2ZmLWJ5OiBBbmRyZXkgR3JvZHpvdnNreSA8YW5kcmV5Lmdyb2R6b3Zza3lAYW1kLmNv bT4KClJldmlld2VkLWJ5OiBDaHJpc3RpYW4gS8O2bmlnIDxjaHJpc3RpYW4ua29lbmlnQGFtZC5j b20+Cgo+IC0tLQo+ICAgZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X3hnbWkuYyB8 IDE0NSArKysrKysrKysrKysrKysrKysrKysrKysrKysrKystCj4gICBkcml2ZXJzL2dwdS9kcm0v YW1kL2FtZGdwdS9hbWRncHVfeGdtaS5oIHwgICA2ICstCj4gICAyIGZpbGVzIGNoYW5nZWQsIDE0 NiBpbnNlcnRpb25zKCspLCA1IGRlbGV0aW9ucygtKQo+Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMv Z3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV94Z21pLmMgYi9kcml2ZXJzL2dwdS9kcm0vYW1kL2Ft ZGdwdS9hbWRncHVfeGdtaS5jCj4gaW5kZXggNDA3ZGQxNmMuLmZjYzRiMDUgMTAwNjQ0Cj4gLS0t IGEvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X3hnbWkuYwo+ICsrKyBiL2RyaXZl cnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV94Z21pLmMKPiBAQCAtMzQsMTIgKzM0LDEzMiBA QCBzdGF0aWMgREVGSU5FX01VVEVYKHhnbWlfbXV0ZXgpOwo+ICAgc3RhdGljIHN0cnVjdCBhbWRn cHVfaGl2ZV9pbmZvIHhnbWlfaGl2ZXNbQU1ER1BVX01BWF9YR01JX0hJVkVdOwo+ICAgc3RhdGlj IHVuc2lnbmVkIGhpdmVfY291bnQgPSAwOwo+ICAgCj4gLQo+ICAgdm9pZCAqYW1kZ3B1X3hnbWlf aGl2ZV90cnlfbG9jayhzdHJ1Y3QgYW1kZ3B1X2hpdmVfaW5mbyAqaGl2ZSkKPiAgIHsKPiAgIAly ZXR1cm4gJmhpdmUtPmRldmljZV9saXN0Owo+ICAgfQo+ICAgCj4gK3N0YXRpYyBzc2l6ZV90IGFt ZGdwdV94Z21pX3Nob3dfaGl2ZV9pZChzdHJ1Y3QgZGV2aWNlICpkZXYsCj4gKwkJc3RydWN0IGRl dmljZV9hdHRyaWJ1dGUgKmF0dHIsIGNoYXIgKmJ1ZikKPiArewo+ICsJc3RydWN0IGFtZGdwdV9o aXZlX2luZm8gKmhpdmUgPQo+ICsJCQljb250YWluZXJfb2YoYXR0ciwgc3RydWN0IGFtZGdwdV9o aXZlX2luZm8sIGRldl9hdHRyKTsKPiArCj4gKwlyZXR1cm4gc25wcmludGYoYnVmLCBQQUdFX1NJ WkUsICIlbGx1XG4iLCBoaXZlLT5oaXZlX2lkKTsKPiArfQo+ICsKPiArc3RhdGljIGludCBhbWRn cHVfeGdtaV9zeXNmc19jcmVhdGUoc3RydWN0IGFtZGdwdV9kZXZpY2UgKmFkZXYsCj4gKwkJCQkg ICAgc3RydWN0IGFtZGdwdV9oaXZlX2luZm8gKmhpdmUpCj4gK3sKPiArCWludCByZXQgPSAwOwo+ ICsKPiArCWlmIChXQVJOX09OKGhpdmUtPmtvYmopKQo+ICsJCXJldHVybiAtRUlOVkFMOwo+ICsK PiArCWhpdmUtPmtvYmogPSBrb2JqZWN0X2NyZWF0ZV9hbmRfYWRkKCJ4Z21pX2hpdmVfaW5mbyIs ICZhZGV2LT5kZXYtPmtvYmopOwo+ICsJaWYgKCFoaXZlLT5rb2JqKSB7Cj4gKwkJZGV2X2Vycihh ZGV2LT5kZXYsICJYR01JOiBGYWlsZWQgdG8gYWxsb2NhdGUgc3lzZnMgZW50cnkhXG4iKTsKPiAr CQlyZXR1cm4gLUVJTlZBTDsKPiArCX0KPiArCj4gKwloaXZlLT5kZXZfYXR0ciA9IChzdHJ1Y3Qg ZGV2aWNlX2F0dHJpYnV0ZSkgewo+ICsJCS5hdHRyID0gewo+ICsJCQkubmFtZSA9ICJ4Z21pX2hp dmVfaWQiLAo+ICsJCQkubW9kZSA9IFNfSVJVR08sCj4gKwo+ICsJCX0sCj4gKwkJLnNob3cgPSBh bWRncHVfeGdtaV9zaG93X2hpdmVfaWQsCj4gKwl9Owo+ICsKPiArCXJldCA9IHN5c2ZzX2NyZWF0 ZV9maWxlKGhpdmUtPmtvYmosICZoaXZlLT5kZXZfYXR0ci5hdHRyKTsKPiArCWlmIChyZXQpIHsK PiArCQlkZXZfZXJyKGFkZXYtPmRldiwgIlhHTUk6IEZhaWxlZCB0byBjcmVhdGUgZGV2aWNlIGZp bGUgeGdtaV9oaXZlX2lkXG4iKTsKPiArCQlrb2JqZWN0X2RlbChoaXZlLT5rb2JqKTsKPiArCQlr b2JqZWN0X3B1dChoaXZlLT5rb2JqKTsKPiArCQloaXZlLT5rb2JqID0gTlVMTDsKPiArCX0KPiAr Cj4gKwlyZXR1cm4gcmV0Owo+ICt9Cj4gKwo+ICtzdGF0aWMgdm9pZCBhbWRncHVfeGdtaV9zeXNm c19kZXN0cm95KHN0cnVjdCBhbWRncHVfZGV2aWNlICphZGV2LAo+ICsJCQkJICAgIHN0cnVjdCBh bWRncHVfaGl2ZV9pbmZvICpoaXZlKQo+ICt7Cj4gKwlzeXNmc19yZW1vdmVfZmlsZShoaXZlLT5r b2JqLCAmaGl2ZS0+ZGV2X2F0dHIuYXR0cik7Cj4gKwlrb2JqZWN0X2RlbChoaXZlLT5rb2JqKTsK PiArCWtvYmplY3RfcHV0KGhpdmUtPmtvYmopOwo+ICsJaGl2ZS0+a29iaiA9IE5VTEw7Cj4gK30K PiArCj4gK3N0YXRpYyBzc2l6ZV90IGFtZGdwdV94Z21pX3Nob3dfZGV2aWNlX2lkKHN0cnVjdCBk ZXZpY2UgKmRldiwKPiArCQkJCSAgICAgc3RydWN0IGRldmljZV9hdHRyaWJ1dGUgKmF0dHIsCj4g KwkJCQkgICAgIGNoYXIgKmJ1ZikKPiArewo+ICsJc3RydWN0IGRybV9kZXZpY2UgKmRkZXYgPSBk ZXZfZ2V0X2RydmRhdGEoZGV2KTsKPiArCXN0cnVjdCBhbWRncHVfZGV2aWNlICphZGV2ID0gZGRl di0+ZGV2X3ByaXZhdGU7Cj4gKwo+ICsJcmV0dXJuIHNucHJpbnRmKGJ1ZiwgUEFHRV9TSVpFLCAi JWxsdVxuIiwgYWRldi0+Z21jLnhnbWkubm9kZV9pZCk7Cj4gKwo+ICt9Cj4gKwo+ICsKPiArc3Rh dGljIERFVklDRV9BVFRSKHhnbWlfZGV2aWNlX2lkLCBTX0lSVUdPLCBhbWRncHVfeGdtaV9zaG93 X2RldmljZV9pZCwgTlVMTCk7Cj4gKwo+ICsKPiArc3RhdGljIGludCBhbWRncHVfeGdtaV9zeXNm c19hZGRfZGV2X2luZm8oc3RydWN0IGFtZGdwdV9kZXZpY2UgKmFkZXYsCj4gKwkJCQkJIHN0cnVj dCBhbWRncHVfaGl2ZV9pbmZvICpoaXZlKQo+ICt7Cj4gKwlpbnQgcmV0ID0gMDsKPiArCWNoYXIg bm9kZVsxMF0gPSB7IDAgfTsKPiArCj4gKwkvKiBDcmVhdGUgeGdtaSBkZXZpY2UgaWQgZmlsZSAq Lwo+ICsJcmV0ID0gZGV2aWNlX2NyZWF0ZV9maWxlKGFkZXYtPmRldiwgJmRldl9hdHRyX3hnbWlf ZGV2aWNlX2lkKTsKPiArCWlmIChyZXQpIHsKPiArCQlkZXZfZXJyKGFkZXYtPmRldiwgIlhHTUk6 IEZhaWxlZCB0byBjcmVhdGUgZGV2aWNlIGZpbGUgeGdtaV9kZXZpY2VfaWRcbiIpOwo+ICsJCXJl dHVybiByZXQ7Cj4gKwl9Cj4gKwo+ICsJLyogQ3JlYXRlIHN5c2ZzIGxpbmsgdG8gaGl2ZSBpbmZv IGZvbGRlciBvbiB0aGUgZmlyc3QgZGV2aWNlICovCj4gKwlpZiAoYWRldiAhPSBoaXZlLT5hZGV2 KSB7Cj4gKwkJcmV0ID0gc3lzZnNfY3JlYXRlX2xpbmsoJmFkZXYtPmRldi0+a29iaiwgaGl2ZS0+ a29iaiwKPiArCQkJCQkieGdtaV9oaXZlX2luZm8iKTsKPiArCQlpZiAocmV0KSB7Cj4gKwkJCWRl dl9lcnIoYWRldi0+ZGV2LCAiWEdNSTogRmFpbGVkIHRvIGNyZWF0ZSBsaW5rIHRvIGhpdmUgaW5m byIpOwo+ICsJCQlnb3RvIHJlbW92ZV9maWxlOwo+ICsJCX0KPiArCX0KPiArCj4gKwlzcHJpbnRm KG5vZGUsICJub2RlJWQiLCBoaXZlLT5udW1iZXJfZGV2aWNlcyk7Cj4gKwkvKiBDcmVhdGUgc3lz ZnMgbGluayBmb3JtIHRoZSBoaXZlIGZvbGRlciB0byB5b3Vyc2VsZiAqLwo+ICsJcmV0ID0gc3lz ZnNfY3JlYXRlX2xpbmsoaGl2ZS0+a29iaiwgJmFkZXYtPmRldi0+a29iaiwgbm9kZSk7Cj4gKwlp ZiAocmV0KSB7Cj4gKwkJZGV2X2VycihhZGV2LT5kZXYsICJYR01JOiBGYWlsZWQgdG8gY3JlYXRl IGxpbmsgZnJvbSBoaXZlIGluZm8iKTsKPiArCQlnb3RvIHJlbW92ZV9saW5rOwo+ICsJfQo+ICsK PiArCWdvdG8gc3VjY2VzczsKPiArCj4gKwo+ICtyZW1vdmVfbGluazoKPiArCXN5c2ZzX3JlbW92 ZV9saW5rKCZhZGV2LT5kZXYtPmtvYmosIGFkZXYtPmRkZXYtPnVuaXF1ZSk7Cj4gKwo+ICtyZW1v dmVfZmlsZToKPiArCWRldmljZV9yZW1vdmVfZmlsZShhZGV2LT5kZXYsICZkZXZfYXR0cl94Z21p X2RldmljZV9pZCk7Cj4gKwo+ICtzdWNjZXNzOgo+ICsJcmV0dXJuIHJldDsKPiArfQo+ICsKPiAr c3RhdGljIHZvaWQgYW1kZ3B1X3hnbWlfc3lzZnNfcmVtX2Rldl9pbmZvKHN0cnVjdCBhbWRncHVf ZGV2aWNlICphZGV2LAo+ICsJCQkJCSAgc3RydWN0IGFtZGdwdV9oaXZlX2luZm8gKmhpdmUpCj4g K3sKPiArCWRldmljZV9yZW1vdmVfZmlsZShhZGV2LT5kZXYsICZkZXZfYXR0cl94Z21pX2Rldmlj ZV9pZCk7Cj4gKwlzeXNmc19yZW1vdmVfbGluaygmYWRldi0+ZGV2LT5rb2JqLCBhZGV2LT5kZGV2 LT51bmlxdWUpOwo+ICsJc3lzZnNfcmVtb3ZlX2xpbmsoaGl2ZS0+a29iaiwgYWRldi0+ZGRldi0+ dW5pcXVlKTsKPiArfQo+ICsKPiArCj4gKwo+ICAgc3RydWN0IGFtZGdwdV9oaXZlX2luZm8gKmFt ZGdwdV9nZXRfeGdtaV9oaXZlKHN0cnVjdCBhbWRncHVfZGV2aWNlICphZGV2LCBpbnQgbG9jaykK PiAgIHsKPiAgIAlpbnQgaTsKPiBAQCAtNjYsMTAgKzE4NiwxOCBAQCBzdHJ1Y3QgYW1kZ3B1X2hp dmVfaW5mbyAqYW1kZ3B1X2dldF94Z21pX2hpdmUoc3RydWN0IGFtZGdwdV9kZXZpY2UgKmFkZXYs IGludCBsbwo+ICAgCj4gICAJLyogaW5pdGlhbGl6ZSBuZXcgaGl2ZSBpZiBub3QgZXhpc3QgKi8K PiAgIAl0bXAgPSAmeGdtaV9oaXZlc1toaXZlX2NvdW50KytdOwo+ICsKPiArCWlmIChhbWRncHVf eGdtaV9zeXNmc19jcmVhdGUoYWRldiwgdG1wKSkgewo+ICsJCW11dGV4X3VubG9jaygmeGdtaV9t dXRleCk7Cj4gKwkJcmV0dXJuIE5VTEw7Cj4gKwl9Cj4gKwo+ICsJdG1wLT5hZGV2ID0gYWRldjsK PiAgIAl0bXAtPmhpdmVfaWQgPSBhZGV2LT5nbWMueGdtaS5oaXZlX2lkOwo+ICAgCUlOSVRfTElT VF9IRUFEKCZ0bXAtPmRldmljZV9saXN0KTsKPiAgIAltdXRleF9pbml0KCZ0bXAtPmhpdmVfbG9j ayk7Cj4gICAJbXV0ZXhfaW5pdCgmdG1wLT5yZXNldF9sb2NrKTsKPiArCj4gICAJaWYgKGxvY2sp Cj4gICAJCW11dGV4X2xvY2soJnRtcC0+aGl2ZV9sb2NrKTsKPiAgIAo+IEBAIC0xNTYsOCArMjg0 LDE3IEBAIGludCBhbWRncHVfeGdtaV9hZGRfZGV2aWNlKHN0cnVjdCBhbWRncHVfZGV2aWNlICph ZGV2KQo+ICAgCQkJYnJlYWs7Cj4gICAJfQo+ICAgCj4gLQlkZXZfaW5mbyhhZGV2LT5kZXYsICJY R01JOiBBZGQgbm9kZSAlZCwgaGl2ZSAweCVsbHguXG4iLAo+IC0JCSBhZGV2LT5nbWMueGdtaS5w aHlzaWNhbF9ub2RlX2lkLCBhZGV2LT5nbWMueGdtaS5oaXZlX2lkKTsKPiArCWlmICghcmV0KQo+ ICsJCXJldCA9IGFtZGdwdV94Z21pX3N5c2ZzX2FkZF9kZXZfaW5mbyhhZGV2LCBoaXZlKTsKPiAr Cj4gKwlpZiAoIXJldCkKPiArCQlkZXZfaW5mbyhhZGV2LT5kZXYsICJYR01JOiBBZGQgbm9kZSAl ZCwgaGl2ZSAweCVsbHguXG4iLAo+ICsJCQkgYWRldi0+Z21jLnhnbWkucGh5c2ljYWxfbm9kZV9p ZCwgYWRldi0+Z21jLnhnbWkuaGl2ZV9pZCk7Cj4gKwllbHNlCj4gKwkJZGV2X2VycihhZGV2LT5k ZXYsICJYR01JOiBGYWlsZWQgdG8gYWRkIG5vZGUgJWQsIGhpdmUgMHglbGx4IHJldDogJWRcbiIs Cj4gKwkJCWFkZXYtPmdtYy54Z21pLnBoeXNpY2FsX25vZGVfaWQsIGFkZXYtPmdtYy54Z21pLmhp dmVfaWQsCj4gKwkJCXJldCk7Cj4gKwo+ICAgCj4gICAJbXV0ZXhfdW5sb2NrKCZoaXZlLT5oaXZl X2xvY2spOwo+ICAgZXhpdDoKPiBAQCAtMTc2LDkgKzMxMywxMSBAQCB2b2lkIGFtZGdwdV94Z21p X3JlbW92ZV9kZXZpY2Uoc3RydWN0IGFtZGdwdV9kZXZpY2UgKmFkZXYpCj4gICAJCXJldHVybjsK PiAgIAo+ICAgCWlmICghKGhpdmUtPm51bWJlcl9kZXZpY2VzLS0pKSB7Cj4gKwkJYW1kZ3B1X3hn bWlfc3lzZnNfZGVzdHJveShhZGV2LCBoaXZlKTsKPiAgIAkJbXV0ZXhfZGVzdHJveSgmaGl2ZS0+ aGl2ZV9sb2NrKTsKPiAgIAkJbXV0ZXhfZGVzdHJveSgmaGl2ZS0+cmVzZXRfbG9jayk7Cj4gICAJ fSBlbHNlIHsKPiArCQlhbWRncHVfeGdtaV9zeXNmc19yZW1fZGV2X2luZm8oYWRldiwgaGl2ZSk7 Cj4gICAJCW11dGV4X3VubG9jaygmaGl2ZS0+aGl2ZV9sb2NrKTsKPiAgIAl9Cj4gICB9Cj4gZGlm ZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV94Z21pLmggYi9kcml2 ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfeGdtaS5oCj4gaW5kZXggMTRiYzYwNi4uMjRh M2IwMyAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfeGdt aS5oCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X3hnbWkuaAo+IEBA IC0yOSw4ICsyOSwxMCBAQCBzdHJ1Y3QgYW1kZ3B1X2hpdmVfaW5mbyB7Cj4gICAJc3RydWN0IGxp c3RfaGVhZAlkZXZpY2VfbGlzdDsKPiAgIAlzdHJ1Y3QgcHNwX3hnbWlfdG9wb2xvZ3lfaW5mbwl0 b3BvbG9neV9pbmZvOwo+ICAgCWludCBudW1iZXJfZGV2aWNlczsKPiAtCXN0cnVjdCBtdXRleCBo aXZlX2xvY2ssCj4gLQkJICAgICByZXNldF9sb2NrOwo+ICsJc3RydWN0IG11dGV4IGhpdmVfbG9j aywgcmVzZXRfbG9jazsKPiArCXN0cnVjdCBrb2JqZWN0ICprb2JqOwo+ICsJc3RydWN0IGRldmlj ZV9hdHRyaWJ1dGUgZGV2X2F0dHI7Cj4gKwlzdHJ1Y3QgYW1kZ3B1X2RldmljZSAqYWRldjsKPiAg IH07Cj4gICAKPiAgIHN0cnVjdCBhbWRncHVfaGl2ZV9pbmZvICphbWRncHVfZ2V0X3hnbWlfaGl2 ZShzdHJ1Y3QgYW1kZ3B1X2RldmljZSAqYWRldiwgaW50IGxvY2spOwoKX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KYW1kLWdmeCBtYWlsaW5nIGxpc3QKYW1k LWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcv bWFpbG1hbi9saXN0aW5mby9hbWQtZ2Z4