Re: [PATCH 1/2] dt-bindings: soc: qcom: qcom,pmic-glink: Document RTC client properties

[Krzysztof Kozlowski <krzk@kernel.org>]

On 20/08/2026 21:23, Kamal Wadhwa wrote:
> On Thu, Aug 06, 2026 at 07:02:44PM -0500, Bjorn Andersson wrote:
>>
>>>
>>> Assisted-by: Claude:claude-sonnet-5
>>> Signed-off-by: Raj Aryan <raryan@qti.qualcomm.com>
>>> Signed-off-by: Kamal Wadhwa <kamal.wadhwa@oss.qualcomm.com>
>>
>> As with the driver, the author/s-o-b chain is wrong.
>>
> 
> Ack. will have it this way
> 
> Assisted-by: Claude:claude-sonnet-5
> Signed-off-by: Kamal Wadhwa <kamal.wadhwa@oss.qualcomm.com>
> Signed-off-by: Raj Aryan <raryan@qti.qualcomm.com>
> Signed-off-by: Kamal Wadhwa <kamal.wadhwa@oss.qualcomm.com>

The original SoB chain was right in such case. You sign only once, so
first one is dropped. And this is what b4 produces.


> 
>>> ---
>>>  Documentation/devicetree/bindings/soc/qcom/qcom,pmic-glink.yaml | 5 +++++
>>>  1 file changed, 5 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,pmic-glink.yaml b/Documentation/devicetree/bindings/soc/qcom/qcom,pmic-glink.yaml
>>> index 16ad4f5698fc..38db1ff473c0 100644
>>> --- a/Documentation/devicetree/bindings/soc/qcom/qcom,pmic-glink.yaml
>>> +++ b/Documentation/devicetree/bindings/soc/qcom/qcom,pmic-glink.yaml
>>> @@ -79,6 +79,11 @@ properties:
>>>        - const: charge_limit_end
>>>        - const: charge_limit_delta
>>>  
>>> +  allow-set-time:
>>> +    $ref: /schemas/types.yaml#/definitions/flag
>>> +    description:
>>> +      Indicates that the setting of RTC time is allowed by the host CPU.
>>
>> What property of the hardware/firmware that this describes would cause
>> you to set or not set this?
>>
>> Also, what would the expected outcome be if I declare that my Hamoa
>> hardware has pmic-glink with allow-set-time?
> 
> Actually Hamoa firmware does not support it yet, so it may get ignored.
> but if the support was present, the writes will cause the system time
> to go bad, which relies on the RTC time elapsed during off state to 
> calculate current system time, incase network is not available.
> 
> this was used on rtc-pm8xxx.c driver as well
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/rtc/rtc-pm8xxx.c?h=v7.2#n622


It's a generic property, so where is it defined?
Why isn't it implied by the compatible?


Best regards,
Krzysztof