Re: [PATCH] tools headers: Update the include/vdso/unaligned.h to sync headers

[Athira Rajeev <atrajeev@linux.ibm.com>]

> On 22 Apr 2025, at 2:41 PM, James Clark <james.clark@linaro.org> wrote:
> 
> 
> 
> On 21/04/2025 4:41 am, Athira Rajeev wrote:
>> To pick up the changes in:
>> commit acea9943271b ("vdso: Address variable shadowing in macros")
>> Addressing this perf tools build warning:
>> diff -u tools/include/vdso/unaligned.h include/vdso/unaligned.h
>> Reported-by: Venkat Rao Bagalkote <venkat88@linux.ibm.com>
>> Signed-off-by: Athira Rajeev <atrajeev@linux.ibm.com>
>> Tested-by: Venkat Rao Bagalkote <venkat88@linux.ibm.com>
>> ---
>>  tools/include/vdso/unaligned.h | 12 ++++++------
>>  1 file changed, 6 insertions(+), 6 deletions(-)
>> diff --git a/tools/include/vdso/unaligned.h b/tools/include/vdso/unaligned.h
>> index eee3d2a4dbe4..ff0c06b6513e 100644
>> --- a/tools/include/vdso/unaligned.h
>> +++ b/tools/include/vdso/unaligned.h
>> @@ -2,14 +2,14 @@
>>  #ifndef __VDSO_UNALIGNED_H
>>  #define __VDSO_UNALIGNED_H
>>  -#define __get_unaligned_t(type, ptr) ({ \
>> - const struct { type x; } __packed *__pptr = (typeof(__pptr))(ptr); \
>> - __pptr->x; \
>> +#define __get_unaligned_t(type, ptr) ({ \
>> + const struct { type x; } __packed * __get_pptr = (typeof(__get_pptr))(ptr); \
>> + __get_pptr->x; \
>>  })
>>  -#define __put_unaligned_t(type, val, ptr) do { \
>> - struct { type x; } __packed *__pptr = (typeof(__pptr))(ptr); \
>> - __pptr->x = (val); \
>> +#define __put_unaligned_t(type, val, ptr) do { \
>> + struct { type x; } __packed * __put_pptr = (typeof(__put_pptr))(ptr); \
>> + __put_pptr->x = (val); \
>>  } while (0)
>>    #endif /* __VDSO_UNALIGNED_H */
> 
> Reviewed-by: James Clark <james.clark@linaro.org>

Hi, 

Looking for feedback on this change.

Thanks
Athira