From: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Andy Lutomirski <luto@amacapital.net>,
"H. Peter Anvin" <hpa@zytor.com>,
Andi Kleen <andi@firstfloor.org>, Ingo Molnar <mingo@redhat.com>,
Borislav Petkov <bp@alien8.de>,
libc-alpha <libc-alpha@sourceware.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
carlos <carlos@redhat.com>, x86 <x86@kernel.org>
Subject: Re: rseq/x86: choosing rseq code signature
Date: Wed, 10 Apr 2019 11:47:40 -0400 (EDT) [thread overview]
Message-ID: <608558890.3157.1554911260089.JavaMail.zimbra@efficios.com> (raw)
In-Reply-To: <20190410065417.GU11158@hirez.programming.kicks-ass.net>
----- On Apr 10, 2019, at 2:54 AM, Peter Zijlstra peterz@infradead.org wrote:
> On Tue, Apr 09, 2019 at 04:43:42PM -0400, Mathieu Desnoyers wrote:
>> +/*
>> + * RSEQ_SIG is used with the following privileged instructions, which trap in
>> user-space:
>> + * x86-32: 0f 01 3d 53 30 05 53 invlpg 0x53053053
>> + * x86-64: 0f 01 3d 53 30 05 53 invlpg 0x53053053(%rip)
>> + */
>
> Right, and the alternative is: 0f b9 3d $SIG, which decodes to:
>
> UD1 $SIG(%rip),%edi
>
> which will trap unconditionally. The only problem is that gas will not
> actually assemble it, but since we're .byte coding it, it doesn't
> matter.
>
> UD1 is specified by both AMD and Intel to take a ModR/M, unlike UD0
> where they disagree on the ModR/M.
UD1 is even better from a code emulator perspective. It won't have to
try to emulate invlpg if it sees it.
Byte coding UD1 as your example above gives the following objdump output,
is it expected ?
objdump --version
GNU objdump (GNU Binutils for Debian) 2.28
x86-32:
14: 0f b9 ud1
16: 3d 53 30 05 53 cmp $0x53053053,%eax
x86-64:
b: 0f b9 ud1
d: 3d 53 30 05 53 cmp $0x53053053,%eax
Thanks!
Mathieu
--
Mathieu Desnoyers
EfficiOS Inc.
http://www.efficios.com
next prev parent reply other threads:[~2019-04-10 15:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-09 19:32 rseq/x86: choosing rseq code signature Mathieu Desnoyers
2019-04-09 20:43 ` Mathieu Desnoyers
2019-04-10 0:50 ` Zack Weinberg
2019-04-10 1:57 ` Andy Lutomirski
2019-04-10 4:19 ` Mathieu Desnoyers
2019-04-10 6:54 ` Peter Zijlstra
2019-04-10 15:47 ` Mathieu Desnoyers [this message]
2019-04-10 17:57 ` Peter Zijlstra
2019-04-10 18:05 ` Mathieu Desnoyers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=608558890.3157.1554911260089.JavaMail.zimbra@efficios.com \
--to=mathieu.desnoyers@efficios.com \
--cc=andi@firstfloor.org \
--cc=bp@alien8.de \
--cc=carlos@redhat.com \
--cc=hpa@zytor.com \
--cc=libc-alpha@sourceware.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.