From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] devtools: make log checking script BSD-compatible Date: Mon, 27 Mar 2017 23:45:01 +0200 Message-ID: <6088978.UBRGF4N90V@xps13> References: <20170323150926.16818-1-bruce.richardson@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org To: Bruce Richardson Return-path: Received: from mail-wr0-f171.google.com (mail-wr0-f171.google.com [209.85.128.171]) by dpdk.org (Postfix) with ESMTP id 3E52B101B for ; Mon, 27 Mar 2017 23:45:04 +0200 (CEST) Received: by mail-wr0-f171.google.com with SMTP id w43so63773019wrb.0 for ; Mon, 27 Mar 2017 14:45:04 -0700 (PDT) In-Reply-To: <20170323150926.16818-1-bruce.richardson@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2017-03-23 15:09, Bruce Richardson: > The -e flag to readlink doesn't exist on FreeBSD so change it to -f instead > which is present on both BSD and Linux. Error reported is: > > readlink: illegal option -- e > usage: readlink [-fn] [file ...] > usage: dirname string [...] > ./devtools/check-git-log.sh: /git-log-fixes.sh: not found > > Fixes: 814c8822ef7b ("scripts: check cc stable mailing list in commit") > > Signed-off-by: Bruce Richardson [...] > -selfdir=$(dirname $(readlink -e $0)) > +selfdir=$(dirname $(readlink -f $0)) You win the prize of the shortest fix with only one letter! :) Applied, thanks