From: Allan Sandfeld Jensen <kde@carewolf.com>
To: Benjamin Tissoires <bentiss@kernel.org>,
Hans de Goede <hdegoede@redhat.com>,
linux-kernel@vger.kernel.org
Cc: benjamin.tissoires@redhat.com, linux-input@vger.kernel.org
Subject: Re: [PATCH] Logitech Anywhere 3SB support
Date: Wed, 24 Apr 2024 13:30:11 +0200 [thread overview]
Message-ID: <6092750.lOV4Wx5bFT@twilight> (raw)
In-Reply-To: <fe2980e3-3204-4572-9c7c-1e960727e1d4@redhat.com>
On Monday 15 April 2024 20:31:14 CEST Hans de Goede wrote:
> Hi,
>
> On 4/15/24 5:54 PM, Benjamin Tissoires wrote:
> > [Ccing Hans as well for input]
> >
> > On Apr 13 2024, kde@carewolf.com wrote:
> >> From: Allan Sandfeld Jensen <allan.jensen@qt.io>
> >
> > FWIW, this patch neesd a commit description and signed-offs
> >
Will add.
>
> FWIW I'm also not in favor of stretching drivers/hid/hid-logitech-dj.c
> even further to also support the new bolt stuff.
>
> AFAIK the new bolt stuff is significantly different.
>
> Allan, I see in your other reply that you are mainly after
> highres scrolling and since the bolt receiver does not do
> per paired device addressing I wonder if you cannot just
> get that by treating the bolt receiver as a wired HIDPP
> device and just directly listing it as such in
> hid-logitech-hidpp.c ?
>
> The whole purpose of hid-logitech-dj.c is to create 1 virtual
> hidpp devices per paired device and with bolt that is not
> possible, so I think that we should circumvent hid-logitech-dj.c
> for bolt and if we want to use any hidpp features do so
> by directly listing the receivers in hid-logitech-hidpp.c .
>
I think the bolt receiver is able to separate devices, but yes, it appears the
way it transmits device IDs and pairs has changed (some new registers it looks
like). I am removing this part of the patch. I am not adding the Bolt receiver
to hid-logitech-hidpp.c either though, because it doesnt work for me, and I
havent invested time yet to figure out what would be needed to get it to work.
I will transmit a patch with just the new bluetooth ID, and add a few more I
managed to find to fill out hid-logitech-hidpp.c
Best regards
Allan Sandfeld Jensen
prev parent reply other threads:[~2024-04-24 11:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-13 9:54 [PATCH] Logitech Anywhere 3SB support kde
2024-04-15 15:54 ` Benjamin Tissoires
2024-04-15 16:36 ` Allan Sandfeld Jensen
2024-04-15 18:31 ` Hans de Goede
2024-04-24 11:30 ` Allan Sandfeld Jensen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6092750.lOV4Wx5bFT@twilight \
--to=kde@carewolf.com \
--cc=benjamin.tissoires@redhat.com \
--cc=bentiss@kernel.org \
--cc=hdegoede@redhat.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.