From: Thomas Monjalon <thomas@monjalon.net>
To: "Wang, Xiao W" <xiao.w.wang@intel.com>
Cc: Hemant Agrawal <hemant.agrawal@nxp.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"Burakov, Anatoly" <anatoly.burakov@intel.com>
Subject: Re: [PATCH v5 2/2] eal/vfio: export internal vfio functions
Date: Thu, 05 Apr 2018 12:22:42 +0200 [thread overview]
Message-ID: <60929980.gmd1JhcyUE@xps> (raw)
In-Reply-To: <B7F2E978279D1D49A3034B7786DACF406F86D36D@SHSMSX101.ccr.corp.intel.com>
05/04/2018 11:03, Wang, Xiao W:
> > +int rte_vfio_get_group_num(const char *sysfs_base, const char *dev_addr,
> > + int *iommu_group_num);
> > +int rte_vfio_get_container_fd(void);
> > +int rte_vfio_get_group_fd(int iommu_group_num);
>
> Considering the "group_no" field defined in eal_vfio.h, will "iommu_group_num" cause inconsistency
> In naming?
I asked to change the function name to "num" because it is more meaningful.
"group_no" field is private? Can it be renamed?
next prev parent reply other threads:[~2018-04-05 10:22 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-14 8:00 [PATCH] eal/vfio: export internal vfio functions Hemant Agrawal
2018-03-14 10:19 ` Burakov, Anatoly
2018-03-27 15:53 ` Thomas Monjalon
2018-04-03 6:27 ` Hemant Agrawal
2018-04-03 7:34 ` Thomas Monjalon
2018-04-03 8:34 ` Hemant Agrawal
2018-04-02 8:36 ` [PATCH v2] " Hemant Agrawal
2018-04-02 16:41 ` Thomas Monjalon
2018-04-03 8:28 ` [PATCH v3 1/2] doc: add vfio api support Hemant Agrawal
2018-04-03 8:28 ` [PATCH v3 2/2] eal/vfio: export internal vfio functions Hemant Agrawal
2018-04-03 10:16 ` [PATCH v3 1/2] doc: add vfio api support Thomas Monjalon
2018-04-03 11:10 ` [PATCH v4 " Hemant Agrawal
2018-04-03 11:10 ` [PATCH v4 2/2] eal/vfio: export internal vfio functions Hemant Agrawal
2018-04-03 12:24 ` Thomas Monjalon
2018-04-03 12:59 ` Hemant Agrawal
2018-04-03 15:23 ` Wang, Xiao W
2018-04-04 6:47 ` Hemant Agrawal
2018-04-04 7:48 ` [PATCH v5 1/2] doc: add vfio api support Hemant Agrawal
2018-04-04 7:48 ` [PATCH v5 2/2] eal/vfio: export internal vfio functions Hemant Agrawal
2018-04-05 9:03 ` Wang, Xiao W
2018-04-05 10:22 ` Thomas Monjalon [this message]
2018-04-05 10:35 ` Wang, Xiao W
2018-04-11 21:25 ` Thomas Monjalon
2018-04-12 6:26 ` Hemant Agrawal
2018-04-12 6:23 ` [PATCH v6 1/2] doc: add vfio api support Hemant Agrawal
2018-04-12 6:23 ` [PATCH v6 2/2] eal/vfio: export internal vfio functions Hemant Agrawal
2018-04-12 23:09 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=60929980.gmd1JhcyUE@xps \
--to=thomas@monjalon.net \
--cc=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
--cc=hemant.agrawal@nxp.com \
--cc=xiao.w.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.