From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Rosin Subject: Re: [PATCH v2] i2c: mux: fix up dependencies Date: Mon, 14 Nov 2016 15:39:54 +0100 Message-ID: <6094de61-8745-fbff-e516-db95392aa142@axentia.se> References: <1479134057-30653-1-git-send-email-linus.walleij@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-db5eur01on0093.outbound.protection.outlook.com ([104.47.2.93]:56951 "EHLO EUR01-DB5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932899AbcKNSP3 (ORCPT ); Mon, 14 Nov 2016 13:15:29 -0500 In-Reply-To: <1479134057-30653-1-git-send-email-linus.walleij@linaro.org> Sender: linux-i2c-owner@vger.kernel.org List-Id: linux-i2c@vger.kernel.org To: Linus Walleij , Wolfram Sang , linux-i2c@vger.kernel.org Cc: stable@vger.kernel.org, Jonathan Cameron On 2016-11-14 15:34, Linus Walleij wrote: > We get the following build error from UM Linux after adding > an entry to drivers/iio/gyro/Kconfig that issues "select I2C_MUX": > > ERROR: "devm_ioremap_resource" > [drivers/i2c/muxes/i2c-mux-reg.ko] undefined! > ERROR: "of_address_to_resource" > [drivers/i2c/muxes/i2c-mux-reg.ko] undefined! > > It appears that the I2C mux core code depends on HAS_IOMEM > for historical reasons, while CONFIG_I2C_MUX_REG does *not* > have a direct dependency on HAS_IOMEM. > > This creates a situation where a allyesconfig or allmodconfig > for UM Linux will select I2C_MUX, and will implicitly enable > I2C_MUX_REG as well, and the compilation will fail for the > register driver. > > Fix this up by making I2C_MUX_REG depend on HAS_IOMEM and > removing the dependency from I2C_MUX. > > Cc: stable@vger.kernel.org > Reported-by: kbuild test robot > Reported-by: Jonathan Cameron > Cc: Jonathan Cameron > Cc: Peter Rosin > Signed-off-by: Linus Walleij Acked-by: Peter Rosin Thanks! Cheers, Peter From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-db5eur01on0138.outbound.protection.outlook.com ([104.47.2.138]:63301 "EHLO EUR01-DB5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S935180AbcKNUPq (ORCPT ); Mon, 14 Nov 2016 15:15:46 -0500 Subject: Re: [PATCH v2] i2c: mux: fix up dependencies To: Linus Walleij , Wolfram Sang , References: <1479134057-30653-1-git-send-email-linus.walleij@linaro.org> CC: , Jonathan Cameron From: Peter Rosin Message-ID: <6094de61-8745-fbff-e516-db95392aa142@axentia.se> Date: Mon, 14 Nov 2016 15:39:54 +0100 MIME-Version: 1.0 In-Reply-To: <1479134057-30653-1-git-send-email-linus.walleij@linaro.org> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: stable-owner@vger.kernel.org List-ID: On 2016-11-14 15:34, Linus Walleij wrote: > We get the following build error from UM Linux after adding > an entry to drivers/iio/gyro/Kconfig that issues "select I2C_MUX": > > ERROR: "devm_ioremap_resource" > [drivers/i2c/muxes/i2c-mux-reg.ko] undefined! > ERROR: "of_address_to_resource" > [drivers/i2c/muxes/i2c-mux-reg.ko] undefined! > > It appears that the I2C mux core code depends on HAS_IOMEM > for historical reasons, while CONFIG_I2C_MUX_REG does *not* > have a direct dependency on HAS_IOMEM. > > This creates a situation where a allyesconfig or allmodconfig > for UM Linux will select I2C_MUX, and will implicitly enable > I2C_MUX_REG as well, and the compilation will fail for the > register driver. > > Fix this up by making I2C_MUX_REG depend on HAS_IOMEM and > removing the dependency from I2C_MUX. > > Cc: stable@vger.kernel.org > Reported-by: kbuild test robot > Reported-by: Jonathan Cameron > Cc: Jonathan Cameron > Cc: Peter Rosin > Signed-off-by: Linus Walleij Acked-by: Peter Rosin Thanks! Cheers, Peter