All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexander Stein <alexander.stein@ew.tq-group.com>
To: Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>,
	"open list:TQ SYSTEMS BOARD & DRIVER SUPPORT"
	<linux@ew.tq-group.com>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
	<devicetree@vger.kernel.org>,
	"open list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE"
	<imx@lists.linux.dev>,
	"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE"
	<linux-arm-kernel@lists.infradead.org>,
	open list <linux-kernel@vger.kernel.org>,
	Frank Li <Frank.Li@nxp.com>
Subject: Re: [PATCH 1/1] arm64: dts: imx8: move samsung, burst-clock-frequency to imx8mn and imx8mm mba8mx board file
Date: Wed, 23 Oct 2024 08:38:53 +0200	[thread overview]
Message-ID: <6096263.lOV4Wx5bFT@steina-w> (raw)
In-Reply-To: <20241022220429.1281129-1-Frank.Li@nxp.com>

Hi Frank,

thanks for the patch.

Am Mittwoch, 23. Oktober 2024, 00:04:29 CEST schrieb Frank Li:
> Move 'samsung,burst-clock-frequency' and 'samsung,esc-clock-frequency'
> properties to i.MX8MN and i.MX8MM mba8mx board file. These properties are
> not applicable to i.MX8MQ MIPI DSI, which uses the compatible string
> 'fsl,imx8mq-nwl-dsi'. The properties are only valid for i.MX8MM and i.MX8MN
> devices with the compatible string 'fsl,imx8mm-mipi-dsim', as described in
> samsung,mipi-dsim.yaml.
> 
> Fix warning:
> /arch/arm64/boot/dts/freescale/imx8mq-tqma8mq-mba8mx-lvds-tm070jvhg33.dtb: dsi@30a00000:
>     Unevaluated properties are not allowed ('ports', 'samsung,burst-clock-frequency', 'samsung,esc-clock-frequency' were unexpected)
>         from schema $id: http://devicetree.org/schemas/display/bridge/nwl-dsi.yaml#
> 
> Signed-off-by: Frank Li <Frank.Li@nxp.com>

Reviewed-by: Alexander Stein <alexander.stein@ew.tq-group.com>

> ---
>  arch/arm64/boot/dts/freescale/imx8mm-tqma8mqml-mba8mx.dts | 5 +++++
>  arch/arm64/boot/dts/freescale/imx8mn-tqma8mqnl-mba8mx.dts | 5 +++++
>  arch/arm64/boot/dts/freescale/mba8mx.dtsi                 | 5 -----
>  3 files changed, 10 insertions(+), 5 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-tqma8mqml-mba8mx.dts b/arch/arm64/boot/dts/freescale/imx8mm-tqma8mqml-mba8mx.dts
> index 01b632b220dc7..b941c8c4f7bb4 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm-tqma8mqml-mba8mx.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8mm-tqma8mqml-mba8mx.dts
> @@ -75,6 +75,11 @@ expander2: gpio@27 {
>  	};
>  };
>  
> +&mipi_dsi {
> +	samsung,burst-clock-frequency = <891000000>;
> +	samsung,esc-clock-frequency = <20000000>;
> +};
> +
>  &pcie_phy {
>  	fsl,refclk-pad-mode = <IMX8_PCIE_REFCLK_PAD_INPUT>;
>  	fsl,clkreq-unsupported;
> diff --git a/arch/arm64/boot/dts/freescale/imx8mn-tqma8mqnl-mba8mx.dts b/arch/arm64/boot/dts/freescale/imx8mn-tqma8mqnl-mba8mx.dts
> index 433d8bba44255..dc94d73f7106c 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mn-tqma8mqnl-mba8mx.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8mn-tqma8mqnl-mba8mx.dts
> @@ -64,6 +64,11 @@ expander2: gpio@27 {
>  	};
>  };
>  
> +&mipi_dsi {
> +	samsung,burst-clock-frequency = <891000000>;
> +	samsung,esc-clock-frequency = <20000000>;
> +};
> +
>  &sai3 {
>  	assigned-clocks = <&clk IMX8MN_CLK_SAI3>;
>  	assigned-clock-parents = <&clk IMX8MN_AUDIO_PLL1_OUT>;
> diff --git a/arch/arm64/boot/dts/freescale/mba8mx.dtsi b/arch/arm64/boot/dts/freescale/mba8mx.dtsi
> index 3d26b6981c06f..58e3865c28895 100644
> --- a/arch/arm64/boot/dts/freescale/mba8mx.dtsi
> +++ b/arch/arm64/boot/dts/freescale/mba8mx.dtsi
> @@ -317,11 +317,6 @@ lvds_bridge_out: endpoint {
>  	};
>  };
>  
> -&mipi_dsi {
> -	samsung,burst-clock-frequency = <891000000>;
> -	samsung,esc-clock-frequency = <20000000>;
> -};
> -
>  &mipi_dsi_out {
>  	data-lanes = <1 2 3 4>;
>  	remote-endpoint = <&lvds_bridge_in>;
> 


-- 
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
http://www.tq-group.com/



  reply	other threads:[~2024-10-23  6:39 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-22 22:04 [PATCH 1/1] arm64: dts: imx8: move samsung,burst-clock-frequency to imx8mn and imx8mm mba8mx board file Frank Li
2024-10-23  6:38 ` Alexander Stein [this message]
2024-11-01  9:48 ` Shawn Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6096263.lOV4Wx5bFT@steina-w \
    --to=alexander.stein@ew.tq-group.com \
    --cc=Frank.Li@nxp.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=imx@lists.linux.dev \
    --cc=kernel@pengutronix.de \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@ew.tq-group.com \
    --cc=robh@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.