All of lore.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Daniel Baluta <daniel.baluta@nxp.com>,
	Shuah Khan <skhan@linuxfoundation.org>,
	Julia Lawall <julia.lawall@inria.fr>,
	Javier Carrasco <javier.carrasco.cruz@gmail.com>
Cc: "Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	devicetree@vger.kernel.org,
	"Péter Ujfalusi" <peter.ujfalusi@gmail.com>,
	linux-kernel@vger.kernel.org
Subject: DT schema bindings conversion mentorships (was Re: [PATCH v5] ASoC: dt-bindings: omap-mcpdm: Convert to DT schema)
Date: Wed, 22 May 2024 19:05:24 +0200	[thread overview]
Message-ID: <60989c44-6d16-4698-bf3f-b3c5dcd7b3e0@kernel.org> (raw)
In-Reply-To: <58ada5ce-5c02-4ff5-8bdd-d6556c9d141f@kernel.org>

On 22/05/2024 18:42, Krzysztof Kozlowski wrote:
>> Yes, the binding document was neglected pretty badly but when converting
>> to yaml it has to be correct since that will have ripple effect on
>> existing dts/dtsi files.
> 
> Yep. And testing DTS should clearly show that conversion leads to
> incomplete binding.
> 
>>
>>> I assume the DTS was validated with the binding. Isn't the case here?
> 
> Mithil Bavishi,
> Are you sure you tested the DTS?

Dear Daniel, Shuah, Julia, Javier and other mentorship managers,

I see some contributions regarding Devicetree bindings which look like
efforts of some mentorship programs. It's great, I really like it. Only
sadness is that no one ever asked us, Devicetree maintainers, about some
sort of guidelines. This leads to sub-optimal allocation of tasks and
quite a strain on reviewers side: for example we receive contributions
which were never tested (tested as in make target - make
dt_binding_check). Or people converted bindings which really do not
matter thus their work soon will become obsolete.

If there are still such active programs, please be sure that mentees
follow these guidelines:

https://social.kernel.org/notice/Ai9hYRUKo8suzX3zNY

1. Please convert bindings which have active DTS users. First choose
bindings with DTS built by arm64 defconfig, then next choice by arm
multi_v7 defconfig. Then any other ARM or different architecture DTS.

2. Be sure dt_bindings_check (including yamllint) and checkpatch pass
without any warnings. See writing-schema.rst document.

3. Be sure DTS using these bindings passes dtbs_check validation. If
this means binding needs to be adapted during conversion, mention
briefly in the commit message changes done comparing to pure TXT->DT
schema conversion.

Best regards,
Krzysztof


  parent reply	other threads:[~2024-05-22 17:05 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-22  7:52 [PATCH v5] ASoC: dt-bindings: omap-mcpdm: Convert to DT schema Mighty
2024-05-22  8:42 ` Krzysztof Kozlowski
2024-05-22 13:46   ` Mithil
2024-05-22 14:15     ` Krzysztof Kozlowski
2024-05-22 13:56 ` Péter Ujfalusi
2024-05-22 14:16   ` Krzysztof Kozlowski
2024-05-22 14:43     ` Péter Ujfalusi
2024-05-22 15:22       ` Krzysztof Kozlowski
2024-05-22 16:01         ` Péter Ujfalusi
2024-05-22 16:42           ` Krzysztof Kozlowski
2024-05-22 17:02             ` Mithil
2024-05-22 17:07               ` Mithil
2024-05-22 17:07               ` Krzysztof Kozlowski
2024-05-22 17:30                 ` Mithil
2024-05-22 17:47                   ` Mithil
2024-05-22 18:49                     ` Péter Ujfalusi
2024-05-22 18:39                 ` Péter Ujfalusi
2024-05-23  6:08                   ` Krzysztof Kozlowski
2024-05-22 17:05             ` Krzysztof Kozlowski [this message]
2024-05-22 17:47               ` DT schema bindings conversion mentorships (was Re: [PATCH v5] ASoC: dt-bindings: omap-mcpdm: Convert to DT schema) Javier Carrasco
2024-05-23  6:12                 ` Krzysztof Kozlowski
2024-05-22 18:36               ` Conor Dooley
2024-05-23 12:33                 ` Daniel Baluta
2024-05-23 12:30               ` Daniel Baluta
2024-05-23 16:24                 ` Rob Herring
2024-05-23 16:31                   ` Javier Carrasco
2024-05-22 14:22   ` [PATCH v5] ASoC: dt-bindings: omap-mcpdm: Convert to DT schema Rob Herring
2024-05-22 14:39     ` Péter Ujfalusi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=60989c44-6d16-4698-bf3f-b3c5dcd7b3e0@kernel.org \
    --to=krzk@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=daniel.baluta@nxp.com \
    --cc=devicetree@vger.kernel.org \
    --cc=javier.carrasco.cruz@gmail.com \
    --cc=julia.lawall@inria.fr \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peter.ujfalusi@gmail.com \
    --cc=robh@kernel.org \
    --cc=skhan@linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.