From: xuyang2018.jy@fujitsu.com <xuyang2018.jy@fujitsu.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] syscalls/mallinfo01: Disable free fastbin blocks
Date: Thu, 13 May 2021 10:00:31 +0000 [thread overview]
Message-ID: <609CF8E0.2030408@fujitsu.com> (raw)
In-Reply-To: <96c15b88-4251-5794-03e0-12bcc048fa5e@suse.cz>
Hi Martin
I don't have a proper fix. So you can remove it from runtest file.
Best Regards
Yang Xu
> Hello,
>
> On 13. 05. 21 10:54, Yang Xu wrote:
>> When using malloc to allocate small space, it will use fastbin block firstly if
>> we have free fastbin free blocks, it is more quickly.
>> In here, we just test oldblks free chunks, it is the number of ordinary
>> (i.e. non-fastbin) free blocks. So use mallopt(M_MXFAST, 0) to disable
>> free fastbin block.
>>
>> Signed-off-by: Yang Xu<xuyang2018.jy@fujitsu.com>
>> ---
>> testcases/kernel/syscalls/mallinfo/mallinfo01.c | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/testcases/kernel/syscalls/mallinfo/mallinfo01.c b/testcases/kernel/syscalls/mallinfo/mallinfo01.c
>> index 48fce0132..4e10e352e 100644
>> --- a/testcases/kernel/syscalls/mallinfo/mallinfo01.c
>> +++ b/testcases/kernel/syscalls/mallinfo/mallinfo01.c
>> @@ -64,6 +64,8 @@ static void setup(void)
>> {
>> if (sizeof(info1.arena) != sizeof(int))
>> tst_res(TFAIL, "The member of mallinfo struct is not int");
>> + if (mallopt(M_MXFAST, 0) == 0)
>> + tst_res(TFAIL, "mallopt(M_MXFAST, 0) failed");
>>
>> info1 = mallinfo();
>> print_mallinfo("Start",&info1);
>>
>
> Sorry but this does not fix the problem. The failing subtest assumes that:
> - malloc() will never increase ordblks
> - free() will allways increase ordblks
>
> mallinfo01 is failing because both of these assumptions are wrong.
> Disabling fastbin block usage will not fix the failure.
>
next prev parent reply other threads:[~2021-05-13 10:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-13 8:54 [LTP] [PATCH] syscalls/mallinfo01: Disable free fastbin blocks Yang Xu
2021-05-13 9:05 ` Martin Doucha
2021-05-13 10:00 ` xuyang2018.jy [this message]
2021-05-13 9:47 ` Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=609CF8E0.2030408@fujitsu.com \
--to=xuyang2018.jy@fujitsu.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.