From: xuyang2018.jy@fujitsu.com <xuyang2018.jy@fujitsu.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 2/2] lib/newlib_tests/test_macros*.c: Include more test macros
Date: Tue, 29 Jun 2021 10:33:42 +0000 [thread overview]
Message-ID: <60DAF735.1060401@fujitsu.com> (raw)
In-Reply-To: <CAEemH2dL=bZdP_X+YkZuOFK2dCV8RTq5CyZYPTrKh+_2yjHK5g@mail.gmail.com>
Hi Li,
> Hi Xu,
>
> On Tue, Jun 29, 2021 at 5:27 PM Yang Xu <xuyang2018.jy@fujitsu.com
> <mailto:xuyang2018.jy@fujitsu.com>> wrote:
>
> 1) test TST_EXP_FD_SILENT macro in test_macros01.c
>
>
> I'm thinking maybe we should add more info to indicate the TST_PASS result
> from which TST_EXP_FD_SILENT? Because as TST_EXP_FD_SILENT will
> keep silent, the only returned looks strange to us.
Sound reasonable. I will make these output more clear in v2.
Thanks for your review.
Best Regards
Yang Xu
>
> e.g.
>
> TST_EXP_FD_SILENT(pass_fd(), "%s", "SCALL");
> - tst_res(TINFO, "TST_PASS = %i", TST_PASS);
> + tst_res(TINFO, "TST_PASS = %i from TST_EXP_FD_SILENT(pass_fd, ...)",
> TST_PASS);
>
> 2) test TST_EXP_FAIL2 macro in test_macros02.c
>
> 3) test TST_EXP_PASS_SILENT macro in test_macros03.c
>
>
> here as well.
>
> 4) add test_macros04.c to test TST_EXP_PID and TST_EXP_PID_SILENT macros
>
>
> and here.
>
> Btw, the remaining part looks good to me.
>
> --
> Regards,
> Li Wang
next prev parent reply other threads:[~2021-06-29 10:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-29 9:25 [LTP] [PATCH 1/2] include/tst_test_macro.h: Fix zero-length gnu_printf format string warning Yang Xu
2021-06-29 9:25 ` [LTP] [PATCH 2/2] lib/newlib_tests/test_macros*.c: Include more test macros Yang Xu
2021-06-29 10:20 ` Li Wang
2021-06-29 10:33 ` xuyang2018.jy [this message]
2021-06-29 11:14 ` [LTP] [PATCH v2] " Yang Xu
2021-06-29 12:29 ` Li Wang
2021-06-30 2:53 ` xuyang2018.jy
2021-06-29 10:10 ` [LTP] [PATCH 1/2] include/tst_test_macro.h: Fix zero-length gnu_printf format string warning Li Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=60DAF735.1060401@fujitsu.com \
--to=xuyang2018.jy@fujitsu.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.