From: "David Hildenbrand (Arm)" <david@kernel.org>
To: Tal Zussman <tz2294@columbia.edu>,
Andrew Morton <akpm@linux-foundation.org>,
Chris Li <chrisl@kernel.org>, Kairui Song <kasong@tencent.com>,
Kemeng Shi <shikemeng@huaweicloud.com>,
Nhat Pham <nphamcs@gmail.com>, Baoquan He <baoquan.he@linux.dev>,
Barry Song <baohua@kernel.org>,
Youngjun Park <youngjun.park@lge.com>, Zi Yan <ziy@nvidia.com>,
Baolin Wang <baolin.wang@linux.alibaba.com>,
"Liam R. Howlett" <liam@infradead.org>,
Nico Pache <nico.pache@linux.dev>,
Ryan Roberts <ryan.roberts@arm.com>, Dev Jain <dev.jain@arm.com>,
Lance Yang <lance.yang@linux.dev>,
Usama Arif <usama.arif@linux.dev>,
Kiryl Shutsemau <kas@kernel.org>,
Lorenzo Stoakes <ljs@kernel.org>, Rik van Riel <riel@surriel.com>,
Vlastimil Babka <vbabka@kernel.org>, Harry Yoo <harry@kernel.org>,
Jann Horn <jannh@google.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Yosry Ahmed <yosry@kernel.org>,
Chengming Zhou <chengming.zhou@linux.dev>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>,
Mark Rutland <mark.rutland@arm.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 4/8] mm/zswap: use folio_swap_entry() in zswap_store_page()
Date: Wed, 9 Sep 2026 16:00:53 +0200 [thread overview]
Message-ID: <60ac97b9-8da3-491d-8d1c-dcd83c7232fb@kernel.org> (raw)
In-Reply-To: <20260908-folio_swap_entry-v2-4-ee6d01dfa5e1@columbia.edu>
On 9/8/26 17:16, Tal Zussman wrote:
> zswap_store_page() open-codes the swap entry computation from
> folio->swap and the page index. Use folio_swap_entry() instead.
>
> No functional change.
>
> Signed-off-by: Tal Zussman <tz2294@columbia.edu>
> ---
> mm/zswap.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/mm/zswap.c b/mm/zswap.c
> index 5d0d8bd72193..c27e22d067e3 100644
> --- a/mm/zswap.c
> +++ b/mm/zswap.c
> @@ -1398,8 +1398,7 @@ static bool zswap_store_page(struct folio *folio, long index,
> struct obj_cgroup *objcg,
> struct zswap_pool *pool)
> {
> - swp_entry_t page_swpentry = swp_entry(swp_type(folio->swap),
> - swp_offset(folio->swap) + index);
> + swp_entry_t page_swpentry = folio_swap_entry(folio, index);
> struct zswap_entry *entry, *old;
>
> /* allocate entry */
>
Acked-by: David Hildenbrand (Arm) <david@kernel.org>
--
Cheers,
David
next prev parent reply other threads:[~2026-09-09 14:01 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-08 15:16 [PATCH v2 0/8] mm: remove page_swap_entry() Tal Zussman
2026-09-08 15:16 ` [PATCH v2 1/8] mm/swap: add folio_swap_entry() and folio_page_swap_entry() Tal Zussman
2026-09-09 14:00 ` David Hildenbrand (Arm)
2026-09-09 17:21 ` Tal Zussman
2026-09-09 17:25 ` David Hildenbrand (Arm)
2026-09-13 21:52 ` Tal Zussman
2026-09-08 15:16 ` [PATCH v2 2/8] mm/huge_memory: add a comment to the open-coded swap entry Tal Zussman
2026-09-08 15:26 ` Zi Yan
2026-09-09 13:52 ` David Hildenbrand (Arm)
2026-09-08 15:16 ` [PATCH v2 3/8] mm/rmap: use folio_page_swap_entry() in ttu_anon_swapbacked_folio() Tal Zussman
2026-09-09 14:00 ` David Hildenbrand (Arm)
2026-09-08 15:16 ` [PATCH v2 4/8] mm/zswap: use folio_swap_entry() in zswap_store_page() Tal Zussman
2026-09-09 14:00 ` David Hildenbrand (Arm) [this message]
2026-09-08 15:16 ` [PATCH v2 5/8] mm/swapfile: use folio_page_swap_entry() Tal Zussman
2026-09-09 14:01 ` David Hildenbrand (Arm)
2026-09-08 15:16 ` [PATCH v2 6/8] arm64: mte: make mte_save_tags() and mte_restore_tags() static Tal Zussman
2026-09-09 14:01 ` David Hildenbrand (Arm)
2026-09-08 15:16 ` [PATCH v2 7/8] arm64: mte: pass the swap entry to mte_save_tags() Tal Zussman
2026-09-09 14:06 ` David Hildenbrand (Arm)
2026-09-08 15:16 ` [PATCH v2 8/8] mm/swap: remove page_swap_entry() Tal Zussman
2026-09-09 14:06 ` David Hildenbrand (Arm)
2026-09-08 17:55 ` [PATCH v2 0/8] mm: " Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=60ac97b9-8da3-491d-8d1c-dcd83c7232fb@kernel.org \
--to=david@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=baohua@kernel.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=baoquan.he@linux.dev \
--cc=catalin.marinas@arm.com \
--cc=chengming.zhou@linux.dev \
--cc=chrisl@kernel.org \
--cc=dev.jain@arm.com \
--cc=hannes@cmpxchg.org \
--cc=harry@kernel.org \
--cc=jannh@google.com \
--cc=kas@kernel.org \
--cc=kasong@tencent.com \
--cc=lance.yang@linux.dev \
--cc=liam@infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ljs@kernel.org \
--cc=mark.rutland@arm.com \
--cc=nico.pache@linux.dev \
--cc=nphamcs@gmail.com \
--cc=riel@surriel.com \
--cc=ryan.roberts@arm.com \
--cc=shikemeng@huaweicloud.com \
--cc=tz2294@columbia.edu \
--cc=usama.arif@linux.dev \
--cc=vbabka@kernel.org \
--cc=will@kernel.org \
--cc=yosry@kernel.org \
--cc=youngjun.park@lge.com \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.