From: Florian Fainelli <f.fainelli@gmail.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: netdev@vger.kernel.org, davem@davemloft.net,
vivien.didelot@savoirfairelinux.com, jiri@resnulli.us
Subject: Re: [PATCH net-next 1/2] net: dsa: Implement ndo_get_phys_port_name()
Date: Tue, 10 Jan 2017 12:58:53 -0800 [thread overview]
Message-ID: <60d188ef-a080-1707-9ff2-0ebfa58b81d2@gmail.com> (raw)
In-Reply-To: <20170110205043.GM22820@lunn.ch>
On 01/10/2017 12:50 PM, Andrew Lunn wrote:
> On Tue, Jan 10, 2017 at 12:32:36PM -0800, Florian Fainelli wrote:
>> Return the physical port number of a DSA created network device using
>> ndo_get_phys_port_name().
>
> At what level does this need to be unique?
This needs to be unique to the switch I would say,
ndo_get_phys_switch_id would return the physical number of the switch
device in the tree/cluster, so that number plus the port name should be
an unique differentiator that is good enough for e.g: a persistent
naming rule?
>
> We can have multiple switches within one switch cluster. p->port will
> be unique within one switch, but can be repeated in a cluster.
>
> We can also have multiple clusters, and again p->port will be re-used.
--
Florian
next prev parent reply other threads:[~2017-01-10 20:58 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-10 20:32 [PATCH net-next 0/2] net: dsa: Implement ndo_get_phys_port_name() Florian Fainelli
2017-01-10 20:32 ` [PATCH net-next 1/2] " Florian Fainelli
2017-01-10 20:44 ` Vivien Didelot
2017-01-10 20:50 ` Andrew Lunn
2017-01-10 20:58 ` Vivien Didelot
2017-01-10 20:58 ` Florian Fainelli [this message]
2017-01-11 7:28 ` Jiri Pirko
2017-01-11 7:29 ` Jiri Pirko
2017-01-10 20:32 ` [PATCH net-next 2/2] Revert "net: dsa: Implement ndo_get_phys_port_id" Florian Fainelli
2017-01-10 20:44 ` Vivien Didelot
2017-01-11 7:29 ` Jiri Pirko
2017-01-11 14:59 ` [PATCH net-next 0/2] net: dsa: Implement ndo_get_phys_port_name() David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=60d188ef-a080-1707-9ff2-0ebfa58b81d2@gmail.com \
--to=f.fainelli@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.