From: Amit Shah <amit@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
virtualization@lists.linux.dev, linux-kernel@vger.kernel.org
Cc: Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH v1 1/1] virtio_console: Get rid of unneeded temporary variable
Date: Wed, 12 Feb 2025 13:19:23 +0100 [thread overview]
Message-ID: <60d61b5bf637370f0eeda0e331b9da2c29fbf2b4.camel@kernel.org> (raw)
In-Reply-To: <20250210095946.4122771-1-andriy.shevchenko@linux.intel.com>
On Mon, 2025-02-10 at 11:59 +0200, Andy Shevchenko wrote:
> When compiling a kernel with GCC using `make W=1` with
> CONFIG_WERROR=y
> (which is default nowadays), the build fails:
>
> drivers/char/virtio_console.c:1427:9: note: ‘snprintf’ output between
> 9 and 27 bytes into a destination of size 16
>
> Indeed, GCC can't see the limits of the variables that are in use.
> Fix this by using dev_name() of the newly created device that is
> luckily the same as the string used for the DebugFS node name.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> drivers/char/virtio_console.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
Reviewed-by: Amit Shah <amit@kernel.org>
prev parent reply other threads:[~2025-02-12 12:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-10 9:59 [PATCH v1 1/1] virtio_console: Get rid of unneeded temporary variable Andy Shevchenko
2025-02-12 12:19 ` Amit Shah [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=60d61b5bf637370f0eeda0e331b9da2c29fbf2b4.camel@kernel.org \
--to=amit@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=virtualization@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.