From: Javier Martinez Canillas <javierm@redhat.com>
To: Daniel Kiper <daniel.kiper@oracle.com>, grub-devel@gnu.org
Cc: eschwartz@archlinux.org, floppym@gentoo.org, leif@nuviainc.com,
olaf@aepfle.de, phcoder@gmail.com, pjones@redhat.com
Subject: Re: [PATCH v2 1/4] configure: Drop unneeded TARGET_CFLAGS expansion
Date: Tue, 7 Apr 2020 11:24:35 +0200 [thread overview]
Message-ID: <60db7d27-ece3-551d-eb7b-400a87fdd25e@redhat.com> (raw)
In-Reply-To: <20200403124503.12779-2-daniel.kiper@oracle.com>
On 4/3/20 2:45 PM, Daniel Kiper wrote:
> Signed-off-by: Daniel Kiper <daniel.kiper@oracle.com>
> ---
> configure.ac | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/configure.ac b/configure.ac
> index 88c0adbae..b2576b013 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -77,7 +77,7 @@ grub_TRANSFORM([grub-file])
>
> # Optimization flag. Allow user to override.
> if test "x$TARGET_CFLAGS" = x; then
> - TARGET_CFLAGS="$TARGET_CFLAGS -Os"
> + TARGET_CFLAGS=-Os
> fi
>
Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
Best regards,
--
Javier Martinez Canillas
Software Engineer - Desktop Hardware Enablement
Red Hat
next prev parent reply other threads:[~2020-04-07 9:24 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-03 12:44 [PATCH v2 0/4] Various build and doc fixes Daniel Kiper
2020-04-03 12:45 ` [PATCH v2 1/4] configure: Drop unneeded TARGET_CFLAGS expansion Daniel Kiper
2020-04-03 13:36 ` John Paul Adrian Glaubitz
2020-04-07 9:24 ` Javier Martinez Canillas [this message]
2020-04-03 12:45 ` [PATCH v2 2/4] configure: Enforce gnu99 C language standard Daniel Kiper
2020-04-07 9:38 ` Javier Martinez Canillas
2020-04-07 10:41 ` Daniel Kiper
2020-04-07 11:23 ` Leif Lindholm
2020-04-07 11:37 ` Javier Martinez Canillas
2020-04-07 10:52 ` Leif Lindholm
2020-04-03 12:45 ` [PATCH v2 3/4] INSTALL/configure: Update install doc and configure comment Daniel Kiper
2020-04-07 9:43 ` Javier Martinez Canillas
2020-04-07 11:16 ` Leif Lindholm
2020-04-10 12:05 ` Daniel Kiper
2020-04-20 13:04 ` Leif Lindholm
2020-04-21 14:55 ` Daniel Kiper
2020-04-30 11:40 ` Leif Lindholm
2020-04-03 12:45 ` [PATCH v2 4/4] autogen: Replace -iname with -ipath in find command Daniel Kiper
2020-04-07 9:44 ` Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=60db7d27-ece3-551d-eb7b-400a87fdd25e@redhat.com \
--to=javierm@redhat.com \
--cc=daniel.kiper@oracle.com \
--cc=eschwartz@archlinux.org \
--cc=floppym@gentoo.org \
--cc=grub-devel@gnu.org \
--cc=leif@nuviainc.com \
--cc=olaf@aepfle.de \
--cc=phcoder@gmail.com \
--cc=pjones@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.