From: kgunda@codeaurora.org
To: Stephen Boyd <sboyd@codeaurora.org>
Cc: gregkh@linuxfoundation.org,
Abhijeet Dharmapurikar <adharmap@codeaurora.org>,
David Collins <collinsd@codeaurora.org>,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-arm-msm-owner@vger.kernel.org
Subject: Re: [PATCH V1 03/12] spmi: pmic-arb: clean up pmic_arb_find_apid function
Date: Fri, 28 Jul 2017 11:03:32 +0530 [thread overview]
Message-ID: <60e3f73bc6661166af32eca4a8bd0743@codeaurora.org> (raw)
In-Reply-To: <20170728011805.GX2146@codeaurora.org>
On 2017-07-28 06:48, Stephen Boyd wrote:
> On 07/20, Kiran Gunda wrote:
>> Clean up the pmic_arb_find_apid() by using the local
>> variables to improve the code readability.
>>
>> Signed-off-by: Kiran Gunda <kgunda@codeaurora.org>
>> ---
>
> Reviewed-by: Stephen Boyd <sboyd@codeaurora.org>
>
> One nit below:
>
>> break;
>>
>> regval = readl_relaxed(pmic_arb->cnfg +
>> - SPMI_OWNERSHIP_TABLE_REG(apid));
>> - pmic_arb->apid_data[apid].owner =
>> - SPMI_OWNERSHIP_PERIPH2OWNER(regval);
>> + SPMI_OWNERSHIP_TABLE_REG(apid));
>
> This should be 7 spaces and not a tab? Originally looks like it
> was 6 spaces
Will fix it and send the next patch.
next prev parent reply other threads:[~2017-07-28 5:33 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-20 7:31 [PATCH V1 00/12]: spmi: pmic-arb: Support for HW v5 and other fixes Kiran Gunda
2017-07-20 7:31 ` [PATCH V1 01/12] spmi: pmic-arb: remove the read/write access checks Kiran Gunda
2017-07-20 7:31 ` [PATCH V1 02/12] spmi: pmic-arb: rename pa_xx to pmic_arb_xx and other cleanup Kiran Gunda
2017-07-28 0:00 ` Stephen Boyd
2017-07-28 5:54 ` kgunda
2017-07-20 7:31 ` [PATCH V1 03/12] spmi: pmic-arb: clean up pmic_arb_find_apid function Kiran Gunda
2017-07-28 1:18 ` Stephen Boyd
2017-07-28 5:33 ` kgunda [this message]
2017-07-20 7:31 ` [PATCH V1 04/12] spmi: pmic-arb: optimize qpnpint_irq_set_type function Kiran Gunda
2017-07-27 23:46 ` Stephen Boyd
2017-07-20 7:31 ` [PATCH V1 05/12] spmi: pmic-arb: fix memory allocation for mapping_table Kiran Gunda
2017-07-27 23:49 ` Stephen Boyd
2017-07-28 0:01 ` Stephen Boyd
2017-07-28 5:32 ` kgunda
2017-07-20 7:31 ` [PATCH V1 06/12] spmi: pmic-arb: replace the writel_relaxed with __raw_writel Kiran Gunda
2017-07-28 0:01 ` Stephen Boyd
2017-07-28 5:34 ` kgunda
2017-07-20 7:31 ` [PATCH V1 07/12] spmi: pmic-arb: return the value instead of passing by pointer Kiran Gunda
2017-07-20 7:31 ` [PATCH V1 08/12] spmi: pmic-arb: use irq_chip callback to set spmi irq wakeup capability Kiran Gunda
2017-07-20 7:31 ` [PATCH V1 09/12] spmi: pmic-arb: return __iomem pointer instead of offset Kiran Gunda
2017-07-20 7:31 ` [PATCH V1 10/12] spmi: pmic-arb: fix a possible null pointer dereference Kiran Gunda
2017-07-20 7:31 ` [PATCH V1 11/12] spmi: pmic-arb: add support for HW version 5 Kiran Gunda
2017-07-20 7:31 ` [PATCH V1 12/12] spmi: pmic-arb: Remove checking opc value not less than 0 Kiran Gunda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=60e3f73bc6661166af32eca4a8bd0743@codeaurora.org \
--to=kgunda@codeaurora.org \
--cc=adharmap@codeaurora.org \
--cc=collinsd@codeaurora.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-msm-owner@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sboyd@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.