From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Jeffery Date: Thu, 17 Sep 2020 08:42:27 +0930 Subject: [PATCH] gpio: aspeed: fix ast2600 bank properties In-Reply-To: <20200916204216.9423-1-rentao.bupt@gmail.com> References: <20200916204216.9423-1-rentao.bupt@gmail.com> Message-ID: <60f9f14a-c9be-45ac-b3a8-516ab73d9bee@www.fastmail.com> List-Id: To: linux-aspeed@lists.ozlabs.org MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Thu, 17 Sep 2020, at 06:12, rentao.bupt at gmail.com wrote: > From: Tao Ren > > GPIO_U is mapped to the least significant byte of input/output mask, and > the byte in "output" mask should be 0 because GPIO_U is input only. All > the other bits need to be 1 because GPIO_V/W/X support both input and > output modes. > > Similarly, GPIO_Y/Z are mapped to the 2 least significant bytes, and the > according bits need to be 1 because GPIO_Y/Z support both input and > output modes. > > Fixes: ab4a85534c3e ("gpio: aspeed: Add in ast2600 details to Aspeed driver") > Signed-off-by: Tao Ren Thanks Tao, Reviewed-by: Andrew Jeffery From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E02F4C2BB84 for ; Wed, 16 Sep 2020 23:13:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7E1AA22207 for ; Wed, 16 Sep 2020 23:13:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=aj.id.au header.i=@aj.id.au header.b="gsvTVMUl"; dkim=temperror (0-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="d0NLfsFY" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727056AbgIPXNB (ORCPT ); Wed, 16 Sep 2020 19:13:01 -0400 Received: from out5-smtp.messagingengine.com ([66.111.4.29]:45467 "EHLO out5-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727007AbgIPXMz (ORCPT ); Wed, 16 Sep 2020 19:12:55 -0400 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id B0FE75C0A37; Wed, 16 Sep 2020 19:12:49 -0400 (EDT) Received: from imap2 ([10.202.2.52]) by compute3.internal (MEProxy); Wed, 16 Sep 2020 19:12:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aj.id.au; h= mime-version:message-id:in-reply-to:references:date:from:to :subject:content-type; s=fm3; bh=wWsRwlVvP8+43MZ6dwzJ2Fdj/0px7Bt Uhpq3T6t85KU=; b=gsvTVMUl3GJG8bCr0WIzqog4pLruzE0o4Dawa2TPuJ1t/qx Ren3Xs5Qkpl7qXc4qf34+KXoRLNhrJ9Zcofm8gsyhv+JrxO4yNj4JlTJlcvRCySs /tyC8uQwzmz7olHkRvJm969w6a+j5PG9qcekak2B6lS3M4VIJ7vPv9bi45YabCnF zvT7okIv6bjkxuV+6waXzQPCldibUjPx2NOWXVi1Xjz6JhgzuI7vX3K3ETLqXJoC IoeySVWrHW75AljKifV21TErzU/qzU+KaxwqVi3vSkpAsVUd25ZlyHrLBKygp0mJ 9RXfG7iEyQAaiFrmu/yG3E5y5xwhhC3rXGsPuLg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=wWsRwl VvP8+43MZ6dwzJ2Fdj/0px7BtUhpq3T6t85KU=; b=d0NLfsFYhpCurbF8wtJvhY jLZ+YJR2/D2BW81nT5LGL2+zM3VQ0N5eU9cXoRtc6xSNm3EeiLatKpGHUxXIywFs GaETtjGrLqbxhxv+OzHr5pJaTAFub0sCD+GJdr2NdxTDT6jQcNwCbkC9bmyIw0Hi uzKqhnAnFNnnB3lLbaxPaX0EbAHI4G6mtDTQew7aDM3H76FvnmC9p69SiWc/qLcc ArDjMi8DPiF8ldqrpcPaNLJUPAwDHPE//nWqaQ5RDDNog6YJxTwt1QIAJYfv4YBS aOd9FZEdLSwJdQgNlVVG1mfhEUMFPfImmOJtV/cUD989NVnrv5W0BLl6zrU39Ijw == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrtdefgddulecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefofgggkfgjfhffhffvufgtsehttdertderredtnecuhfhrohhmpedftehnughr vgifucflvghffhgvrhihfdcuoegrnhgurhgvfiesrghjrdhiugdrrghuqeenucggtffrrg htthgvrhhnpeehhfefkefgkeduveehffehieehudejfeejveejfedugfefuedtuedvhefh veeuffenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe grnhgurhgvfiesrghjrdhiugdrrghu X-ME-Proxy: Received: by mailuser.nyi.internal (Postfix, from userid 501) id 847BEE00D1; Wed, 16 Sep 2020 19:12:47 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.3.0-324-g0f99587-fm-20200916.004-g0f995879 Mime-Version: 1.0 Message-Id: <60f9f14a-c9be-45ac-b3a8-516ab73d9bee@www.fastmail.com> In-Reply-To: <20200916204216.9423-1-rentao.bupt@gmail.com> References: <20200916204216.9423-1-rentao.bupt@gmail.com> Date: Thu, 17 Sep 2020 08:42:27 +0930 From: "Andrew Jeffery" To: "Tao Ren" , "Linus Walleij" , "Bartosz Golaszewski" , "Joel Stanley" , linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org, openbmc@lists.ozlabs.org, "Tao Ren" Subject: Re: [PATCH] gpio: aspeed: fix ast2600 bank properties Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Thu, 17 Sep 2020, at 06:12, rentao.bupt@gmail.com wrote: > From: Tao Ren > > GPIO_U is mapped to the least significant byte of input/output mask, and > the byte in "output" mask should be 0 because GPIO_U is input only. All > the other bits need to be 1 because GPIO_V/W/X support both input and > output modes. > > Similarly, GPIO_Y/Z are mapped to the 2 least significant bytes, and the > according bits need to be 1 because GPIO_Y/Z support both input and > output modes. > > Fixes: ab4a85534c3e ("gpio: aspeed: Add in ast2600 details to Aspeed driver") > Signed-off-by: Tao Ren Thanks Tao, Reviewed-by: Andrew Jeffery From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D46B4C43461 for ; Wed, 16 Sep 2020 23:14:58 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6E0C722205 for ; Wed, 16 Sep 2020 23:14:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Af2QiFBm"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=aj.id.au header.i=@aj.id.au header.b="gsvTVMUl"; dkim=temperror (0-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="d0NLfsFY" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6E0C722205 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=aj.id.au Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe :List-Id:Subject:To:From:Date:References:In-Reply-To:Message-Id:Mime-Version: Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=tfTTO6MulXZLAufzcMt/Ly+BTqHXlaWeVBQVOa//2Fw=; b=Af2QiFBmMSLap5etaC99VS4uPw QKZgJLmao4PzFgQaoNqtjpKHIyW9nLjN5Yi2GEOV2rccJiV6czdjIbMcEcmUHfFi/tMpEy4QF3Xwi lMZ8Dznmz75lWCgE6lmM6x2IeaS9tapsopN/avWHXBVIiLL0XfamZvakFCfXTZPcumZ+zuxCyGgph wO2TjY3EI8SFvT/TDClCCUM09ue/0vGjsJorAObRICLYnN+S7C0PLFG7vaQJklhzGWirAifB0BQsN NmvdWZa23lw3xIJiCF77BfTrDav07VpIHeSaGrKE03PBit5UNmrK0b1SU6g6jKJ5lQo4OPhCpQ2HD WUeOLWTQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kIgbf-0002vD-VX; Wed, 16 Sep 2020 23:12:56 +0000 Received: from out5-smtp.messagingengine.com ([66.111.4.29]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kIgbc-0002uk-QF for linux-arm-kernel@lists.infradead.org; Wed, 16 Sep 2020 23:12:53 +0000 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id B0FE75C0A37; Wed, 16 Sep 2020 19:12:49 -0400 (EDT) Received: from imap2 ([10.202.2.52]) by compute3.internal (MEProxy); Wed, 16 Sep 2020 19:12:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aj.id.au; h= mime-version:message-id:in-reply-to:references:date:from:to :subject:content-type; s=fm3; bh=wWsRwlVvP8+43MZ6dwzJ2Fdj/0px7Bt Uhpq3T6t85KU=; b=gsvTVMUl3GJG8bCr0WIzqog4pLruzE0o4Dawa2TPuJ1t/qx Ren3Xs5Qkpl7qXc4qf34+KXoRLNhrJ9Zcofm8gsyhv+JrxO4yNj4JlTJlcvRCySs /tyC8uQwzmz7olHkRvJm969w6a+j5PG9qcekak2B6lS3M4VIJ7vPv9bi45YabCnF zvT7okIv6bjkxuV+6waXzQPCldibUjPx2NOWXVi1Xjz6JhgzuI7vX3K3ETLqXJoC IoeySVWrHW75AljKifV21TErzU/qzU+KaxwqVi3vSkpAsVUd25ZlyHrLBKygp0mJ 9RXfG7iEyQAaiFrmu/yG3E5y5xwhhC3rXGsPuLg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=wWsRwl VvP8+43MZ6dwzJ2Fdj/0px7BtUhpq3T6t85KU=; b=d0NLfsFYhpCurbF8wtJvhY jLZ+YJR2/D2BW81nT5LGL2+zM3VQ0N5eU9cXoRtc6xSNm3EeiLatKpGHUxXIywFs GaETtjGrLqbxhxv+OzHr5pJaTAFub0sCD+GJdr2NdxTDT6jQcNwCbkC9bmyIw0Hi uzKqhnAnFNnnB3lLbaxPaX0EbAHI4G6mtDTQew7aDM3H76FvnmC9p69SiWc/qLcc ArDjMi8DPiF8ldqrpcPaNLJUPAwDHPE//nWqaQ5RDDNog6YJxTwt1QIAJYfv4YBS aOd9FZEdLSwJdQgNlVVG1mfhEUMFPfImmOJtV/cUD989NVnrv5W0BLl6zrU39Ijw == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrtdefgddulecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefofgggkfgjfhffhffvufgtsehttdertderredtnecuhfhrohhmpedftehnughr vgifucflvghffhgvrhihfdcuoegrnhgurhgvfiesrghjrdhiugdrrghuqeenucggtffrrg htthgvrhhnpeehhfefkefgkeduveehffehieehudejfeejveejfedugfefuedtuedvhefh veeuffenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe grnhgurhgvfiesrghjrdhiugdrrghu X-ME-Proxy: Received: by mailuser.nyi.internal (Postfix, from userid 501) id 847BEE00D1; Wed, 16 Sep 2020 19:12:47 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.3.0-324-g0f99587-fm-20200916.004-g0f995879 Mime-Version: 1.0 Message-Id: <60f9f14a-c9be-45ac-b3a8-516ab73d9bee@www.fastmail.com> In-Reply-To: <20200916204216.9423-1-rentao.bupt@gmail.com> References: <20200916204216.9423-1-rentao.bupt@gmail.com> Date: Thu, 17 Sep 2020 08:42:27 +0930 From: "Andrew Jeffery" To: "Tao Ren" , "Linus Walleij" , "Bartosz Golaszewski" , "Joel Stanley" , linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org, openbmc@lists.ozlabs.org, "Tao Ren" Subject: Re: [PATCH] gpio: aspeed: fix ast2600 bank properties X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200916_191253_003605_086639BA X-CRM114-Status: UNSURE ( 8.94 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 17 Sep 2020, at 06:12, rentao.bupt@gmail.com wrote: > From: Tao Ren > > GPIO_U is mapped to the least significant byte of input/output mask, and > the byte in "output" mask should be 0 because GPIO_U is input only. All > the other bits need to be 1 because GPIO_V/W/X support both input and > output modes. > > Similarly, GPIO_Y/Z are mapped to the 2 least significant bytes, and the > according bits need to be 1 because GPIO_Y/Z support both input and > output modes. > > Fixes: ab4a85534c3e ("gpio: aspeed: Add in ast2600 details to Aspeed driver") > Signed-off-by: Tao Ren Thanks Tao, Reviewed-by: Andrew Jeffery _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel