Re: [PATCH v2] batman-adv: add dynamic, bridged-in TT VID detection support

[Sven Eckelmann <sven@narfation.org>]

[-- Attachment #1: Type: text/plain, Size: 1340 bytes --]

On Thursday, 14 November 2024 14:48:52 CET Nicolas Escande wrote:
> Hi there,
> 
> We've been running this for a few time and it's very usefull. So is there any
> news on merging this into the kernel ? Or is the BLA thing blocking ?

I am not in favour of changing the behavior of batman-adv. Now everyone can 
increase the number of managed VLANs without any control by the node admin.

And as Linus wrote, it also shows odd behaviors. And Antonio also didn't write 
his opinion here. I have therefore downgraded it from PATCH to RFC (instead of 
simply rejecting it).

[...]
> Or maybe I missed something ?
>  
> ---
>  net/batman-adv/soft-interface.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/net/batman-adv/soft-interface.c b/net/batman-adv/soft-interface.c
> index b61f35918b5d..d7de54734725 100644
> --- a/net/batman-adv/soft-interface.c
> +++ b/net/batman-adv/soft-interface.c
> @@ -599,7 +599,6 @@ batadv_softif_create_vlan(struct batadv_priv *bat_priv, unsigned short vid)
>  
>  	atomic_set(&vlan->ap_isolation, 0);
>  
> -	kref_get(&vlan->refcount);
>  	hlist_add_head_rcu(&vlan->list, &bat_priv->softif_vlan_list);
>  	spin_unlock_bh(&bat_priv->softif_vlan_list_lock);
>  
> 

This ref is for the VLAN list entry (just one line below the kref_get).
This patch is therefore definitely wrong.

Kind regards,
	Sven


[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 228 bytes --]