From: Thomas Huth <thuth@redhat.com>
To: "Daniel P. Berrangé" <berrange@redhat.com>, qemu-devel@nongnu.org
Cc: "Philippe Mathieu-Daudé" <philmd@linaro.org>
Subject: Re: [PATCH] test: make cached assets for functional tests read-only
Date: Mon, 21 Oct 2024 17:02:05 +0200 [thread overview]
Message-ID: <610dc78f-2546-4dd8-95d2-e449c107bb67@redhat.com> (raw)
In-Reply-To: <20241021123633.1391911-1-berrange@redhat.com>
On 21/10/2024 14.36, Daniel P. Berrangé wrote:
> This ensures that if a functional test runs QEMU with a writable
> disk pointing to a cached asset, an error will be reported, rather
> than silently modifying the cache file.
>
> As an example, tweaking test_sbsaref.py to set snapshot=off,
> results in a clear error:
>
> Command: ./build/qemu-system-aarch64 ...snip... -drive file=/var/home/berrange/.cache/qemu/download/44cdbae275ef1bb6dab1d5fbb59473d4f741e1c8ea8a80fd9e906b531d6ad461,format=raw,snapshot=off -cpu max,pauth=off
> Output: qemu-system-aarch64: Could not open '/var/home/berrange/.cache/qemu/download/44cdbae275ef1bb6dab1d5fbb59473d4f741e1c8ea8a80fd9e906b531d6ad461': Permission denied
>
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
> tests/functional/qemu_test/asset.py | 3 +++
> 1 file changed, 3 insertions(+)
Reviewed-by: Thomas Huth <thuth@redhat.com>
Tested-by: Thomas Huth <thuth@redhat.com>
next prev parent reply other threads:[~2024-10-21 15:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-21 12:36 [PATCH] test: make cached assets for functional tests read-only Daniel P. Berrangé
2024-10-21 14:59 ` Philippe Mathieu-Daudé
2024-10-21 15:02 ` Thomas Huth [this message]
2024-10-25 7:47 ` Thomas Huth
2024-10-25 8:47 ` Daniel P. Berrangé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=610dc78f-2546-4dd8-95d2-e449c107bb67@redhat.com \
--to=thuth@redhat.com \
--cc=berrange@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.