From: Florian Fainelli <f.fainelli@gmail.com>
To: Leon Romanovsky <leon@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Michal Kubecek <mkubecek@suse.cz>,
Shannon Nelson <snelson@pensando.io>
Cc: Leon Romanovsky <leonro@mellanox.com>,
Michal Kalderon <michal.kalderon@marvell.com>,
linux-netdev <netdev@vger.kernel.org>,
RDMA mailing list <linux-rdma@vger.kernel.org>
Subject: Re: [PATCH net-next v4] net/core: Replace driver version to be kernel version
Date: Mon, 27 Jan 2020 09:43:52 -0800 [thread overview]
Message-ID: <610dd4fb-4f7e-d3a6-cc75-7e4104dd8285@gmail.com> (raw)
In-Reply-To: <20200127072028.19123-1-leon@kernel.org>
On 1/26/20 11:20 PM, Leon Romanovsky wrote:
> net/ethtool/ioctl.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/net/ethtool/ioctl.c b/net/ethtool/ioctl.c
> index 182bffbffa78..0501b615e920 100644
> --- a/net/ethtool/ioctl.c
> +++ b/net/ethtool/ioctl.c
> @@ -17,6 +17,7 @@
> #include <linux/phy.h>
> #include <linux/bitops.h>
> #include <linux/uaccess.h>
> +#include <linux/vermagic.h>
> #include <linux/vmalloc.h>
> #include <linux/sfp.h>
> #include <linux/slab.h>
> @@ -655,6 +656,7 @@ static noinline_for_stack int ethtool_get_drvinfo(struct net_device *dev,
>
> memset(&info, 0, sizeof(info));
> info.cmd = ETHTOOL_GDRVINFO;
> + strlcpy(info.version, UTS_RELEASE, sizeof(info.version));
This is much more reasonable, thanks for addressing everyone's concerns
Leon.
--
Florian
prev parent reply other threads:[~2020-01-27 17:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-27 7:20 [PATCH net-next v4] net/core: Replace driver version to be kernel version Leon Romanovsky
2020-01-27 8:32 ` Shannon Nelson
2020-01-27 12:47 ` David Miller
2020-01-27 17:43 ` Florian Fainelli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=610dd4fb-4f7e-d3a6-cc75-7e4104dd8285@gmail.com \
--to=f.fainelli@gmail.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=leonro@mellanox.com \
--cc=linux-rdma@vger.kernel.org \
--cc=michal.kalderon@marvell.com \
--cc=mkubecek@suse.cz \
--cc=netdev@vger.kernel.org \
--cc=snelson@pensando.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.